KKcorps commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1865194105
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ########## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return needReload; } + @Override + public List<NeedRefreshResponse> getSegmentsForRefresh(TableConfig tableConfig, Schema schema) { + List<NeedRefreshResponse> segmentsRequiringRefresh = new ArrayList<>(); + List<SegmentDataManager> segmentDataManagers = acquireAllSegments(); Review Comment: Cool, I am fine with that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org