Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-24 Thread via GitHub
praveenc7 commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2106056300 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java: ## @@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataMan

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-22 Thread via GitHub
Jackie-Jiang merged PR #15869: URL: https://github.com/apache/pinot/pull/15869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2103594241 ## pinot-core/src/test/java/org/apache/pinot/core/plan/maker/QueryOverrideWithHintsTest.java: ## @@ -37,82 +33,26 @@ import org.apache.pinot.core.query.request.co

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2103593149 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java: ## @@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableData

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-22 Thread via GitHub
gortiz commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2101979544 ## pinot-core/src/test/java/org/apache/pinot/core/plan/maker/QueryOverrideWithHintsTest.java: ## @@ -37,82 +33,26 @@ import org.apache.pinot.core.query.request.context.

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-22 Thread via GitHub
gortiz commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2101973635 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java: ## @@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataManage

Re: [PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-21 Thread via GitHub
praveenc7 commented on code in PR #15869: URL: https://github.com/apache/pinot/pull/15869#discussion_r2101573268 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java: ## @@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataMan

[PR] Add APIs to IndexSegment as a preparation to support virtual DataSource [pinot]

2025-05-21 Thread via GitHub
Jackie-Jiang opened a new pull request, #15869: URL: https://github.com/apache/pinot/pull/15869 This is a preparation for #15350 Before this PR, in `IndexSegment`, `DataSource getDataSource(String column)` can only fetch `DataSource` for existing columns. This PR adds 2 APIs: