praveenc7 commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2106056300
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java:
##########
@@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataManager
tableDataManager, List<Segment
_notAcquiredSegments = notAcquiredSegments;
}
- @Override
- public boolean hasRealtime() {
- return _tableDataManager instanceof RealtimeTableDataManager;
- }
-
-
public TableDataManager getTableDataManager() {
return _tableDataManager;
}
- public List<SegmentDataManager> getSegmentDataManagers() {
- return _segmentDataManagers;
+ @Override
+ public Schema getSchema() {
+ return _tableDataManager.getCachedTableConfigAndSchema().getRight();
Review Comment:
Okay, just that based on our offline discussion, we agreed to avoid relying
on Helix messages—since in large clusters they can be delayed (we’ve seen
delays of up to 15 minutes)—which would cause queries to fail until the updates
arrive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
