abhishekbafna commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2136904193
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -1702,4 +1702,14 @@ public static class Groovy {
public static final String
yashmayya commented on code in PR #15990:
URL: https://github.com/apache/pinot/pull/15990#discussion_r2136901895
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -783,29 +781,7 @@ public List cancelRebalance(
vrajat commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2136881578
##
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##
@@ -172,22 +171,23 @@ public InvocationRecording activeRecording() {
*/
public static class
vrajat commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2136894900
##
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##
@@ -310,22 +325,26 @@ public void
setThreadResourceUsageProvider(T
vrajat opened a new issue, #16060:
URL: https://github.com/apache/pinot/issues/16060
`QueryServer` in MSE submits work asynchronously.
OOM protection framework assumes that there is a runner thread which is
waiting for all the worker threads. The framework cancels the runner thread if
ankitsultana commented on code in PR #16034:
URL: https://github.com/apache/pinot/pull/16034#discussion_r2136837250
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java:
##
@@ -380,6 +381,23 @@ public long getIndexCreationTime()
vrajat opened a new issue, #16059:
URL: https://github.com/apache/pinot/issues/16059
Request and correlation ids are created in the broker. The server may
generate mangled versions for its own use. However queries that are submitted
directly to server GRPC end points do not have a request/q
This is an automated email from the ASF dual-hosted git repository.
chrispeck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a5bc956fb0 [multistage] Handle Column Less Tup
ankitsultana commented on PR #16034:
URL: https://github.com/apache/pinot/pull/16034#issuecomment-2957578386
@tarun11Mavani : can you fix the UTs too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136697454
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -32,9 +32,9 @@ public class RebalanceConfig {
public
itschrispeck merged PR #16058:
URL: https://github.com/apache/pinot/pull/16058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
codecov-commenter commented on PR #16058:
URL: https://github.com/apache/pinot/pull/16058#issuecomment-2957420369
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16058?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136712870
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -32,9 +32,9 @@ public class RebalanceConfig {
publi
ankitsultana opened a new pull request, #16058:
URL: https://github.com/apache/pinot/pull/16058
Small change to fix broken support for column less tuples.
This issue was caught while I was working on #15958.
Not adding new tests for this since it will be covered by #15958.
--
somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136695381
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -690,9 +686,46 @@ public SuccessResponse deleteTenan
J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136690876
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -690,9 +686,46 @@ public SuccessResponse deleteTen
Jackie-Jiang commented on PR #15998:
URL: https://github.com/apache/pinot/pull/15998#issuecomment-2957225040
@klsince Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136686546
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -32,9 +32,9 @@ public class RebalanceConfig {
publi
J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2136687663
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalanceConfig.java:
##
@@ -27,18 +27,32 @@
public class Tenant
somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r213857
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -690,9 +686,46 @@ public SuccessResponse deleteTenan
Jackie-Jiang commented on code in PR #16002:
URL: https://github.com/apache/pinot/pull/16002#discussion_r2136632610
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/geospatial/BaseH3IndexCreator.java:
##
@@ -104,12 +106,25 @@ public ab
somandal commented on code in PR #16017:
URL: https://github.com/apache/pinot/pull/16017#discussion_r2136567027
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/MultiTierStrictRealtimeSegmentAssignment.java:
##
@@ -0,0 +1,87 @@
+/**
+ *
somandal commented on code in PR #16017:
URL: https://github.com/apache/pinot/pull/16017#discussion_r2136612615
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignmentTest.java:
##
@@ -255,9 +279,74 @@ public vo
J-HowHuang opened a new issue, #16057:
URL: https://github.com/apache/pinot/issues/16057
### Background
In the Tenant Rebalance API, the parameters `parallelWhitelist` and
`parallelBlacklist` have been used to categorize tables into the parallel or
sequential queue for rebalance operatio
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c96c318ef8 Enhance TableConfig and Schema validation (#16025)
add 064a86c647 Fix exception message in PinotDataTyp
Jackie-Jiang merged PR #16054:
URL: https://github.com/apache/pinot/pull/16054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
somandal commented on code in PR #16017:
URL: https://github.com/apache/pinot/pull/16017#discussion_r2136567027
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/MultiTierStrictRealtimeSegmentAssignment.java:
##
@@ -0,0 +1,87 @@
+/**
+ *
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.codehaus.plexus-plexus-utils-4.0.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was de91b3d6e2 Bump org.codehaus.plexus:plexus-utils from 3.6.0 to 4.
codecov-commenter commented on PR #16056:
URL: https://github.com/apache/pinot/pull/16056#issuecomment-2957125406
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16056?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang closed pull request #16048: Bump org.codehaus.plexus:plexus-utils
from 3.6.0 to 4.0.2
URL: https://github.com/apache/pinot/pull/16048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Jackie-Jiang merged PR #16025:
URL: https://github.com/apache/pinot/pull/16025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
somandal commented on code in PR #15990:
URL: https://github.com/apache/pinot/pull/15990#discussion_r2136337151
##
pinot-tools/src/main/java/org/apache/pinot/tools/PinotTableRebalancer.java:
##
@@ -55,7 +57,12 @@ public PinotTableRebalancer(String zkAddress, String
clusterName,
dependabot[bot] commented on PR #16048:
URL: https://github.com/apache/pinot/pull/16048#issuecomment-2957054792
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
dinoocch opened a new pull request, #16056:
URL: https://github.com/apache/pinot/pull/16056
#15264 switches this query log statement to INFO level.
This makes excellent sense for clusters with very variable query patterns or
few overall qps, but we have some clusters for which this ex
vvivekiyer commented on code in PR #16004:
URL: https://github.com/apache/pinot/pull/16004#discussion_r2136151788
##
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##
@@ -310,22 +325,26 @@ public void
setThreadResourceUsageProvid
codecov-commenter commented on PR #16054:
URL: https://github.com/apache/pinot/pull/16054#issuecomment-2956609345
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16054?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
songwdfu opened a new issue, #16055:
URL: https://github.com/apache/pinot/issues/16055
Currently in Pinot, SUM0 is actually implemented using SUM.
Current PinotAggregateReduceFunctionsRule + AggregateCaseToFilterRule
results in the following behavior for queries like these:
**
pengding-stripe commented on issue #16024:
URL: https://github.com/apache/pinot/issues/16024#issuecomment-2956509678
thanks @ankitsultana, I feel this option should be default to true for this
case? Our queries are sent from the user, it's hard for us to validate all of
them and users could
ayesheepatra07 opened a new pull request, #16054:
URL: https://github.com/apache/pinot/pull/16054
toTimestamp(Object) method of the BYTE enum constant within PinotDataType
has a typo where the exception text reads “Cannot convert value from BOOLEAN to
TIMESTAMP", updated message to say BYTE
ankitsultana commented on issue #16024:
URL: https://github.com/apache/pinot/issues/16024#issuecomment-2956420372
@pengding-stripe : the new MSE Query Optimizer is capable of handling this
if you set `useBrokerPruning=true` in the query options:
https://github.com/apache/pinot/pull/15959
jtao15 opened a new issue, #16053:
URL: https://github.com/apache/pinot/issues/16053
The storage quota check during segment upload currently requires retrieving
segment sizes from all servers for the table. If any server is unresponsive,
the quota check fails and blocks segment pushes. We s
codecov-commenter commented on PR #16052:
URL: https://github.com/apache/pinot/pull/16052#issuecomment-2956290960
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16052?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
tarun11Mavani commented on code in PR #16034:
URL: https://github.com/apache/pinot/pull/16034#discussion_r2136014001
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -830,12 +834,61 @@ public void replaceConsumingSegmen
jadami10 opened a new pull request, #16052:
URL: https://github.com/apache/pinot/pull/16052
This is a small dep fix to specify the dependency in `pinot-s3` for guava.
It is used in `S3PinotFS.java` and `S3Config.java`. Our own internal build
started failing at compile time without this when
noob-se7en commented on code in PR #15903:
URL: https://github.com/apache/pinot/pull/15903#discussion_r2135819344
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -2958,15 +2958,31 @@ public void resetSegment(String t
vrajat opened a new pull request, #16051:
URL: https://github.com/apache/pinot/pull/16051
Closes #16042
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backwa
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch
dependabot/maven/com.microsoft.azure-msal4j-1.21.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 5eddf7a1e0 Bump com.microsoft.azure:msal4j from 1.20.1 to 1.21.0
The r
yashmayya merged PR #16049:
URL: https://github.com/apache/pinot/pull/16049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
yashmayya merged PR #16047:
URL: https://github.com/apache/pinot/pull/16047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 7572b182cf Bump com.microsoft.azure:msal4j from 1.20.1 to 1.21.0
(#16050)
add e1d519fca6 Bump com.gradle:commo
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch
dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 80b14d2c33 Bump com.gradle:common-custom-user-da
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 95a1365751 Bump software.amazon.awssdk:bom from 2.31.58 to 2.31.59
(#16047)
add 7572b182cf Bump com.microsoft.
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.59
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 1600f2476e Bump software.amazon.awssdk:bom from 2.31.58 to 2.31.59
Th
yashmayya merged PR #16050:
URL: https://github.com/apache/pinot/pull/16050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 95a1365751 Bump software.amazon.awssdk:bom fro
dependabot[bot] opened a new pull request, #16050:
URL: https://github.com/apache/pinot/pull/16050
Bumps
[com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java)
from 1.20.1 to 1.21.0.
Changelog
Sourced from https://github.com/AzureAD/micr
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.microsoft.azure-msal4j-1.21.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 5eddf7a1e0 Bump com.microsoft.azure:msal4j from 1.20.1 to 1.21.0
No n
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 80b14d2c33 Bump com.gradle:common-custom-user-d
dependabot[bot] opened a new pull request, #16048:
URL: https://github.com/apache/pinot/pull/16048
Bumps
[org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils)
from 3.6.0 to 4.0.2.
Release notes
Sourced from https://github.com/codehaus-plexus/plexus-ut
dependabot[bot] opened a new pull request, #16049:
URL: https://github.com/apache/pinot/pull/16049
Bumps
[com.gradle:common-custom-user-data-maven-extension](https://github.com/gradle/common-custom-user-data-maven-extension)
from 2.0.2 to 2.0.3.
Release notes
Sourced from https://
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.codehaus.plexus-plexus-utils-4.0.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at de91b3d6e2 Bump org.codehaus.plexus:plexus-utils from 3.6.0 to 4.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.59
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 1600f2476e Bump software.amazon.awssdk:bom from 2.31.58 to 2.31.59
N
dependabot[bot] opened a new pull request, #16047:
URL: https://github.com/apache/pinot/pull/16047
Bumps software.amazon.awssdk:bom from 2.31.58 to 2.31.59.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
yashmayya commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2135609876
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/LogicalTableMetadataCacheTest.java:
##
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software
yashmayya commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2135608841
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/LogicalTableMetadataCacheTest.java:
##
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software
yashmayya commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2135604254
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/LogicalTableMetadataCacheTest.java:
##
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software
yashmayya commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2135600671
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -1702,4 +1702,14 @@ public static class Groovy {
public static final String GRO
codecov-commenter commented on PR #16046:
URL: https://github.com/apache/pinot/pull/16046#issuecomment-2955525657
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16046?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
vrajat commented on code in PR #16043:
URL: https://github.com/apache/pinot/pull/16043#discussion_r2135513783
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java:
##
@@ -129,12 +132,43 @@ public TableAuthorizationResult
authorize(Requ
yashmayya opened a new pull request, #16046:
URL: https://github.com/apache/pinot/pull/16046
- Builds on top of https://github.com/apache/pinot/pull/15990/ and fixes
https://github.com/apache/pinot/issues/16005.
- Adds four new controller configs (one for each controller job type) to
con
yashmayya commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2135395629
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -234,6 +289,11 @@ private List
buildJoinedDataBlockAnti(Mse
yashmayya commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2135395629
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -234,6 +289,11 @@ private List
buildJoinedDataBlockAnti(Mse
yashmayya commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2135395629
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -234,6 +289,11 @@ private List
buildJoinedDataBlockAnti(Mse
codecov-commenter commented on PR #16045:
URL: https://github.com/apache/pinot/pull/16045#issuecomment-2955253510
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/16045?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2135359159
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -98,8 +104,36 @@ public String toExplainString() {
protec
xiangfu0 commented on code in PR #15648:
URL: https://github.com/apache/pinot/pull/15648#discussion_r2135334331
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##
@@ -170,6 +178,34 @@ public static PropertiesConfiguration fromFile(@Nullable
F
gortiz commented on code in PR #16038:
URL: https://github.com/apache/pinot/pull/16038#discussion_r2135199476
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -59,16 +60,21 @@ public class HashJoinOperator extends BaseJoin
noob-se7en opened a new pull request, #16045:
URL: https://github.com/apache/pinot/pull/16045
**Problem Statement:**
Sometimes due to changes like table rebalance/changes in upstream partitions
lead to ingestion metrics not being cleaned up on servers. This leads to
servers emitting inge
wirybeaver opened a new pull request, #16044:
URL: https://github.com/apache/pinot/pull/16044
Meant to introduce instance level config to specify the skipInvalidJson's
default value. When instance level's default value is not null and table
config's default value is null, we will use the in
9aman opened a new pull request, #16043:
URL: https://github.com/apache/pinot/pull/16043
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
vrajat opened a new issue, #16042:
URL: https://github.com/apache/pinot/issues/16042
For every query execution thread, a ThreadResourceUsageProvider is created.
Example for a worker:
```
public static void setupWorker(int taskId,
ThreadExecutionContext.TaskType taskType,
81 matches
Mail list logo
