wirybeaver opened a new pull request, #16044: URL: https://github.com/apache/pinot/pull/16044
Meant to introduce instance level config to specify the skipInvalidJson's default value. When instance level's default value is not null and table config's default value is null, we will use the instance level's default value as the final value of Json's IndexConfig.skipInvalidJson. But I just realized that the places which calling spi is not aware of the pinot instance level config and thus will introduce inconsistency. Thus, give up the approach of using instance level config and directly change the default value to true, which makes more sense in production environment. Two typical spi library case that creates index config. *Offline pipeline application*: segments are created outside of pinot cluster and then push to pinot. ``` java IndexingConfig indexingConfig = new IndexingConfig(); Segment ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
