yashmayya commented on code in PR #15881:
URL: https://github.com/apache/pinot/pull/15881#discussion_r2135600671
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1702,4 +1702,14 @@ public static class Groovy {
public static final String GROOVY_QUERY_STATIC_ANALYZER_CONFIG =
"pinot.groovy.query.static.analyzer";
public static final String GROOVY_INGESTION_STATIC_ANALYZER_CONFIG =
"pinot.groovy.ingestion.static.analyzer";
}
+
+ /**
+ * ZK paths used by Pinot.
+ */
+ public static class ZkPaths {
+ public static final String LOGICAL_TABLE_PARENT_PATH = "/LOGICAL/TABLE";
+ public static final String LOGICAL_TABLE_PATH_PREFIX = "/LOGICAL/TABLE/";
+ public static final String TABLE_CONFIG_PATH_PREFIX = "/CONFIGS/TABLE/";
+ public static final String SCHEMA_PATH_PREFIX = "/SCHEMAS/";
Review Comment:
Okay, let's refactor this in a separate PR in that case (i.e., move all
usages of the constants from `ZKMetadataProvider` to these new ones in
`CommonConstants`).
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/LogicalTableConfig.java:
##########
@@ -31,6 +31,19 @@
import org.apache.pinot.spi.utils.JsonUtils;
+/**
+ * LogicalTableConfig represents the configuration for a logical table in
Pinot.
+ * tableName: The name of the logical table.
+ * physicalTableConfigMap: A map of physical table names to their
configurations.
+ * brokerTenant: The tenant for the broker.
+ * queryConfig: Configuration for query execution on the logical table.
+ * quotaConfig: Configuration for quota management on the logical table.
+ * refOfflineTableName: The name of the offline table whose table config is
referenced by this logical table.
+ * refRealtimeTableName: The name of the realtime table whose table config is
referenced by this logical table.
+ * timeBoundaryConfig: Configuration for time boundaries of the logical table.
This is used to determine the time
+ * boundaries for queries on the logical table, especially in hybrid scenarios
where both offline and realtime
+ * data are present.
Review Comment:
This isn't really readable in rendered form. Could you please use list tags
(`<ul>` and `<li>`) if using Javadoc format or else `-` for markdown style
comments (`///`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
