Re: [PR] Logical table CRUD operations. [pinot]

2025-04-10 Thread via GitHub
vrajat commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2038802160 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java: ## @@ -376,6 +385,7 @@ public static boolean removeSegmentZKMetadata(ZkHelixProp

Re: [PR] Fix kinesis fetchStreamPartitionOffset method [pinot]

2025-04-10 Thread via GitHub
KKcorps merged PR #15512: URL: https://github.com/apache/pinot/pull/15512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

(pinot) branch master updated (978950bcb8 -> 0bb4303c64)

2025-04-10 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 978950bcb8 Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 (#15514) add 0bb4303c64 Fix kinesis fetch

Re: [PR] [multistage] Add Leaf Stage Worker Assignment / Boundary / Agg Rules [pinot]

2025-04-10 Thread via GitHub
ankitsultana commented on code in PR #15481: URL: https://github.com/apache/pinot/pull/15481#discussion_r2038690016 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/RelToPRelConverter.java: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Softw

Re: [PR] [multistage] Add Leaf Stage Worker Assignment / Boundary / Agg Rules [pinot]

2025-04-10 Thread via GitHub
ankitsultana commented on code in PR #15481: URL: https://github.com/apache/pinot/pull/15481#discussion_r2038690016 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/RelToPRelConverter.java: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Softw

Re: [PR] [multistage] Add Leaf Stage Worker Assignment / Boundary / Agg Rules [pinot]

2025-04-10 Thread via GitHub
itschrispeck commented on code in PR #15481: URL: https://github.com/apache/pinot/pull/15481#discussion_r2038047401 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/RelToPRelConverter.java: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Softw

(pinot) branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-10.2 created (now 0662157317)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-10.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 0662157317 Bump com.nimbusds:nimbus-jose-jwt from 10.1 to 10.2 No new

Re: [PR] Helix upgrade to 1.4.3 : Additional changes [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15519: URL: https://github.com/apache/pinot/pull/15519#issuecomment-2795382253 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15519?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15518: URL: https://github.com/apache/pinot/pull/15518#issuecomment-2795371474 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15518?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/org.codehaus.plexus-plexus-classworlds-2.9.0 created (now dd66a7f33e)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.plexus-plexus-classworlds-2.9.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at dd66a7f33e Bump org.codehaus.plexus:plexus-classworlds from

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
jayeshchoudhary commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2036877710 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerResponses/RebalanceServerResponseLabelValue.tsx: ## @@

Re: [PR] Add startree json index oss changes [pinot]

2025-04-10 Thread via GitHub
bziobrowski commented on code in PR #15508: URL: https://github.com/apache/pinot/pull/15508#discussion_r2035548095 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractIndexTransformFunction.java: ## @@ -69,6 +70,12 @@ public void init(List ar

Re: [PR] Fix threshold update on stale metadata [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15480: URL: https://github.com/apache/pinot/pull/15480#issuecomment-2784685409 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15480?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] (Minor) fix logs [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15438: URL: https://github.com/apache/pinot/pull/15438#discussion_r2035168494 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1066,13 +1066,14 @@ public void segment

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
himanish-star commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2036977677 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerResponses/RebalanceServerResponseLabelValue.tsx: ## @@ -2

[PR] Helix upgrade to 1.4.3 : Additional changes [pinot]

2025-04-10 Thread via GitHub
somandal opened a new pull request, #15519: URL: https://github.com/apache/pinot/pull/15519 Capturing additional changes that will be required for the Helix 1.4.3 upgrade to handle the behavior change where the ExternalView entry may be missing for OFFLINE segments. If ExternalView is OFFLI

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15517: URL: https://github.com/apache/pinot/pull/15517#issuecomment-2795320428 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15517?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix segment throttle metrics by initializing them [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15479: URL: https://github.com/apache/pinot/pull/15479#issuecomment-2784159390 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15479?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/pulsar.version-4.0.4 created (now fa86a1c2cb)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/pulsar.version-4.0.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at fa86a1c2cb Bump pulsar.version from 4.0.3 to 4.0.4 No new revisions were added by t

Re: [PR] Preserve the Order of the Pre-check Items [pinot]

2025-04-10 Thread via GitHub
J-HowHuang commented on code in PR #15496: URL: https://github.com/apache/pinot/pull/15496#discussion_r2038422188 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -77,7 +78,9 @@ public Map check(PreCheckCo

[PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-10 Thread via GitHub
J-HowHuang opened a new pull request, #15518: URL: https://github.com/apache/pinot/pull/15518 ## Description Add a new controller gauge metrics `pinot_controller_tableRebalanceJobProgressPercent` to expose the progress in percent for each rebalance job that has a `TableRebalanceObser

[PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-10 Thread via GitHub
J-HowHuang opened a new pull request, #15517: URL: https://github.com/apache/pinot/pull/15517 ## Description Add a new controller meter global metrics `pinot_controller_tableRebalanceInProgressGlobal` to keep track of the number of in progress rebalance job (i.e. excludes dry-run, do

Re: [PR] (Minor) fix logs [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15438: URL: https://github.com/apache/pinot/pull/15438#discussion_r2036124534 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -621,11 +621,17 @@ private void commit

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.20.7 created (now cfdab1e2b3)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.20.7 in repository https://gitbox.apache.org/repos/asf/pinot.git at cfdab1e2b3 Bump org.webjars:swagger-ui from 5.20.6 to 5.20.7 No new revis

[PR] Logical table CRUD operations. [pinot]

2025-04-10 Thread via GitHub
abhishekbafna opened a new pull request, #15515: URL: https://github.com/apache/pinot/pull/15515 CRUD implementation for the logical tables. * Get all the logical tables * Get logical table configuration * Create a logical table * Update a logical table * Delete a logical t

Re: [PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15500: URL: https://github.com/apache/pinot/pull/15500#discussion_r2036265349 ## pom.xml: ## @@ -294,6 +294,7 @@ 5.5.1 2.27ea1 2.27ea2 + 2.54.1 Review Comment: Put it in the `Google Libraries` section for easier manage

(pinot) branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-3.19.3 updated (3b64cd2866 -> 0dc24dec49)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-3.19.3 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 3b64cd2866 Bump nl.jqno.equalsverifier:equalsverifier from

(pinot) branch master updated: Add DISTINCT_COUNT_OFF_HEAP aggregate function (#15469)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f1da16473b Add DISTINCT_COUNT_OFF_HEAP aggregate

[PR] Fix threshold update on stale metadata [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang opened a new pull request, #15480: URL: https://github.com/apache/pinot/pull/15480 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
jayeshchoudhary commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2036909485 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionToggleSw

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2038338832 ## pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java: ## @@ -785,8 +785,9 @@ public void testShouldNotSkipUnf

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2038338832 ## pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java: ## @@ -785,8 +785,9 @@ public void testShouldNotSkipUnf

Re: [PR] Table Rebalance Logger [pinot]

2025-04-10 Thread via GitHub
J-HowHuang commented on PR #15436: URL: https://github.com/apache/pinot/pull/15436#issuecomment-2795133266 @Jackie-Jiang It's a fair point. Adopted the suggestion to have a new logger from `LoggerFactory` and to name it with job ID -- This is an automated message from the Apache Git Servi

Re: [PR] [WIP] [multistage] Add Leaf Stage Worker Assignment / Boundary / Agg Rules [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15481: URL: https://github.com/apache/pinot/pull/15481#issuecomment-2787443433 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15481?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.3 to 2.44.4 [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15488: URL: https://github.com/apache/pinot/pull/15488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Adding codecov token [pinot]

2025-04-10 Thread via GitHub
xiangfu0 opened a new pull request, #15493: URL: https://github.com/apache/pinot/pull/15493 https://issues.apache.org/jira/browse/NIFI-13210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-10 Thread via GitHub
klsince merged PR #15266: URL: https://github.com/apache/pinot/pull/15266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.20.7 deleted (was cfdab1e2b3)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.20.7 in repository https://gitbox.apache.org/repos/asf/pinot.git was cfdab1e2b3 Bump org.webjars:swagger-ui from 5.20.6 to 5.20.7 The revisions tha

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.18 [pinot]

2025-04-10 Thread via GitHub
dependabot[bot] commented on PR #15504: URL: https://github.com/apache/pinot/pull/15504#issuecomment-2792458500 Superseded by #15514. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add startree json index oss changes [pinot]

2025-04-10 Thread via GitHub
bziobrowski commented on code in PR #15508: URL: https://github.com/apache/pinot/pull/15508#discussion_r2035551800 ## pinot-core/src/test/java/org/apache/pinot/queries/JsonDataTypeQueriesTest.java: ## @@ -52,12 +52,12 @@ Review Comment: Changed this file to be able to over

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2038154051 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -518,15 +518,13 @@ public void addConsumingSegment(Strin

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-04-10 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2032716826 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/RowHeapDataBlock.java: ## @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2038128855 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1722,16 +1726,13 @@ public RealtimeSegmentDataManager

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2038126868 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -518,15 +518,13 @@ public void addConsumingSegment(Strin

Re: [PR] Fix HttpsSegmentFetcher to use the configurable timeouts [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15485: URL: https://github.com/apache/pinot/pull/15485#issuecomment-2785229451 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Extend POSSIBLE_QUERY_OPTIONS in PinotConnection to all query level o… [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15281: URL: https://github.com/apache/pinot/pull/15281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-10 Thread via GitHub
ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038121565 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-10 Thread via GitHub
jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038114680 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/QueryOptionParser.java: ## @@ -0,0 +1,241 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-10 Thread via GitHub
jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038080692 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
himanish-star commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2038011285 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.ts

Re: [PR] Set InstanceType for OOM Protection during startup [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15374: URL: https://github.com/apache/pinot/pull/15374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.18 [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15504: URL: https://github.com/apache/pinot/pull/15504#issuecomment-2789560387 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15504?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump com.microsoft.azure:msal4j from 1.19.1 to 1.20.0 [pinot]

2025-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #15492: URL: https://github.com/apache/pinot/pull/15492 Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.19.1 to 1.20.0. Release notes Sourced from https://github.com/AzureAD/

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2037964294 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-10 Thread via GitHub
jitendrakr88 commented on PR #15498: URL: https://github.com/apache/pinot/pull/15498#issuecomment-2794678752 Updated the implementation to collapse excessive whitespace blocks to a single whitespace. @ankitsultana @Jackie-Jiang please help take a look. -- This is an automated mess

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-10 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2037942177 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -173,4 +189,18 @@ public int hashCode() { public String toString() { r

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-10 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2037942177 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -173,4 +189,18 @@ public int hashCode() { public String toString() { r

Re: [PR] [Canary Routing] pass in the preferred replica group option to change the routing strategy for canary queries [pinot]

2025-04-10 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2037942177 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ServerInstance.java: ## @@ -173,4 +189,18 @@ public int hashCode() { public String toString() { r

Re: [PR] Fix committing segments list [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15495: URL: https://github.com/apache/pinot/pull/15495#discussion_r2037910523 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -2573,66 +2573,37 @@ public Set getSeg

Re: [PR] Minor Refactoring and fixes in Ingestion [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2037888495 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -518,15 +518,13 @@ public void addConsumingSegment(Str

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 (#15514)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 978950bcb8 Bump software.amazon.awssdk:bom from 2

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.19 deleted (was 9495d8728c)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.19 in repository https://gitbox.apache.org/repos/asf/pinot.git was 9495d8728c Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 The r

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15514: URL: https://github.com/apache/pinot/pull/15514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/okio.version-3.11.0 deleted (was 698b847034)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/okio.version-3.11.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 698b847034 Bump okio.version from 3.10.2 to 3.11.0 The revisions that were on this branc

(pinot) branch master updated: Bump okio.version from 3.10.2 to 3.11.0 (#15513)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ba9f61c67b Bump okio.version from 3.10.2 to 3.11.

Re: [PR] Bump okio.version from 3.10.2 to 3.11.0 [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15513: URL: https://github.com/apache/pinot/pull/15513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2037869661 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/LogicalTable.java: ## @@ -0,0 +1,123 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix Direct Memory OOM on Server [pinot]

2025-04-10 Thread via GitHub
Copilot commented on code in PR #15335: URL: https://github.com/apache/pinot/pull/15335#discussion_r2037547484 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMHandler.java: ## @@ -63,25 +73,63 @@ public void channelInactive(ChannelHandlerContext ctx) {

(pinot) branch master updated: Improve ingestion related logs (#15438)

2025-04-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3ca8f96e59 Improve ingestion related logs (#15438

Re: [PR] Improve ingestion related logs [pinot]

2025-04-10 Thread via GitHub
Jackie-Jiang merged PR #15438: URL: https://github.com/apache/pinot/pull/15438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
himanish-star commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2037840468 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx: ## @@ -63,7 +64,10 @@ export const RebalanceServerStatusOp

Re: [PR] Minor Refactoring [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2037826719 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -747,6 +747,14 @@ public void run() { _segm

[I] JSON_EXTRACT_INDEX null pointer exception, this._arguments is null [pinot]

2025-04-10 Thread via GitHub
njasm opened a new issue, #15516: URL: https://github.com/apache/pinot/issues/15516 The following query fails with pinot **1.3.0** (using docker image `release-1.3.0-21-amazoncorretto` ) but works fine with **1.2.0** (docker image `1.2.0-21-amazoncorretto`) Query ```

Re: [PR] (Minor) fix logs [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15438: URL: https://github.com/apache/pinot/pull/15438#discussion_r2037498539 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -621,11 +621,17 @@ private void commitSe

Re: [PR] Minor Refactoring [pinot]

2025-04-10 Thread via GitHub
noob-se7en commented on code in PR #15419: URL: https://github.com/apache/pinot/pull/15419#discussion_r2037755018 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -747,6 +747,14 @@ public void run() { _segm

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15515: URL: https://github.com/apache/pinot/pull/15515#issuecomment-2792916198 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15515?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump okio.version from 3.10.2 to 3.11.0 [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15513: URL: https://github.com/apache/pinot/pull/15513#issuecomment-2792552691 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15513?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15514: URL: https://github.com/apache/pinot/pull/15514#issuecomment-2792560447 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15514?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/okio.version-3.11.0 created (now 698b847034)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/okio.version-3.11.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 698b847034 Bump okio.version from 3.10.2 to 3.11.0 No new revisions were added by th

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.19 created (now 9495d8728c)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.19 in repository https://gitbox.apache.org/repos/asf/pinot.git at 9495d8728c Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 N

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.18 [pinot]

2025-04-10 Thread via GitHub
dependabot[bot] closed pull request #15504: Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.18 URL: https://github.com/apache/pinot/pull/15504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.19 [pinot]

2025-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #15514: URL: https://github.com/apache/pinot/pull/15514 Bumps software.amazon.awssdk:bom from 2.31.16 to 2.31.19. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.18 deleted (was f3942a0f69)

2025-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.18 in repository https://gitbox.apache.org/repos/asf/pinot.git was f3942a0f69 Bump software.amazon.awssdk:bom from 2.31.16 to 2.31.18 T

[PR] Bump okio.version from 3.10.2 to 3.11.0 [pinot]

2025-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #15513: URL: https://github.com/apache/pinot/pull/15513 Bumps `okio.version` from 3.10.2 to 3.11.0. Updates `com.squareup.okio:okio` from 3.10.2 to 3.11.0 Changelog Sourced from https://github.com/square/okio/blob/master/CHANGELOG.md";>c

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
himanish-star commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2036980465 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionToggleSwit

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-10 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2036916635 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] [bugfix][ui] Fixes for table rebalance UI [pinot]

2025-04-10 Thread via GitHub
jayeshchoudhary commented on code in PR #15511: URL: https://github.com/apache/pinot/pull/15511#discussion_r2036878680 ## pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx: ## @@ -63,7 +64,10 @@ export const RebalanceServerStatusO

Re: [PR] Fix kinesis fetchStreamPartitionOffset method [pinot]

2025-04-10 Thread via GitHub
codecov-commenter commented on PR #15512: URL: https://github.com/apache/pinot/pull/15512#issuecomment-2792061128 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15512?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix kinesis fetchStreamPartitionOffset method [pinot]

2025-04-10 Thread via GitHub
KKcorps opened a new pull request, #15512: URL: https://github.com/apache/pinot/pull/15512 Fixes the implementation added in this PR - https://github.com/apache/pinot/pull/14713/files The previous implementation was buggy since it expects shardIds to be of format `shardId-[partitionI

Re: [PR] Fix committing segments list [pinot]

2025-04-10 Thread via GitHub
KKcorps commented on code in PR #15495: URL: https://github.com/apache/pinot/pull/15495#discussion_r2036420411 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -2573,66 +2573,37 @@ public Set getSegments