KKcorps commented on code in PR #15495:
URL: https://github.com/apache/pinot/pull/15495#discussion_r2036420411
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2573,66 +2573,37 @@ public Set<String> getSegmentsYetToBeCommitted(String
tableNameWithType, Set<Str
* @param committingSegments List of new segment names that are currently in
COMMITTING state.
* If null, returns true without making any changes
to the existing list
* @return true if the synchronization succeeds, false if there's a failure
in updating ZooKeeper
- * @see #getCommittingSegments for the logic that filters out segments no
longer in COMMITTING state
*/
- public boolean syncCommittingSegments(String realtimeTableName, @NotNull
List<String> committingSegments) {
+ public boolean syncCommittingSegments(String realtimeTableName, List<String>
committingSegments) {
Review Comment:
Is this method thread safe? What happens when we get two parallel calls to
this method with same table but different comittingSegments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
