noob-se7en commented on code in PR #15419:
URL: https://github.com/apache/pinot/pull/15419#discussion_r2038338832
##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java:
##########
@@ -785,8 +785,9 @@ public void
testShouldNotSkipUnfilteredMessagesIfNotIndexedAndTimeThresholdIsRea
@Override
public Long get() {
long now = System.currentTimeMillis();
- // now() is called once in the run() method, once before each batch
reading and once for every row indexation
- if (_timeCheckCounter.incrementAndGet() <=
FakeStreamConfigUtils.SEGMENT_FLUSH_THRESHOLD_ROWS + 4) {
+ // now() is called once in the run() method, then once on setting
consumeStartTime, once before each batch
+ // reading and once for every row indexation
+ if (_timeCheckCounter.incrementAndGet() <=
FakeStreamConfigUtils.SEGMENT_FLUSH_THRESHOLD_ROWS + 5) {
Review Comment:
tried removing this painful test depending on _timeCheckCounter but the
usage of it is spread across and requires some good refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
