[PR] Revert the null value handling when nullHandlingEnabled is false [pinot]

2025-03-26 Thread via GitHub
jackjlli opened a new pull request, #15382: URL: https://github.com/apache/pinot/pull/15382 Before this [PR](https://github.com/apache/pinot/pull/15158), when the result value is null, it will be handled in the following method regardless of the value of `nullHandlingEnabled`. ```

Re: [PR] Metrics for monitoring PROPERTYSTORE/SEGMENTS/'s getChildren response size [pinot]

2025-03-26 Thread via GitHub
9aman commented on PR #15345: URL: https://github.com/apache/pinot/pull/15345#issuecomment-2756672665 @rhodo I understand this PR has already been merged but would like to understand following 1. What is the rationale of adding this metric. Where would we need this ? 2. The consta

(pinot) branch fix-null-in-agg-result-block created (now d08b34a0c6)

2025-03-26 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-null-in-agg-result-block in repository https://gitbox.apache.org/repos/asf/pinot.git at d08b34a0c6 Revert the null value handling when nullHandlingEnabled is false This branch includes

(pinot) 01/01: Revert the null value handling when nullHandlingEnabled is false

2025-03-26 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-null-in-agg-result-block in repository https://gitbox.apache.org/repos/asf/pinot.git commit d08b34a0c630e1d4ed19d6c601ce5f645f9643cc Author: jlli_LinkedIn AuthorDate: Wed Mar 26 22:20:19 2025 -

Re: [PR] Retry on segment cannot build [pinot]

2025-03-26 Thread via GitHub
chenboat merged PR #15234: URL: https://github.com/apache/pinot/pull/15234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add getter for PreCheckContext [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15339: URL: https://github.com/apache/pinot/pull/15339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014962975 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java: ## @@ -0,0 +1,302 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15261: URL: https://github.com/apache/pinot/pull/15261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Consumes segments in strict order of sequence number (#15261)

2025-03-26 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new cf74f5ad6d Consumes segments in strict order of s

(pinot) branch master updated (19fde79121 -> 4f1b39c3ab)

2025-03-26 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 19fde79121 Metrics for monitoring PROPERTYSTORE/SEGMENTS/'s getChildren response size (#15345) add 4f1b39c3ab All

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-26 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005376991 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerExecutorTest.java: ## @@ -101,6 +104,15 @@ public void tearDownMethod()

Re: [PR] Enhance index and field config validation to block adding bloomfilter on boolean column [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15283: URL: https://github.com/apache/pinot/pull/15283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Enhance index and field config validation to block adding bloomfilter on boolean column (#15283)

2025-03-26 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ff0db32e49 Enhance index and field config validat

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15296: URL: https://github.com/apache/pinot/pull/15296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Metrics for monitoring PROPERTYSTORE/SEGMENTS/'s getChildren response size [pinot]

2025-03-26 Thread via GitHub
xiangfu0 merged PR #15345: URL: https://github.com/apache/pinot/pull/15345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Metrics for monitoring PROPERTYSTORE/SEGMENTS/'s getChildren response size (#15345)

2025-03-26 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 19fde79121 Metrics for monitoring PROPERTYSTORE/

(pinot) branch master updated (3bcca12e4c -> c25ac653b6)

2025-03-26 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3bcca12e4c Retry on segment cannot build (#15234) add c25ac653b6 Add off-heap set implementations (#15205) No new

Re: [PR] Add off-heap distinct set implementations [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15205: URL: https://github.com/apache/pinot/pull/15205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (700cffe800 -> 3bcca12e4c)

2025-03-26 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 700cffe800 Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs (#1

Re: [PR] Add metrics for tracking zookeeper's max buffer size in controller [pinot]

2025-03-26 Thread via GitHub
xiangfu0 commented on PR #15380: URL: https://github.com/apache/pinot/pull/15380#issuecomment-2755798438 Since this is client side jutebuffer value, shall we publish this metric for all controller/broker/server/minion components? -- This is an automated message from the Apache Git Service

Re: [PR] Add off-heap distinct set implementations [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on code in PR #15205: URL: https://github.com/apache/pinot/pull/15205#discussion_r2015067099 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/distinct/BaseOffHeapDistinctSet.java: ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

Re: [PR] Add metrics for tracking zookeeper's max buffer size in controller [pinot]

2025-03-26 Thread via GitHub
codecov-commenter commented on PR #15380: URL: https://github.com/apache/pinot/pull/15380#issuecomment-2755835085 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang merged PR #15330: URL: https://github.com/apache/pinot/pull/15330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs (#15330)

2025-03-26 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 700cffe800 Fix up parsing of controller timers t

(pinot) branch master updated: Support jsonKeyValueArrayToMap function (#15352)

2025-03-26 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new de8fa0beb6 Support jsonKeyValueArrayToMap functi

Re: [PR] Support jsonKeyValueArrayToMap function [pinot]

2025-03-26 Thread via GitHub
xiangfu0 merged PR #15352: URL: https://github.com/apache/pinot/pull/15352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] Add metrics for tracking zookeeper's max buffer size in controller [pinot]

2025-03-26 Thread via GitHub
rhodo opened a new pull request, #15380: URL: https://github.com/apache/pinot/pull/15380 Log zookeeper's juteMaxBuffer size during the start of controller. This can be helpful to understand how much is the znode size close to the limit. Test locally, I can see the metrics show up:

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014967744 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java: ## @@ -0,0 +1,302 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] [Cleanup] Remove system.out from #15088 [pinot]

2025-03-26 Thread via GitHub
xiangfu0 merged PR #15379: URL: https://github.com/apache/pinot/pull/15379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (c5514f698e -> b87bee5f67)

2025-03-26 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c5514f698e Change display of rebalance response (#15331) add b87bee5f67 Remove system.out (#15379) No new revisi

[PR] [Cleanup] Remove system.out from #15088 [pinot]

2025-03-26 Thread via GitHub
xiangfu0 opened a new pull request, #15379: URL: https://github.com/apache/pinot/pull/15379 Remove system.out from #15088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-26 Thread via GitHub
somandal commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2014866761 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java: ## @@ -72,13 +72,26 @@ public void timerTest(ControllerT

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2014851549 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java: ## @@ -72,13 +72,26 @@ public void timerTest(Control

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014842432 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java: ## @@ -0,0 +1,302 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014729785 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java: ## @@ -0,0 +1,291 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-26 Thread via GitHub
somandal commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2014826546 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -48,6 +48,21 @@ rules: table: "$2$4" tableType: "$5" taskType: "$6" +

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014821752 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1063,12 +1063,7 @@ AtomicBoolean getAcquiredConsumerS

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014065172 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Remove LArray usage [pinot]

2025-03-26 Thread via GitHub
codecov-commenter commented on PR #15342: URL: https://github.com/apache/pinot/pull/15342#issuecomment-2742690422 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15342?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Warn about numGroups above threshold [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on PR #15278: URL: https://github.com/apache/pinot/pull/15278#issuecomment-2755459464 I see. Let's not use factor then and use absolute value. Making it a factor of a default value can be very confusing, and people might not even know about this default value. -- T

Re: [PR] Bump org.apache.kafka:kafka-clients from 2.8.2 to 3.7.1 [pinot]

2025-03-26 Thread via GitHub
dependabot[bot] commented on PR #15337: URL: https://github.com/apache/pinot/pull/15337#issuecomment-2741706707 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[I] Unable to fetch stream partition offset with Kinesis [pinot]

2025-03-26 Thread via GitHub
J-HowHuang opened a new issue, #15378: URL: https://github.com/apache/pinot/issues/15378 # How to reproduce ```bash aws kinesis create-stream --stream-name transcript-stream --shard-count 2 aws kinesis list-shards --stream-name transcript-stream ``` output: ```json {

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014113282 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Extend POSSIBLE_QUERY_OPTIONS in PinotConnection to all query level o… [pinot]

2025-03-26 Thread via GitHub
chrajeshbabu commented on PR #15281: URL: https://github.com/apache/pinot/pull/15281#issuecomment-2755348287 @Jackie-Jiang Thank you very much for review. Handled the review comments and pushed the changes. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Extend POSSIBLE_QUERY_OPTIONS in PinotConnection to all query level o… [pinot]

2025-03-26 Thread via GitHub
chrajeshbabu commented on code in PR #15281: URL: https://github.com/apache/pinot/pull/15281#discussion_r2014753176 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -438,4 +438,11 @@ private static IllegalArgumentException longPar

Re: [PR] Extend POSSIBLE_QUERY_OPTIONS in PinotConnection to all query level o… [pinot]

2025-03-26 Thread via GitHub
chrajeshbabu commented on code in PR #15281: URL: https://github.com/apache/pinot/pull/15281#discussion_r2014752632 ## pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java: ## @@ -70,10 +66,10 @@ public class PinotConnection extends Abstract

Re: [PR] Add an interface for SecretStore [pinot]

2025-03-26 Thread via GitHub
nayanika-u commented on code in PR #15226: URL: https://github.com/apache/pinot/pull/15226#discussion_r2014730466 ## pinot-spi/src/main/java/org/apache/pinot/spi/secretstore/SecretStoreException.java: ## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
Jackie-Jiang commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014732834 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java: ## @@ -0,0 +1,291 @@ +/** + * Licensed to the Apache Software Fou

Re: [I] HDFS as Deep Storage Not Working in Pinot 1.3.0 [pinot]

2025-03-26 Thread via GitHub
xiangfu0 commented on issue #15215: URL: https://github.com/apache/pinot/issues/15215#issuecomment-2737907836 can we have a 1.3.0 patch branch and we can publish from there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Set InstanceType for OOM Protection during startup [pinot]

2025-03-26 Thread via GitHub
vrajat commented on PR #15374: URL: https://github.com/apache/pinot/pull/15374#issuecomment-2755270162 The test failure looks to be unrelated to the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] This commit includes: [pinot]

2025-03-26 Thread via GitHub
mghildiy opened a new pull request, #15377: URL: https://github.com/apache/pinot/pull/15377 1. For null value for FLOAT column, use NaN as transformation value * bugfix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014641803 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1063,12 +1063,7 @@ AtomicBoolean getAcquiredConsumerS

Re: [PR] Add per query stats to QuerySummary in pinot-tools QueryRunner [pinot]

2025-03-26 Thread via GitHub
klsince commented on code in PR #15376: URL: https://github.com/apache/pinot/pull/15376#discussion_r2014618297 ## pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java: ## @@ -292,6 +294,7 @@ public static QuerySummary singleThreadedQueryRunner(PerfBenchmarkDri

Re: [PR] Consuming Rebalance Summary [pinot]

2025-03-26 Thread via GitHub
somandal commented on PR #15368: URL: https://github.com/apache/pinot/pull/15368#issuecomment-2754812352 > ## Known problems > So far the API `GET /tables/{tableName}/consumingSegmentsInfo` seems to fail when the stream type is Kinesis. It might be due to the mis-alignment of pinot parti

Re: [PR] Consuming Rebalance Summary [pinot]

2025-03-26 Thread via GitHub
somandal commented on PR #15368: URL: https://github.com/apache/pinot/pull/15368#issuecomment-2754805807 I was thinking about this some more, and was wondering if it would be possible to come up with something like the following: ``` "consumingSegmentSummary": { "numConsumin

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
KKcorps commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014540410 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager(Se

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
KKcorps commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014540410 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager(Se

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
KKcorps commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014537124 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1063,12 +1063,7 @@ AtomicBoolean getAcquiredConsumerSema

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014111927 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager

Re: [I] roundDecimal() fails for null FLOAT values [pinot]

2025-03-26 Thread via GitHub
mghildiy commented on issue #15255: URL: https://github.com/apache/pinot/issues/15255#issuecomment-2754653749 PR is [here](https://github.com/apache/pinot/pull/15377). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014085253 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014113282 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Add per query stats to QuerySummary in pinot-tools QueryRunner [pinot]

2025-03-26 Thread via GitHub
codecov-commenter commented on PR #15376: URL: https://github.com/apache/pinot/pull/15376#issuecomment-2754484025 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15376?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014111927 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014111927 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014065172 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014113282 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

[PR] Add per query stats to QuerySummary in pinot-tools QueryRunner [pinot]

2025-03-26 Thread via GitHub
yashmayya opened a new pull request, #15376: URL: https://github.com/apache/pinot/pull/15376 - Adds per query stats to `QuerySummary` in `pinot-tools` `QueryRunner` so that clients can make assertions on query execution times for each individual query rather than just the average across all

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014088756 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-03-26 Thread via GitHub
gortiz commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2014099147 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeSystem.java: ## @@ -62,16 +62,36 @@ public boolean shouldConvertRaggedUnionTypesToVarying() { r

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014088756 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014088756 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014085253 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,18 +1729,27 @@ public RealtimeSegmentDataManager

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014065172 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Allows consumption during build for dedup/partial-upsert [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2014065172 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -172,6 +172,14 @@ public boolean isFinal() { }

Re: [PR] Consumes segments in strict order of sequence number [pinot]

2025-03-26 Thread via GitHub
noob-se7en commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2014042141 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java: ## @@ -43,6 +43,12 @@ public class StreamIngestionConfig extends B

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.7 [pinot]

2025-03-26 Thread via GitHub
dependabot[bot] commented on PR #15366: URL: https://github.com/apache/pinot/pull/15366#issuecomment-2754042817 Superseded by #15375. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.7 [pinot]

2025-03-26 Thread via GitHub
dependabot[bot] closed pull request #15366: Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.7 URL: https://github.com/apache/pinot/pull/15366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.8 [pinot]

2025-03-26 Thread via GitHub
dependabot[bot] opened a new pull request, #15375: URL: https://github.com/apache/pinot/pull/15375 Bumps software.amazon.awssdk:bom from 2.31.6 to 2.31.8. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.7 deleted (was 48ff26e62d)

2025-03-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.7 in repository https://gitbox.apache.org/repos/asf/pinot.git was 48ff26e62d Bump software.amazon.awssdk:bom from 2.31.6 to 2.31.7 The

Re: [PR] feat: change display of rebalance response [pinot]

2025-03-26 Thread via GitHub
yashmayya merged PR #15331: URL: https://github.com/apache/pinot/pull/15331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Set InstanceType for OOM Protection during startup [pinot]

2025-03-26 Thread via GitHub
codecov-commenter commented on PR #15374: URL: https://github.com/apache/pinot/pull/15374#issuecomment-2753450805 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15374?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Change display of rebalance response (#15331)

2025-03-26 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c5514f698e Change display of rebalance respons