noob-se7en commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2014113282


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -172,6 +172,14 @@ public boolean isFinal() {
     }
   }
 
+  @VisibleForTesting
+  enum ParallelSegmentConsumptionPolicy {

Review Comment:
   Actually there are these configs already: 
   _tableConfig.getUpsertConfig().isAllowPartialUpsertConsumptionDuringCommit()
   && _tableConfig.getDedupConfig().isAllowDedupConsumptionDuringCommit()
   
   I think we should just add _allowConsumptionDuringDownload



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to