9aman commented on PR #15345: URL: https://github.com/apache/pinot/pull/15345#issuecomment-2756672665
@rhodo I understand this PR has already been merged but would like to understand following 1. What is the rationale of adding this metric. Where would we need this ? 2. The constant name PROPERTYSTORE_SEGMENT_CHILDREN_BYTE_SIZE gives a perception that it's the size of the child node and not just the segment name sizes. Can we update the name to maybe `PROPERTYSTORE_SEGMENT_CHILDREN_NAME_BYTE_SIZE` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
