Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-20 Thread via GitHub
suddendust commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2006887838 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -48,6 +48,21 @@ rules: table: "$2$4" tableType: "$5" taskType: "$6"

Re: [PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on PR #15333: URL: https://github.com/apache/pinot/pull/15333#issuecomment-2742031432 @mcvsubbu @siddharthteotia @chenboat @jadami10 Let me know if you have concern on this. We have been enforcing schema for several releases, so I'd assume this is a safe move. Schema

(pinot) branch master updated: Bump com.google.errorprone:error_prone_annotations from 2.36.0 to 2.37.0 (#15326)

2025-03-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 503beb1907 Bump com.google.errorprone:error_prone

(pinot) branch master updated (c2487916e0 -> 5d55030046)

2025-03-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c2487916e0 Clean up HLC related code (#15318) add 5d55030046 Add `GridDistance` H3 Function (#15259) No new revis

Re: [PR] Upgrade Helix to 1.4.3 [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on PR #15063: URL: https://github.com/apache/pinot/pull/15063#issuecomment-2741938161 > Per this change: `EV won't have entry when IS has state as OFFLINE`, is there any side effect here? Any usage rely on EV OFFLINE status? This is Helix behavior change. I don'

Re: [PR] [spark connector] allow setting authorization to request header [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15315: URL: https://github.com/apache/pinot/pull/15315#issuecomment-2741936248 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15315?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Add segmentNames as an optional parameter in the get IS and EV APIs for a table (#15332)

2025-03-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 94009d548e Add segmentNames as an optional parame

Re: [PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
xiangfu0 closed pull request #15333: Enforce schema for all tables URL: https://github.com/apache/pinot/pull/15333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

(pinot) branch master updated (2f3612f45d -> cbedceca11)

2025-03-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2f3612f45d add getter for precheckcontext (#15339) add cbedceca11 Improved retention management for hybrid tables

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006623788 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -344,6 +346,9 @@ private static long getRandomInitialDelayInSeconds() {

Re: [PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
xiangfu0 closed pull request #15333: Enforce schema for all tables URL: https://github.com/apache/pinot/pull/15333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [spark connector] replace the use of circe with jackson [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15321: URL: https://github.com/apache/pinot/pull/15321#issuecomment-2741815340 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15321?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang closed pull request #15333: Enforce schema for all tables URL: https://github.com/apache/pinot/pull/15333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Update RebalanceResult field order [pinot]

2025-03-20 Thread via GitHub
klsince merged PR #15305: URL: https://github.com/apache/pinot/pull/15305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-20 Thread via GitHub
somandal commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2006524801 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -48,6 +48,21 @@ rules: table: "$2$4" tableType: "$5" taskType: "$6" +

Re: [PR] Fix tooltip wording for a couple of rebalance options in the UI [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15336: URL: https://github.com/apache/pinot/pull/15336#issuecomment-2741754496 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15336?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix Direct Memory OOM on Server [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15335: URL: https://github.com/apache/pinot/pull/15335#issuecomment-2741689710 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15335?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang merged PR #15332: URL: https://github.com/apache/pinot/pull/15332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Fix tooltip wording for a couple of rebalance options in the UI [pinot]

2025-03-20 Thread via GitHub
somandal opened a new pull request, #15336: URL: https://github.com/apache/pinot/pull/15336 This PR rewords a couple of the tooltips for the Rebalance Servers UI cc @himanish-star @jayeshchoudhary @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Allows consumption during build for Dedup [pinot]

2025-03-20 Thread via GitHub
klsince commented on code in PR #15296: URL: https://github.com/apache/pinot/pull/15296#discussion_r2006332515 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1723,6 +1725,15 @@ public RealtimeSegmentDataManager(Seg

Re: [PR] Adds log to debug slow ingestion while upsert snapshot [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15334: URL: https://github.com/apache/pinot/pull/15334#issuecomment-2741615322 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15334?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Query thread context and cid [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on PR #15180: URL: https://github.com/apache/pinot/pull/15180#issuecomment-2741602451 Related to #15137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15333: URL: https://github.com/apache/pinot/pull/15333#issuecomment-2741592780 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15333?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Adds log to debug slow ingestion while upsert snapshot [pinot]

2025-03-20 Thread via GitHub
noob-se7en opened a new pull request, #15334: URL: https://github.com/apache/pinot/pull/15334 There are no logs when ingestion is slow due to upserts lock contentions making debuging harder. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006323934 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006317564 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006317564 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (

[PR] Enforce schema for all tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang opened a new pull request, #15333: URL: https://github.com/apache/pinot/pull/15333 #11574 was released in `1.1.0` and can fix the invalid schema names. This PR enforces the table config and schema for all tables - During controller start, perform the following checks

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006159617 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
deepthi912 commented on code in PR #15332: URL: https://github.com/apache/pinot/pull/15332#discussion_r2006309571 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java: ## @@ -170,6 +187,27 @@ public List getSegmentStatuses(TableViews.Table

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2005261336 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerOperator.java: ## @@ -42,15 +42,13 @@ public class PipelineBreakerOperat

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15332: URL: https://github.com/apache/pinot/pull/15332#discussion_r2006262224 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java: ## @@ -170,6 +187,27 @@ public List getSegmentStatuses(TableViews.Tab

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang merged PR #15259: URL: https://github.com/apache/pinot/pull/15259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on PR #15259: URL: https://github.com/apache/pinot/pull/15259#issuecomment-2741384386 @ashishjayamohan Can you help add documentation for this new function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006085968 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15332: URL: https://github.com/apache/pinot/pull/15332#issuecomment-2741316396 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15332?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Clean up HLC related code [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang merged PR #15318: URL: https://github.com/apache/pinot/pull/15318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (41e33b8781 -> 1c6553c5d8)

2025-03-20 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 41e33b8781 [HELM]: Publish Helm 0.3.2 (#15323) add 1c6553c5d8 update rebalance result order (#15305) No new revisio

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006137618 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
deepthi912 commented on code in PR #15332: URL: https://github.com/apache/pinot/pull/15332#discussion_r2006135713 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java: ## @@ -170,6 +186,21 @@ public List getSegmentStatuses(TableViews.Table

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006135845 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/BrokerServiceHelper.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Add segmentNames as an optional parameter in the get IS and EV APIs for a table [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15332: URL: https://github.com/apache/pinot/pull/15332#discussion_r2006118744 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java: ## @@ -96,10 +98,17 @@ public static class TableView { public Table

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
rajagopr commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006117235 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java: ## @@ -199,6 +225,70 @@ private void manageRetentionForRealti

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-20 Thread via GitHub
ashishjayamohan commented on PR #15259: URL: https://github.com/apache/pinot/pull/15259#issuecomment-2741163913 Sounds good, thanks Jackie! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Add segmentNames as an optional parameter in the get IS and EV for a table [pinot]

2025-03-20 Thread via GitHub
deepthi912 opened a new pull request, #15332: URL: https://github.com/apache/pinot/pull/15332 **Context:** For a table having lot of segments in it's IS and EV, it is very hard to load the data and the Swagger API response breaks. So introducing this param so that users can fetch the detail

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-20 Thread via GitHub
somandal commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2006091400 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -48,6 +48,21 @@ rules: table: "$2$4" tableType: "$5" taskType: "$6" +

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-20 Thread via GitHub
ashishjayamohan commented on code in PR #15259: URL: https://github.com/apache/pinot/pull/15259#discussion_r2006076057 ## pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/GridDistanceFunction.java: ## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache S

[PR] feat: change display of rebalance response [pinot]

2025-03-20 Thread via GitHub
himanish-star opened a new pull request, #15331: URL: https://github.com/apache/pinot/pull/15331 ### Description This PR aims at displaying the rebalance server response in a more legible manner -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15257: URL: https://github.com/apache/pinot/pull/15257#discussion_r2006015698 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java: ## @@ -136,10 +150,22 @@ private void manageRetentionForT

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15259: URL: https://github.com/apache/pinot/pull/15259#discussion_r2005987884 ## pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/GridDistanceFunction.java: ## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Soft

Re: [PR] Bump com.mycila:license-maven-plugin from 4.6 to 5.0.0 [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on PR #15329: URL: https://github.com/apache/pinot/pull/15329#issuecomment-2740990398 I guess we can drop java 8 support since we are already using methods added in java 9 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005649218 ## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/QueryAssert.java: ## @@ -0,0 +1,159 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15330: URL: https://github.com/apache/pinot/pull/15330#issuecomment-2740921145 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15330?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix real-time table segment download [pinot]

2025-03-20 Thread via GitHub
Jackie-Jiang commented on code in PR #15316: URL: https://github.com/apache/pinot/pull/15316#discussion_r2005914016 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -564,77 +562,59 @@ private void doAddConsumingSegment(

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005649218 ## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/QueryAssert.java: ## @@ -0,0 +1,159 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005684234 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -423,25 +504,32 @@ private static void throwTableAccessE

[PR] Bump software.amazon.awssdk:bom from 2.31.3 to 2.31.4 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15324: URL: https://github.com/apache/pinot/pull/15324 Bumps software.amazon.awssdk:bom from 2.31.3 to 2.31.4. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | |

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005668438 ## pinot-common/src/main/java/org/apache/pinot/common/utils/Timer.java: ## @@ -18,32 +18,34 @@ */ package org.apache.pinot.common.utils; +import java.util.concurren

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005729667 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -278,53 +204,69 @@ private QueryEnvironment.QueryPlannerResult getQueryPlannerR

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005726502 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -531,4 +619,20 @@ public FailureDetector.ServerState ret

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005684234 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -423,25 +504,32 @@ private static void throwTableAccessE

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005704100 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -105,47 +104,41 @@ public class PinotQueryResource { @POST

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005687837 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ErrorCodesIntegrationTest.java: ## @@ -0,0 +1,215 @@ +/** + * Licensed to the Apache Software

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005674087 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -558,4 +546,134 @@ default boolean defaultEnableGroupTrim() { @Nullable

Re: [PR] Cleanup controller and MSE broker entry points to keep error codes an… [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15277: URL: https://github.com/apache/pinot/pull/15277#discussion_r2005652098 ## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/QueryAssert.java: ## @@ -0,0 +1,159 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Bump com.mycila:license-maven-plugin from 4.6 to 5.0.0 [pinot]

2025-03-20 Thread via GitHub
gortiz commented on PR #15329: URL: https://github.com/apache/pinot/pull/15329#issuecomment-2740409080 According to the plugin doc, 4.6 is the last version that supports Java 8. Version 5.0.0 requires Java 11 and version 6.0.0 will require Java 17 -- This is an automated message from the

(pinot) branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.37.0 deleted (was cc9711918a)

2025-03-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.37.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was cc9711918a Bump com.google.errorprone:error_prone_annot

(pinot) branch master updated (cadbc0c157 -> 7ac270b786)

2025-03-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from cadbc0c157 Bump org.apache.commons:commons-csv from 1.13.0 to 1.14.0 (#15328) add 7ac270b786 Bump org.apache.http

Re: [PR] Bump org.apache.httpcomponents.core5:httpcore5 from 5.3.3 to 5.3.4 [pinot]

2025-03-20 Thread via GitHub
gortiz merged PR #15327: URL: https://github.com/apache/pinot/pull/15327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

(pinot) branch dependabot/maven/org.apache.commons-commons-csv-1.14.0 deleted (was 503626a04d)

2025-03-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch dependabot/maven/org.apache.commons-commons-csv-1.14.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 503626a04d Bump org.apache.commons:commons-csv from 1.13.0 to 1.14.0

(pinot) branch master updated (503beb1907 -> cadbc0c157)

2025-03-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 503beb1907 Bump com.google.errorprone:error_prone_annotations from 2.36.0 to 2.37.0 (#15326) add cadbc0c157 Bump

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.31.3 to 2.31.4 (#15324)

2025-03-20 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4ce0ca02cd Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.3 to 2.31.4 [pinot]

2025-03-20 Thread via GitHub
tibrewalpratik17 merged PR #15324: URL: https://github.com/apache/pinot/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.4 deleted (was 9f7f804a36)

2025-03-20 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.4 in repository https://gitbox.apache.org/repos/asf/pinot.git was 9f7f804a36 Bump software.amazon.awssdk:bom from 2.31.3 to 2.31.4 The revi

[PR] Bump com.mycila:license-maven-plugin from 4.6 to 5.0.0 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15329: URL: https://github.com/apache/pinot/pull/15329 Bumps [com.mycila:license-maven-plugin](https://github.com/mathieucarbou/license-maven-plugin) from 4.6 to 5.0.0. Release notes Sourced from https://github.com/mathieucarbou/license-

[PR] Bump org.apache.httpcomponents.core5:httpcore5 from 5.3.3 to 5.3.4 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15327: URL: https://github.com/apache/pinot/pull/15327 Bumps [org.apache.httpcomponents.core5:httpcore5](https://github.com/apache/httpcomponents-core) from 5.3.3 to 5.3.4. Changelog Sourced from https://github.com/apache/httpcomponents-

(pinot) branch dependabot/maven/com.mycila-license-maven-plugin-5.0.0 created (now c61d9e4467)

2025-03-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.mycila-license-maven-plugin-5.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at c61d9e4467 Bump com.mycila:license-maven-plugin from 4.6 to 5.0.0

(pinot) branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.4 created (now 95a829d0e2)

2025-03-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.core5-httpcore5-5.3.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at 95a829d0e2 Bump org.apache.httpcomponents.core5:httpcore

[PR] Bump org.apache.commons:commons-csv from 1.13.0 to 1.14.0 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15328: URL: https://github.com/apache/pinot/pull/15328 Bumps [org.apache.commons:commons-csv](https://github.com/apache/commons-csv) from 1.13.0 to 1.14.0. Changelog Sourced from https://github.com/apache/commons-csv/blob/master/RELEASE-

(pinot) branch dependabot/maven/org.apache.commons-commons-csv-1.14.0 created (now 503626a04d)

2025-03-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-csv-1.14.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 503626a04d Bump org.apache.commons:commons-csv from 1.13.0 to 1.14

(pinot) branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.37.0 created (now cc9711918a)

2025-03-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.37.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at cc9711918a Bump com.google.errorprone:error_prone_a

[PR] Bump com.google.errorprone:error_prone_annotations from 2.36.0 to 2.37.0 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15326: URL: https://github.com/apache/pinot/pull/15326 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.36.0 to 2.37.0. Release notes Sourced from https://github.com/google/error-prone/r

[PR] Bump kotlin.stdlib.version from 2.0.21 to 2.1.20 [pinot]

2025-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #15325: URL: https://github.com/apache/pinot/pull/15325 Bumps `kotlin.stdlib.version` from 2.0.21 to 2.1.20. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 2.0.21 to 2.1.20 Release notes Sourced from https://github.com/JetBrains/

(pinot) branch master updated (bcb9985c28 -> 75340e30da)

2025-03-20 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bcb9985c28 Add Disk Utilization Info into Rebalance API (#15175) add 75340e30da Bump software.amazon.awssdk:bom fr

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.3 deleted (was 83b503e4ae)

2025-03-20 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 83b503e4ae Bump software.amazon.awssdk:bom from 2.31.2 to 2.31.3 The revi

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-03-20 Thread via GitHub
albertobastos commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2005308767 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/MultiStageQueryStats.java: ## @@ -95,32 +90,25 @@ private MultiStageQueryStats(int stageI

Re: [PR] [HELM]: Publish Helm 0.3.2 [pinot]

2025-03-20 Thread via GitHub
codecov-commenter commented on PR #15323: URL: https://github.com/apache/pinot/pull/15323#issuecomment-2739900344 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15323?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2005253188 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/MultiStageQueryStats.java: ## @@ -95,32 +90,25 @@ private MultiStageQueryStats(int stageId) {

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2005240477 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/MseBlock.java: ## @@ -0,0 +1,178 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[PR] [HELM]: Publish Helm 0.3.2 [pinot]

2025-03-20 Thread via GitHub
PovilasV1 opened a new pull request, #15323: URL: https://github.com/apache/pinot/pull/15323 Reference issue - https://github.com/apache/pinot/issues/15322 - pushes the helm chart to 0.3.2 version - prepares the chart for release 0.3.3 - fixes digest for version 0.3.1 -- This

[I] Pinot Helm Chart 0.3.2 Release [pinot]

2025-03-20 Thread via GitHub
PovilasV1 opened a new issue, #15322: URL: https://github.com/apache/pinot/issues/15322 New changes have been made to the Pinot helm chart. initContainers support added - https://github.com/apache/pinot/pull/15275 This issue is to release 0.3.2 version of the Pinot Helm chart.

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005022953 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005026509 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005029396 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005024421 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005022698 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

[PR] [spark connector] replace the use of circe with jackson [pinot]

2025-03-20 Thread via GitHub
tsekityam opened a new pull request, #15321: URL: https://github.com/apache/pinot/pull/15321 This PR fixs #15320, by using jackson to decode api response instead of circe ## Test I can run the following code to get the schema of the table ```py df = ( spark .read

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005012571 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -244,11 +244,14 @@ private E readBlockOrNull()

Re: [PR] Make stats system more resilient in MSE [pinot]

2025-03-20 Thread via GitHub
gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005011839 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Allows segments deletion in build for pauseless tables [pinot]

2025-03-20 Thread via GitHub
noob-se7en commented on code in PR #15299: URL: https://github.com/apache/pinot/pull/15299#discussion_r2002849124 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -1175,6 +1179,136 @@ public SuccessResponse updat

  1   2   >