gortiz commented on code in PR #15312: URL: https://github.com/apache/pinot/pull/15312#discussion_r2005029396
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SendStatsPredicate.java: ########## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.server.starter.helix; + +import java.util.List; +import java.util.Locale; +import java.util.concurrent.atomic.AtomicBoolean; +import javax.annotation.Nullable; +import org.apache.helix.NotificationContext; +import org.apache.helix.api.listeners.InstanceConfigChangeListener; +import org.apache.helix.model.InstanceConfig; +import org.apache.pinot.common.version.PinotVersion; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.utils.CommonConstants; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public abstract class SendStatsPredicate implements InstanceConfigChangeListener { + private static final Logger LOGGER = LoggerFactory.getLogger(SendStatsPredicate.class); + + public abstract boolean getSendStats(); + + public static SendStatsPredicate create(PinotConfiguration configuration) { + String modeStr = configuration.getProperty( + CommonConstants.MultiStageQueryRunner.KEY_OF_SEND_STATS_MODE, + CommonConstants.MultiStageQueryRunner.DEFAULT_SEND_STATS_MODE).toUpperCase(Locale.ENGLISH); + for (Mode mode : Mode.values()) { + if (mode.name().equals(modeStr)) { + return mode.create(); + } + } + + throw new IllegalStateException("Invalid value " + modeStr + " for " + + CommonConstants.MultiStageQueryRunner.KEY_OF_SEND_STATS_MODE); + } + + public enum Mode { + SAFE { + @Override + public SendStatsPredicate create() { + return new Safe(); + } + }, + ALWAYS { + @Override + public SendStatsPredicate create() { + return new SendStatsPredicate() { + @Override + public boolean getSendStats() { + return false; + } + + @Override + public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, NotificationContext context) { + // Nothing to do + } + }; + } + }, + NEVER { + @Override + public SendStatsPredicate create() { + return new SendStatsPredicate() { + @Override + public boolean getSendStats() { + return false; + } + + @Override + public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, NotificationContext context) { + // Nothing to do + } + }; + } + }; + + public abstract SendStatsPredicate create(); + } + + private static class Safe extends SendStatsPredicate { + private final AtomicBoolean _sendStats = new AtomicBoolean(true); + + @Override + public boolean getSendStats() { + return _sendStats.get(); + } + + @Override + public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, NotificationContext context) { + boolean sendStats = true; + // TODO: Right now we read all configs, while only broker and servers are actually important + // But it isn't clear how to detect for sure that an instance config belongs to a broker or server + for (InstanceConfig instanceConfig : instanceConfigs) { + String otherVersion = instanceConfig.getRecord() + .getStringField(CommonConstants.Helix.Instance.PINOT_VERSION_KEY, null); + if (otherVersion == null || otherVersion.equals(PinotVersion.UNKNOWN)) { + LOGGER.warn("Instance {} does not have version", instanceConfig.getInstanceName()); + continue; + } + if (isProblematicVersion(otherVersion)) { + LOGGER.info("Found problematic version {} on instance {}. Stats may not be recognized", otherVersion, + instanceConfig.getInstanceName()); + sendStats = false; + break; + } + } + if (_sendStats.getAndSet(sendStats) != sendStats) { + LOGGER.warn("Send MSE stats is now {}", sendStats ? "enabled" : "disabled"); + } + } + + /// Returns true if the version is problematic Review Comment: I'm starting to use the new Javadoc markdown format because I think it is easier to read without IDE help (ie in GH reviews) while IDEs already recognize it (at least IntelliJ) even when Java 11 is being used. For example, adding links and especially lists is quite easier to write and read this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
