gortiz commented on code in PR #15277:
URL: https://github.com/apache/pinot/pull/15277#discussion_r2005684234
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -423,25 +504,32 @@ private static void
throwTableAccessError(TableAuthorizationResult tableAuthoriz
}
/**
- * Runs the query planning in a separate thread so that we can enforce a
timeout on it (in some rare cases,
- * we can see query compilation taking a very long time).
+ * Calls the given callable in a separate thread and enforces a timeout on
it.
+ *
+ * The only exception that can be thrown by this method is a QueryException.
All other exceptions are caught and
+ * wrapped in a QueryException. Specifically, {@link TimeoutException} is
caught and wrapped in a QueryException with
+ * the error code {@link QueryErrorCode#BROKER_TIMEOUT} and other exceptions
are treated as internal errors.K
Review Comment:
Strange. Mine is doing the same, but the exact text placed in another
section is fine. It is probably a bug in how IntelliJ renders the new javadoc
format. The [JEP-467](https://openjdk.org/jeps/467) defines a new way to define
throws, parameters, etc sections, but it doesn't seem to be included in Java 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
