Re: [I] [Proposal] Generic Time Series Engine in Pinot [pinot]

ankitsultana commented on issue #13760: URL: https://github.com/apache/pinot/issues/13760#issuecomment-2725147841 It was released in Experimental state in Pinot 1.3 recently. With Pinot 1.4 we are hoping to make it GA. Runbooks are still missing. I'll try to add them soon. -- This is an

Re: [PR] ~Fixes Helix threads getting blocked for Realtime Tables~ [pinot]

noob-se7en closed pull request #14771: ~Fixes Helix threads getting blocked for Realtime Tables~ URL: https://github.com/apache/pinot/pull/14771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] Enhance index and field config validation to block adding bloomfilter on boolean column [pinot]

ayesheepatra07 opened a new pull request, #15283: URL: https://github.com/apache/pinot/pull/15283 This commit updates the validation logic in TableConfigUtils to prevent Bloom filter from being applied to boolean columns. Previously, it was possible to add a Bloom filter on a column of type

Re: [PR] Consume in order 2 [pinot]

noob-se7en commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r1993340221 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SemaphoreCoordinator.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Donot allow consumption for Dedup Tables enabled during segment download and replacement [pinot]

klsince commented on code in PR #15268: URL: https://github.com/apache/pinot/pull/15268#discussion_r1996345949 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/TableDedupMetadataManagerFactory.java: ## @@ -39,6 +39,9 @@ private TableDedupMetadataManagerF

Re: [PR] Enhance rebalance pre-checks to provide more information in status returned [pinot]

J-HowHuang commented on PR #15233: URL: https://github.com/apache/pinot/pull/15233#issuecomment-2711487137 Should we have a class like `PrecheckResult` with two members `_message` and `_status` which is an enum for different check result? (e.g. pass✅, warning⚠️, alert🚨), would it be clearer

[PR] Ensure group by result holder capacity even for empty groups in MultistageGroupByExecutor [pinot]

yashmayya opened a new pull request, #15211: URL: https://github.com/apache/pinot/pull/15211 - Fixes https://github.com/apache/pinot/issues/15121. - The group by result holders need to have entries for all group keys generated, even for empty groups (i.e., group keys that don't have any m

(pinot) branch master updated (bc567a02b8 -> aeb9478d95)

This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bc567a02b8 Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consi

(pinot) branch master updated: Fixed the typo in segment file existence check in deepstore (#15248)

This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 49a5aad4af Fixed the typo in segment f

Re: [PR] Query thread context and cid [pinot]

vrajat commented on code in PR #15180: URL: https://github.com/apache/pinot/pull/15180#discussion_r1987400267 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -407,11 +408,12 @@ public String cancelQuery( } retu

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

J-HowHuang commented on code in PR #15175: URL: https://github.com/apache/pinot/pull/15175#discussion_r1994379854 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -138,4 +157,80 @@ private boolean checkIsMi

Re: [PR] Skip logs for virtual columns as they are known not to be in the schema [pinot]

codecov-commenter commented on PR #15206: URL: https://github.com/apache/pinot/pull/15206#issuecomment-2702965760 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15206?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[I] Tracing::ThreadUsageResourceAccountant cannot be isolated and tested in integration tests [pinot]

vrajat opened a new issue, #15231: URL: https://github.com/apache/pinot/issues/15231 In integration tests, brokers and servers run in the same JVM. All of them share the same `ThreadUsageResourceAccountant` in a singleton in `Tracing.java`. This makes certain kinds of tests hard to write. F

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2725345721 The test failure ` MultiNodesOfflineClusterIntegrationTest>O` seems like a flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] Simplify the handling of filtered agg in MSQE [pinot]

Jackie-Jiang opened a new pull request, #15214: URL: https://github.com/apache/pinot/pull/15214 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Bump software.amazon.awssdk:bom from 2.30.35 to 2.30.36 [pinot]

dependabot[bot] opened a new pull request, #15230: URL: https://github.com/apache/pinot/pull/15230 Bumps software.amazon.awssdk:bom from 2.30.35 to 2.30.36. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984396711 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -655,6 +658,7 @@ public RebalanceResult rebalance(

Re: [PR] Enhance rebalance pre-checks to provide more information in status returned [pinot]

somandal commented on PR #15233: URL: https://github.com/apache/pinot/pull/15233#issuecomment-2711507061 > Should we have a class like `PrecheckResult` with two members `_message` and `_status` which is an enum for different check result? (e.g. pass✅, warning⚠️, alert🚨), would it be clearer

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

gortiz commented on PR #15037: URL: https://github.com/apache/pinot/pull/15037#issuecomment-2710087295 I've pushed a change where I'm creating a new `QueryFunctionInvoker`. The old `FunctionInvoker` is now only called by ingestion code and the new `QueryFunctionInvoker`. The latter delegate

[PR] Initialize OOM protection in GrpcQueryServer [pinot]

jitendrakr88 opened a new pull request, #15271: URL: https://github.com/apache/pinot/pull/15271 ## Description When OOM is enabled, the grpc streming queries always return 0 rows. This issue has been observered with spark connector as well as trino connector (reported by another us

Re: [PR] Donot allow consumption for Dedup Tables enabled during segment download and replacement [pinot]

klsince merged PR #15268: URL: https://github.com/apache/pinot/pull/15268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

(pinot) branch master updated: Donot allow consumption for Dedup Tables enabled during segment download and replacement (#15268)

This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7eae993760 Donot allow consumption for Dedup Tables

[PR] Initialize OOM protection in GrpcQueryServer [pinot]

jitendrakr88 opened a new pull request, #15270: URL: https://github.com/apache/pinot/pull/15270 ## Description When OOM is enabled, the grpc streming queries always return 0 rows. This issue has been observered with spark connector as well as trino connector (reported by another us

Re: [PR] Improve bad queries (with excessive number of groups) observability [pinot]

albertobastos closed pull request #15254: Improve bad queries (with excessive number of groups) observability URL: https://github.com/apache/pinot/pull/15254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] [HELM]: add initContainers support [pinot]

PovilasV1 opened a new pull request, #15275: URL: https://github.com/apache/pinot/pull/15275 Reference issue - https://github.com/apache/pinot/issues/15274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above