ayesheepatra07 opened a new pull request, #15283: URL: https://github.com/apache/pinot/pull/15283
This commit updates the validation logic in TableConfigUtils to prevent Bloom filter from being applied to boolean columns. Previously, it was possible to add a Bloom filter on a column of type Boolean, which used to throw an “Unsupported Data Type “ error later. Changes include: - Updating the validation logic in the indexing configuration and field configuration to check that any column with a boolean data type cannot be configured with a Bloom filter - Throwing an IllegalStateException with an error message (eg. "Cannot create a bloom filter on boolean column <columnName>") when the validation fails. Testing: - Added a new test case, testValidateBloomFilterOnBooleanFieldConfig(), in TableConfigUtilsTest.java. This test creates a schema with a Boolean column and a String column, applies a Bloom filter to the Boolean column via field index configuration and table index configuration, and asserts that validation fails with the expected error message. - Ran the full test suite locally using Realtime quickstart to ensure that all existing tests pass and that our changes do not affect other index config validations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
