[I] Connection to ZooKeeper hangs forever using Java client [pinot]

2025-02-16 Thread via GitHub
arman-yekkehkhani opened a new issue, #15074: URL: https://github.com/apache/pinot/issues/15074 I am trying to obtain a connection from zookeeper instances using Java client version 1.2.0. Unfortunately, the connection to zookeeper itself can not be established and remains in waiting status

Re: [PR] Implement MdcExecutor to manage MDC context for query execution [pinot]

2025-02-16 Thread via GitHub
vrajat commented on code in PR #15072: URL: https://github.com/apache/pinot/pull/15072#discussion_r1957745503 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/MdcExecutor.java: ## @@ -0,0 +1,159 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Minion task progress tracking improvements [pinot]

2025-02-16 Thread via GitHub
swaminathanmanish commented on code in PR #14521: URL: https://github.com/apache/pinot/pull/14521#discussion_r1957587424 ## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressStats.java: ## @@ -0,0 +1,146 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Extract compileRequest from BaseSingleStageRequestHandler.doHandleRequest [pinot]

2025-02-16 Thread via GitHub
codecov-commenter commented on PR #15073: URL: https://github.com/apache/pinot/pull/15073#issuecomment-2662183750 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15073?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Extract compileRequest from BaseSingleStageRequestHandler.doHandleRequest [pinot]

2025-02-16 Thread via GitHub
vrajat opened a new pull request, #15073: URL: https://github.com/apache/pinot/pull/15073 BaseSingleStageBrokerRequestHandler.doHandleRequest is a large function of ~600 LOC. This makes it hard to reason about the function as well as extend and reuse parts of the function. The function can

Re: [PR] Decouple tracking and storage in MinionEventObserver using MinionTaskProgressManager [pinot]

2025-02-16 Thread via GitHub
shounakmk219 commented on code in PR #15044: URL: https://github.com/apache/pinot/pull/15044#discussion_r1957627822 ## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressStats.java: ## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Set CONSUMING state priority for helix state model [pinot]

2025-02-16 Thread via GitHub
xiangfu0 commented on PR #14991: URL: https://github.com/apache/pinot/pull/14991#issuecomment-2662110822 close this as the change is cluster wise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Set CONSUMING state priority for helix state model [pinot]

2025-02-16 Thread via GitHub
xiangfu0 closed pull request #14991: Set CONSUMING state priority for helix state model URL: https://github.com/apache/pinot/pull/14991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Minion task progress tracking improvements [pinot]

2025-02-16 Thread via GitHub
shounakmk219 closed pull request #14521: Minion task progress tracking improvements URL: https://github.com/apache/pinot/pull/14521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Decouple tracking and storage in MinionEventObserver using MinionTaskProgressManager [pinot]

2025-02-16 Thread via GitHub
swaminathanmanish commented on code in PR #15044: URL: https://github.com/apache/pinot/pull/15044#discussion_r1957613132 ## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressManager.java: ## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Decouple tracking and storage in MinionEventObserver using MinionTaskProgressManager [pinot]

2025-02-16 Thread via GitHub
swaminathanmanish commented on code in PR #15044: URL: https://github.com/apache/pinot/pull/15044#discussion_r1957612255 ## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressStats.java: ## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (A

Re: [PR] Added support to pause and resume ingestion based on resource utilization [pinot]

2025-02-16 Thread via GitHub
swaminathanmanish merged PR #15008: URL: https://github.com/apache/pinot/pull/15008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(pinot) branch master updated: Added support to pause and resume ingestion based on resource utilization (#15008)

2025-02-16 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7239d34117 Added support to pause and

svn commit: r74930 - /release/pinot/apache-pinot-1.2.0/

2025-02-16 Thread xiangfu
Author: xiangfu Date: Mon Feb 17 01:46:31 2025 New Revision: 74930 Log: remove apache-pinot-1.2.0 pinot version in release repo Removed: release/pinot/apache-pinot-1.2.0/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.

svn commit: r74929 - /dev/pinot/apache-pinot-1.3.0-rc1/ /release/pinot/apache-pinot-1.3.0/

2025-02-16 Thread xiangfu
Author: xiangfu Date: Mon Feb 17 01:45:24 2025 New Revision: 74929 Log: Move apache-pinot-1.3.0-rc1 to release apache-pinot-1.3.0 Added: release/pinot/apache-pinot-1.3.0/ - copied from r74928, dev/pinot/apache-pinot-1.3.0-rc1/ Removed: dev/pinot/apache-pinot-1.3.0-rc1/ --

Re: [PR] [Feature Request] Support simple file ingestion from public remote file [pinot]

2025-02-16 Thread via GitHub
DaniilRoman commented on PR #15015: URL: https://github.com/apache/pinot/pull/15015#issuecomment-2661629962 I see now, thank you for your feedback and clarification @cyrilou242 🙏 In `/ingestFromURI` we use different PinotFS which work with different object storages and we can't simply cr

Re: [I] Error with streaming Kafka Protobuf Messages into Pinot table [pinot]

2025-02-16 Thread via GitHub
csdavidc closed issue #15043: Error with streaming Kafka Protobuf Messages into Pinot table URL: https://github.com/apache/pinot/issues/15043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Error with streaming Kafka Protobuf Messages into Pinot table [pinot]

2025-02-16 Thread via GitHub
csdavidc commented on issue #15043: URL: https://github.com/apache/pinot/issues/15043#issuecomment-2661577846 The issue was a wrong protoClassName, fixing it to the right name fixed the issue -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [Flaky-test] Fix LLCRealtimeClusterIntegrationTest.testForceCommitInBatches() [pinot]

2025-02-16 Thread via GitHub
noob-se7en commented on code in PR #14970: URL: https://github.com/apache/pinot/pull/14970#discussion_r1957376944 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -256,15 +256,14 @@ public JsonNode getForceCommitJ

Re: [PR] [Flaky-test] Fix LLCRealtimeClusterIntegrationTest.testForceCommitInBatches() [pinot]

2025-02-16 Thread via GitHub
noob-se7en commented on code in PR #14970: URL: https://github.com/apache/pinot/pull/14970#discussion_r1957377020 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -256,15 +256,14 @@ public JsonNode getForceCommitJ

Re: [PR] Implement MdcExecutor to manage MDC context for query execution [pinot]

2025-02-16 Thread via GitHub
codecov-commenter commented on PR #15072: URL: https://github.com/apache/pinot/pull/15072#issuecomment-2661436148 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15072?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Implement MdcExecutor to manage MDC context for query execution [pinot]

2025-02-16 Thread via GitHub
gortiz opened a new pull request, #15072: URL: https://github.com/apache/pinot/pull/15072 This simplification of #14994 is focused on adding MDC support on the query side. [MDC](https://www.baeldung.com/mdc-in-log4j-2-logback) is a common feature in logging frameworks that is usually build

Re: [I] Error with streaming Kafka Protobuf Messages into Pinot table [pinot]

2025-02-16 Thread via GitHub
csdavidc commented on issue #15043: URL: https://github.com/apache/pinot/issues/15043#issuecomment-2661389319 @Jackie-Jiang The logs I attached are the logs from all of the services as they all run on the same container -`apachepinot/pinot:latest` -- This is an automated message from the

Re: [PR] Enhance early termination handling in LeafStageTransferableBlockOperator and OpChainSchedulerService [pinot]

2025-02-16 Thread via GitHub
codecov-commenter commented on PR #15071: URL: https://github.com/apache/pinot/pull/15071#issuecomment-2661388019 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15071?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Enhance early termination handling in LeafStageTransferableBlockOperator and OpChainSchedulerService [pinot]

2025-02-16 Thread via GitHub
gortiz opened a new pull request, #15071: URL: https://github.com/apache/pinot/pull/15071 We detected that `cancel` and `earlyTerminate` methods were not actually interrupting SSE threads. Specifically, in `LeafStageTransferableBlockOperatorTest`, newly added tests `cancelMethodInterruptsS