vrajat opened a new pull request, #15073: URL: https://github.com/apache/pinot/pull/15073
BaseSingleStageBrokerRequestHandler.doHandleRequest is a large function of ~600 LOC. This makes it hard to reason about the function as well as extend and reuse parts of the function. The function can be broken down into four parts: * Compile * Validate * Plan (generate server request) * Execute This PR only extracts the code to compile the request. The o/p of compile is stored in a `CompileResult` object that the rest of the code can use. A couple of open points are: * This PR does not try to be exactly correct about the boundaries of these parts. Eventually some code has to be moved around. * SQL Parser & Validation errors should ideally be thrown as exceptions and then converted to `BrokerResponse`. This can be taken up in a subsequent PR. Otherwise the code has not been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
