swaminathanmanish commented on code in PR #15044: URL: https://github.com/apache/pinot/pull/15044#discussion_r1957612255
########## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressStats.java: ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.tasks; + +import java.util.Deque; +import java.util.LinkedList; +import java.util.Objects; + + +public class MinionTaskProgressStats { Review Comment: Can we call this MinionTaskObserverStats ? ########## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/StatusEntry.java: ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.tasks; + +public class StatusEntry { Review Comment: Can we move this as well to MinionTaskObserverStats/MinionTaskProgressStats itself ? Its anyway part of MinionTaskObserverStats ########## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressManager.java: ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.tasks; + +import javax.annotation.Nullable; +import org.apache.pinot.spi.env.PinotConfiguration; + + +/** + * Interface to decouple minion task progress storage from task progress tracking + */ +public interface MinionTaskProgressManager { Review Comment: Can we name this MinionTaskObserverStorageAccessManager or something to reflect the purpose of the interface? (to manager storage of Observer stats) ########## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskProgressStats.java: ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.tasks; + +import java.util.Deque; +import java.util.LinkedList; +import java.util.Objects; + + +public class MinionTaskProgressStats { Review Comment: I assume we intend to have this class extended for other usecases based on task types? Will we have serializer and deserializer interfaces as well to do ser/deser of stats based on implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
