Re: [PR] Extend to add Default Server level configs for Dedup Tables [pinot]

2024-12-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14684: URL: https://github.com/apache/pinot/pull/14684#discussion_r1896510141 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DedupConfig.java: ## @@ -96,4 +96,10 @@ public String getDedupTimeColumn() { public boolean isEnabl

Re: [I] [feature-request] Support Lambda Expressions [pinot]

2024-12-23 Thread via GitHub
gortiz commented on issue #14650: URL: https://github.com/apache/pinot/issues/14650#issuecomment-2560789042 As @ankitsultana said, this is a complex task that would need a design document. How to evaluate these lambdas in the query engine is not a trivial task that would probably involve se

Re: [I] Allow return query response in columnar format [pinot]

2024-12-23 Thread via GitHub
gortiz commented on issue #14677: URL: https://github.com/apache/pinot/issues/14677#issuecomment-2560780161 Do you mean something like returning data in arrow format? That would be awesome. -- This is an automated message from the Apache Git Service. To respond to the message, please log

(pinot) branch master updated: Add support for Cursors through API Query Params (#14110)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 73843b57c7 Add support for Cursors through API

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
yashmayya merged PR #14110: URL: https://github.com/apache/pinot/pull/14110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [I] [feature-request] Support Lambda Expressions [pinot]

2024-12-23 Thread via GitHub
ankitsultana commented on issue #14650: URL: https://github.com/apache/pinot/issues/14650#issuecomment-2560409953 @cutiepie-10 : supporting lambda expressions is going to be quite a large effort. Do you have a design doc or a PoC we can take a look at? If you are new to Pinot I'd reco

Re: [PR] Re-implement distinct operators [pinot]

2024-12-23 Thread via GitHub
ankitsultana commented on code in PR #14701: URL: https://github.com/apache/pinot/pull/14701#discussion_r1896073385 ## pinot-core/src/main/java/org/apache/pinot/core/query/distinct/table/StringDistinctTable.java: ## @@ -0,0 +1,323 @@ +/** + * Licensed to the Apache Software Foun

Re: [PR] [WIP] Bail Early in And Filter Operator When Possible [pinot]

2024-12-23 Thread via GitHub
ankitsultana commented on code in PR #14700: URL: https://github.com/apache/pinot/pull/14700#discussion_r1896033474 ## pinot-core/src/test/java/org/apache/pinot/queries/H3IndexQueriesTest.java: ## @@ -401,7 +401,7 @@ public void queryStContainsWithMultipleFilters() Aggreg

Re: [PR] RTO Task Overhaul (BugFix and Support to run multiple subtasks) [pinot]

2024-12-23 Thread via GitHub
Harnoor7 commented on code in PR #14623: URL: https://github.com/apache/pinot/pull/14623#discussion_r1896027279 ## pinot-common/src/main/java/org/apache/pinot/common/minion/ExpectedRealtimeToOfflineTaskResultInfo.java: ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] RTO Task Overhaul (BugFix and Support to run multiple subtasks) [pinot]

2024-12-23 Thread via GitHub
Harnoor7 commented on code in PR #14623: URL: https://github.com/apache/pinot/pull/14623#discussion_r1896026963 ## pinot-common/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java: ## @@ -18,57 +18,180 @@ */ package org.apache.pinot.common.

Re: [PR] RTO Task Overhaul (BugFix and Support to run multiple subtasks) [pinot]

2024-12-23 Thread via GitHub
Harnoor7 commented on code in PR #14623: URL: https://github.com/apache/pinot/pull/14623#discussion_r1896026817 ## pinot-common/src/main/java/org/apache/pinot/common/minion/ExpectedRealtimeToOfflineTaskResultInfo.java: ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on PR #14507: URL: https://github.com/apache/pinot/pull/14507#issuecomment-2559774818 We have some tests that verify that, but in different files. For example: - pinot-query-planner/src/test/resources/queries/ExplainPhysicalPlans.json verifies the plan. - pinot-query-r

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
yashmayya commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895761098 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -484,6 +484,18 @@ default boolean defaultInferPartitionHint() { return

Re: [PR] Include exception when no server is found [pinot]

2024-12-23 Thread via GitHub
gortiz merged PR #14709: URL: https://github.com/apache/pinot/pull/14709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

(pinot) branch master updated: Include exception when no server is found (#14709)

2024-12-23 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9be162a8b4 Include exception when no server is fo

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895737941 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software

(pinot) branch dependabot/maven/jna.version-5.16.0 deleted (was fd8453f11d)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/jna.version-5.16.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was fd8453f11d Bump jna.version from 5.15.0 to 5.16.0 The revisions that were on this bran

(pinot) branch master updated: Bump jna.version from 5.15.0 to 5.16.0 (#14706)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a7470a9380 Bump jna.version from 5.15.0 to 5.1

Re: [PR] Bump jna.version from 5.15.0 to 5.16.0 [pinot]

2024-12-23 Thread via GitHub
yashmayya merged PR #14706: URL: https://github.com/apache/pinot/pull/14706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895725815 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895718634 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Include exception when no server is found [pinot]

2024-12-23 Thread via GitHub
codecov-commenter commented on PR #14709: URL: https://github.com/apache/pinot/pull/14709#issuecomment-2559656795 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14709?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895721154 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895712004 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895709178 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895703900 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895701574 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/cursors/MemoryResponseStore.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895698268 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,248 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[PR] Include exception when no server is found [pinot]

2024-12-23 Thread via GitHub
gortiz opened a new pull request, #14709: URL: https://github.com/apache/pinot/pull/14709 Recently we found an issue when the log `No server found for request` was printed. This log implies there is an exception that don't let us find servers to query, but the exception is not printed.

(pinot) branch master updated (e957e69624 -> 99a10ff209)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e957e69624 Bump com.microsoft.azure:msal4j from 1.17.3 to 1.18.0 (#14705) add 99a10ff209 Bump com.nimbusds:nim

(pinot) branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.48 deleted (was 1149e888a9)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.48 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1149e888a9 Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 9.48 The rev

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.18.0 deleted (was aee62f1cc0)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.18.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was aee62f1cc0 Bump com.microsoft.azure:msal4j from 1.17.3 to 1.18.0 The r

Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 9.48 [pinot]

2024-12-23 Thread via GitHub
yashmayya merged PR #14704: URL: https://github.com/apache/pinot/pull/14704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch master updated (4edb574bbd -> e957e69624)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4edb574bbd Bump software.amazon.awssdk:bom from 2.29.38 to 2.29.39 (#14708) add e957e69624 Bump com.microsoft.

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.38 to 2.29.39 [pinot]

2024-12-23 Thread via GitHub
yashmayya merged PR #14708: URL: https://github.com/apache/pinot/pull/14708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Bump com.microsoft.azure:msal4j from 1.17.3 to 1.18.0 [pinot]

2024-12-23 Thread via GitHub
yashmayya merged PR #14705: URL: https://github.com/apache/pinot/pull/14705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.39 deleted (was 7452047231)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.39 in repository https://gitbox.apache.org/repos/asf/pinot.git was 7452047231 Bump software.amazon.awssdk:bom from 2.29.38 to 2.29.39 Th

(pinot) branch master updated (becb57e064 -> 4edb574bbd)

2024-12-23 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from becb57e064 Adding more arithmetic functions (#14671) add 4edb574bbd Bump software.amazon.awssdk:bom from 2.29.3

Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]

2024-12-23 Thread via GitHub
yashmayya commented on code in PR #14702: URL: https://github.com/apache/pinot/pull/14702#discussion_r1895656731 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apach

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-23 Thread via GitHub
yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895411031 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/cursors/MemoryResponseStore.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Sof

(pinot) branch dependabot/maven/jna.version-5.16.0 created (now fd8453f11d)

2024-12-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jna.version-5.16.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at fd8453f11d Bump jna.version from 5.15.0 to 5.16.0 No new revisions were added by this

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.39 created (now 7452047231)

2024-12-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.39 in repository https://gitbox.apache.org/repos/asf/pinot.git at 7452047231 Bump software.amazon.awssdk:bom from 2.29.38 to 2.29.39 N

[PR] Bump software.amazon.awssdk:bom from 2.29.38 to 2.29.39 [pinot]

2024-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14708: URL: https://github.com/apache/pinot/pull/14708 Bumps software.amazon.awssdk:bom from 2.29.38 to 2.29.39. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/spark2.version-3.5.4 created (now ae68b36322)

2024-12-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/spark2.version-3.5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at ae68b36322 Bump spark2.version from 2.4.8 to 3.5.4 No new revisions were added by t

[PR] Bump spark2.version from 2.4.8 to 3.5.4 [pinot]

2024-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14707: URL: https://github.com/apache/pinot/pull/14707 Bumps `spark2.version` from 2.4.8 to 3.5.4. Updates `org.apache.spark:spark-core_2.12` from 2.4.8 to 3.5.4 Updates `org.apache.spark:spark-sql_2.12` from 2.4.8 to 3.5.4 Depe

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.18.0 created (now aee62f1cc0)

2024-12-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.18.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at aee62f1cc0 Bump com.microsoft.azure:msal4j from 1.17.3 to 1.18.0 No n

[PR] Bump jna.version from 5.15.0 to 5.16.0 [pinot]

2024-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14706: URL: https://github.com/apache/pinot/pull/14706 Bumps `jna.version` from 5.15.0 to 5.16.0. Updates `net.java.dev.jna:jna` from 5.15.0 to 5.16.0 Changelog Sourced from https://github.com/java-native-access/jna/blob/master/CHANGES.

[PR] Bump com.microsoft.azure:msal4j from 1.17.3 to 1.18.0 [pinot]

2024-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14705: URL: https://github.com/apache/pinot/pull/14705 Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.17.3 to 1.18.0. Release notes Sourced from https://github.com/AzureAD/

(pinot) branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.48 created (now 1149e888a9)

2024-12-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.48 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1149e888a9 Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 9.48 No new

[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 9.48 [pinot]

2024-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14704: URL: https://github.com/apache/pinot/pull/14704 Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.47 to 9.48. Changelog Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895514526 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -79,8 +79,48 @@ public MailboxSendOperator(OpChainExecutionC

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895507908 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java: ## @@ -84,8 +92,19 @@ public boolean send(TransferableBlock blo

[PR] Add support for KLL sketch aggregation in minion jobs [pinot]

2024-12-23 Thread via GitHub
raghavagrawal opened a new pull request, #14702: URL: https://github.com/apache/pinot/pull/14702 ## CR Description 1. Add support for KLL sketch aggregation in minion jobs 2. Added new aggregator class PercentileKLLSketchAggregator.java for minion value aggregator. ## Issue deta

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895401883 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -368,6 +368,13 @@ public static class Broker { public static final String CONFIG_O

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895396466 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java: ## @@ -137,4 +165,66 @@ public void cancel(Throwable t) {

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895395934 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java: ## @@ -110,10 +129,16 @@ public boolean send(TransferableBlock

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895389575 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java: ## @@ -207,13 +207,17 @@ protected TransferableBlock getNextBlock()

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895380119 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -484,6 +484,18 @@ default boolean defaultInferPartitionHint() { return Co

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895387864 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java: ## @@ -106,4 +106,9 @@ public boolean isEarlyTerminated() { public bo

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895385593 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/serde/PlanNodeDeserializer.java: ## @@ -117,8 +117,18 @@ private static MailboxReceiveNode deseriali

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-23 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895382286 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/explain/PhysicalExplainPlanVisitor.java: ## @@ -212,14 +215,22 @@ public StringBuilder visitMailboxSe