Re: [PR] Make TableDataManagerProvider pluggable [pinot]

2024-11-15 Thread via GitHub
KKcorps commented on PR #14470: URL: https://github.com/apache/pinot/pull/14470#issuecomment-2480425540 If someone wants to change only the realtime or offline table data manager, they'll still need to initialise the other one. How do we avoid this? -- This is an automated message from th

Re: [I] MultiNodesOfflineClusterIntegrationTest is flaky [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on issue #11122: URL: https://github.com/apache/pinot/issues/11122#issuecomment-2480151070 Same as #10823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[I] [Flaky-test] MapFieldTypeRealtimeTest.testQueries [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang opened a new issue, #14472: URL: https://github.com/apache/pinot/issues/14472 https://github.com/apache/pinot/actions/runs/11864659024/job/33068490082?pr=14470 ``` Error: org.apache.pinot.integration.tests.custom.MapFieldTypeRealtimeTest.testQueries[false](1) -- Tim

[PR] Support for S3A Connector #14312 [pinot]

2024-11-15 Thread via GitHub
chrajeshbabu opened a new pull request, #14474: URL: https://github.com/apache/pinot/pull/14474 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Flaky Test `QueryLoggerTest.shouldHandleRaceConditionsWithDroppedQueries ` [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #10512: Flaky Test `QueryLoggerTest.shouldHandleRaceConditionsWithDroppedQueries ` URL: https://github.com/apache/pinot/issues/10512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(pinot) branch master updated (809141552d -> a51b1d10eb)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 809141552d Fix Flaky test # 14456 (#14462) add a51b1d10eb Refactor `String.format` to Concatenation (#14418) No n

Re: [PR] Refactor `String.format` to Concatenation [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14418: URL: https://github.com/apache/pinot/pull/14418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (c003cc95a5 -> 809141552d)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c003cc95a5 Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 (#14466) add 809141552d Fix Flaky test # 14456

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-11-15 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1844720940 ## pinot-common/src/main/java/org/apache/pinot/common/utils/request/BrokerRequestIdUtils.java: ## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add `optimizeDictionaryType` config to automatically choose dictionary type [pinot]

2024-11-15 Thread via GitHub
itschrispeck commented on code in PR #1: URL: https://github.com/apache/pinot/pull/1#discussion_r1844709969 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -182,6 +182,14 @@ public void init

[I] [Flaky-test] EqualsTransformFunctionTest.testBinaryOperatorTransformFunction [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang opened a new issue, #14473: URL: https://github.com/apache/pinot/issues/14473 https://github.com/apache/pinot/actions/runs/11864659024/job/33068491146?pr=14470 ``` Error: org.apache.pinot.core.operator.transform.function.EqualsTransformFunctionTest.testBinaryOperator

Re: [I] [Flaky-test] HybridClusterIntegrationTest.testReload() [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #14456: [Flaky-test] HybridClusterIntegrationTest.testReload() URL: https://github.com/apache/pinot/issues/14456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Upgrade orc from 1.9.4 to 1.9.5 [pinot]

2024-11-15 Thread via GitHub
codecov-commenter commented on PR #14471: URL: https://github.com/apache/pinot/pull/14471#issuecomment-2480155110 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14471?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] MultiNodesOfflineClusterIntegrationTest is flaky [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #11122: MultiNodesOfflineClusterIntegrationTest is flaky URL: https://github.com/apache/pinot/issues/11122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] [Flaky test] PinotHelixResourceManagerTest.testSegmentReplacement is flaky [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #9651: [Flaky test] PinotHelixResourceManagerTest.testSegmentReplacement is flaky URL: https://github.com/apache/pinot/issues/9651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Flaky-Test] Fix Flaky tests in Pinot-Core org.apache.pinot.queries.ExplainPlanQueriesTest [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #11939: [Flaky-Test] Fix Flaky tests in Pinot-Core org.apache.pinot.queries.ExplainPlanQueriesTest URL: https://github.com/apache/pinot/issues/11939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] Flaky Tests: TPCHQueryIntegrationTest and pinot-kafka-3.0 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on issue #14099: URL: https://github.com/apache/pinot/issues/14099#issuecomment-2480147667 Kafka one was fixed in #14458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] [flakytest] timeout in fork most likely on RealtimeKinesisIntegrationTest [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #11135: [flakytest] timeout in fork most likely on RealtimeKinesisIntegrationTest URL: https://github.com/apache/pinot/issues/11135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [flakytest] timeout in fork most likely on RealtimeKinesisIntegrationTest [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on issue #11135: URL: https://github.com/apache/pinot/issues/11135#issuecomment-2480145834 Kinesis consumer was re-implemented in #12806. Don't observe the same failure since then -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] Flaky Test `QueryLoggerTest.shouldHandleRaceConditionsWithDroppedQueries ` [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on issue #10512: URL: https://github.com/apache/pinot/issues/10512#issuecomment-2480141259 Same as #11426, closing this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] RealtimeNonReplicaGroupSegmentAssignmentTest.testRelocateCompletedSegments is flaky [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed issue #8791: RealtimeNonReplicaGroupSegmentAssignmentTest.testRelocateCompletedSegments is flaky URL: https://github.com/apache/pinot/issues/8791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.14 deleted (was fc01ac7ea4)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.14 in repository https://gitbox.apache.org/repos/asf/pinot.git was fc01ac7ea4 Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 The r

Re: [PR] Make TableDataManagerProvider pluggable [pinot]

2024-11-15 Thread via GitHub
codecov-commenter commented on PR #14470: URL: https://github.com/apache/pinot/pull/14470#issuecomment-2480126615 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14470?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix Flaky test # 14456 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14462: URL: https://github.com/apache/pinot/pull/14462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Make TableDataManagerProvider pluggable [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang opened a new pull request, #14470: URL: https://github.com/apache/pinot/pull/14470 - Make `TableDataManagerProvider` pluggable similar to `InstanceDataManager` - Cleanup `CommonConstants` and `HelixInstanceDataManagerConfig` to reduce duplications -- This is an automated m

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-11-15 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1844554589 ## pinot-common/src/main/java/org/apache/pinot/common/utils/request/BrokerRequestIdUtils.java: ## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (

(pinot) branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.47 deleted (was f2b61ad341)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.47 in repository https://gitbox.apache.org/repos/asf/pinot.git was f2b61ad341 Bump com.nimbusds:nimbus-jose-jwt from 9.46 to 9.47 The revisi

Re: [PR] add logging on segment selection to upsert compaction task [pinot]

2024-11-15 Thread via GitHub
codecov-commenter commented on PR #14469: URL: https://github.com/apache/pinot/pull/14469#issuecomment-2479965417 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14469?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for storing non-CLP-encodable values in a separate column; Replace CLP row value that are too large to store in FixedByteMVMutableForwardIndex with an error message. [pinot]

2024-11-15 Thread via GitHub
deemoliu commented on code in PR #14365: URL: https://github.com/apache/pinot/pull/14365#discussion_r1844509438 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -525,6 +526,9 @@ public boolean index(GenericRo

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-11-15 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1844556126 ## pinot-common/src/thrift/request.thrift: ## @@ -52,4 +52,5 @@ struct InstanceRequest { 4: optional bool enableTrace; 5: optional string brokerId; 6: optional

Re: [PR] Add immtuable CLPForwardIndex creator and related classes [pinot]

2024-11-15 Thread via GitHub
jackluo923 commented on code in PR #14288: URL: https://github.com/apache/pinot/pull/14288#discussion_r1844497055 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/stats/MutableNoDictionaryColStatistics.java: ## @@ -125,4 +125,13 @@ public CL

Re: [PR] Add support for storing non-CLP-encodable values in a separate column; Replace CLP row value that are too large to store in FixedByteMVMutableForwardIndex with an error message. [pinot]

2024-11-15 Thread via GitHub
jackluo923 commented on code in PR #14365: URL: https://github.com/apache/pinot/pull/14365#discussion_r1844484816 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -525,6 +526,9 @@ public boolean index(Generic

[PR] add logging on segment selection to upsert compaction task [pinot]

2024-11-15 Thread via GitHub
dang-stripe opened a new pull request, #14469: URL: https://github.com/apache/pinot/pull/14469 We set the `invalidRecords` threshold too low on one of our tables and noticed the same segments were getting compacted over and over since new upserts were coming in. This adds some logs around s

Re: [I] Nullity Error When Querying `MAX` On Non-Numeric Column [pinot]

2024-11-15 Thread via GitHub
ashishjayamohan closed issue #14459: Nullity Error When Querying `MAX` On Non-Numeric Column URL: https://github.com/apache/pinot/issues/14459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix Flaky test # 14456 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on code in PR #14462: URL: https://github.com/apache/pinot/pull/14462#discussion_r1844402887 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java: ## @@ -788,43 +760,66 @@ public void testReload(boo

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14466: URL: https://github.com/apache/pinot/pull/14466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (f571a56a55 -> 2354b8e82b)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from f571a56a55 Bump codecov/codecov-action from 4 to 5 (#14463) add 2354b8e82b log the instance configs properly (#144

Re: [PR] log the instance configs properly [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14468: URL: https://github.com/apache/pinot/pull/14468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 (#14466)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c003cc95a5 Bump software.amazon.awssdk:bom from 2

(pinot) branch dependabot/github_actions/codecov/codecov-action-5 deleted (was b14ee286d7)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/github_actions/codecov/codecov-action-5 in repository https://gitbox.apache.org/repos/asf/pinot.git was b14ee286d7 Bump codecov/codecov-action from 4 to 5 The revisions that wer

(pinot) branch master updated (eede87f624 -> f571a56a55)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from eede87f624 Bump com.nimbusds:nimbus-jose-jwt from 9.46 to 9.47 (#14465) add f571a56a55 Bump codecov/codecov-action

Re: [PR] Bump codecov/codecov-action from 4 to 5 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14463: URL: https://github.com/apache/pinot/pull/14463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (ec9d07821b -> eede87f624)

2024-11-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ec9d07821b Enhance funnel functions to accept a new option for stepMaxDuration (#14434) add eede87f624 Bump com.n

(pinot) branch dependabot/maven/orc.version-2.0.3 deleted (was 6020df74d5)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/orc.version-2.0.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 6020df74d5 Bump orc.version from 1.9.4 to 2.0.3 The revisions that were on this branch

Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.46 to 9.47 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang merged PR #14465: URL: https://github.com/apache/pinot/pull/14465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump orc.version from 1.9.4 to 2.0.3 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] commented on PR #14467: URL: https://github.com/apache/pinot/pull/14467#issuecomment-2479804398 OK, I won't notify you about version 2.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Bump orc.version from 1.9.4 to 2.0.3 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang commented on PR #14467: URL: https://github.com/apache/pinot/pull/14467#issuecomment-2479804321 @dependabot ignore this major version ORC `2.*` drops support for java 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Bump orc.version from 1.9.4 to 2.0.3 [pinot]

2024-11-15 Thread via GitHub
Jackie-Jiang closed pull request #14467: Bump orc.version from 1.9.4 to 2.0.3 URL: https://github.com/apache/pinot/pull/14467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] log the instance configs properly [pinot]

2024-11-15 Thread via GitHub
codecov-commenter commented on PR #14468: URL: https://github.com/apache/pinot/pull/14468#issuecomment-2479774219 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14468?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] pinot 1.2.0 unrecognizedProperties in fromat following documentation exactly [pinot]

2024-11-15 Thread via GitHub
meshari343 closed issue #14464: pinot 1.2.0 unrecognizedProperties in fromat following documentation exactly URL: https://github.com/apache/pinot/issues/14464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-15 Thread via GitHub
bziobrowski commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1843678750 ## pinot-common/src/main/java/org/apache/pinot/common/request/PinotQuery.java: ## @@ -277,6 +277,7 @@ public void clear() { this.groupByList = null; this.

[PR] Bump orc.version from 1.9.4 to 2.0.3 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14467: URL: https://github.com/apache/pinot/pull/14467 Bumps `orc.version` from 1.9.4 to 2.0.3. Updates `org.apache.orc:orc-core` from 1.9.4 to 2.0.3 Updates `org.apache.orc:orc-mapreduce` from 1.9.4 to 2.0.3 Dependabot will res

[PR] Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14466: URL: https://github.com/apache/pinot/pull/14466 Bumps software.amazon.awssdk:bom from 2.29.11 to 2.29.14. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.12 deleted (was 6139db26bb)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.12 in repository https://gitbox.apache.org/repos/asf/pinot.git was 6139db26bb Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.12 T

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.14 created (now fc01ac7ea4)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.14 in repository https://gitbox.apache.org/repos/asf/pinot.git at fc01ac7ea4 Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.14 N

(pinot) branch dependabot/maven/orc.version-2.0.3 created (now 6020df74d5)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/orc.version-2.0.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 6020df74d5 Bump orc.version from 1.9.4 to 2.0.3 No new revisions were added by this up

(pinot) branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.47 created (now f2b61ad341)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.47 in repository https://gitbox.apache.org/repos/asf/pinot.git at f2b61ad341 Bump com.nimbusds:nimbus-jose-jwt from 9.46 to 9.47 No new

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.12 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] commented on PR #14453: URL: https://github.com/apache/pinot/pull/14453#issuecomment-2478620876 Superseded by #14466. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.12 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] closed pull request #14453: Bump software.amazon.awssdk:bom from 2.29.11 to 2.29.12 URL: https://github.com/apache/pinot/pull/14453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.46 to 9.47 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14465: URL: https://github.com/apache/pinot/pull/14465 Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.46 to 9.47. Changelog Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/

[I] pinot 1.2.0 unrecognizedProperties in fromat following documentation exactly [pinot]

2024-11-15 Thread via GitHub
meshari343 opened a new issue, #14464: URL: https://github.com/apache/pinot/issues/14464 pinot 1.2.0 unrecognizedProperties in fromat following documentation exactly. schema config: "dateTimeFieldSpecs": [ { "name": "timestamp_col", "dataType": "ST

(pinot) branch dependabot/github_actions/codecov/codecov-action-5 created (now b14ee286d7)

2024-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/codecov/codecov-action-5 in repository https://gitbox.apache.org/repos/asf/pinot.git at b14ee286d7 Bump codecov/codecov-action from 4 to 5 No new revisions w

[PR] Bump codecov/codecov-action from 4 to 5 [pinot]

2024-11-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14463: URL: https://github.com/apache/pinot/pull/14463 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. Release notes Sourced from https://github.com/codecov/codecov-action/releases";>codecov/codecov-

Re: [PR] Minion Task to support automatic Segment Refresh [pinot]

2024-11-15 Thread via GitHub
swaminathanmanish commented on code in PR #14300: URL: https://github.com/apache/pinot/pull/14300#discussion_r1843591601 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/refreshsegment/SegmentRefreshTaskProgressObserverFac

Re: [PR] Minion Task to support automatic Segment Refresh [pinot]

2024-11-15 Thread via GitHub
swaminathanmanish commented on PR #14300: URL: https://github.com/apache/pinot/pull/14300#issuecomment-2478568178 Thanks for capturing our discussion in the description. Could you also create a github issue for the follow up task to track? `To overcome this problem, we can use a s

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-15 Thread via GitHub
vrajat commented on PR #14452: URL: https://github.com/apache/pinot/pull/14452#issuecomment-2478481955 > PR behavior is as you wrote above. Got it. And the test cases test the new functionality only. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-15 Thread via GitHub
vrajat commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1843518674 ## pinot-common/src/main/java/org/apache/pinot/common/request/PinotQuery.java: ## @@ -277,6 +277,7 @@ public void clear() { this.groupByList = null; this.order

Re: [PR] Fix Flaky test # 14456 [pinot]

2024-11-15 Thread via GitHub
codecov-commenter commented on PR #14462: URL: https://github.com/apache/pinot/pull/14462#issuecomment-2478339388 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14462?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-15 Thread via GitHub
bziobrowski commented on PR #14452: URL: https://github.com/apache/pinot/pull/14452#issuecomment-2478262012 Current formula is : if `pinot.broker.enable.query.limit.override` and `PinotQuery.limit` > `pinot.broker.query.response.limit` then use pinot.broker.query.response.limit` so it'

[PR] Fix Flaky test # 14456 [pinot]

2024-11-15 Thread via GitHub
deepthi912 opened a new pull request, #14462: URL: https://github.com/apache/pinot/pull/14462 Reference issue: https://github.com/apache/pinot/issues/14456 This fix mainly addresses below points: 1) Checks totalDocs from select count(*) query which addresses through all newly added

Re: [PR] Enhance funnel functions to accept a new option for maxStepDuration [pinot]

2024-11-15 Thread via GitHub
xiangfu0 merged PR #14434: URL: https://github.com/apache/pinot/pull/14434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa