jackluo923 commented on code in PR #14365:
URL: https://github.com/apache/pinot/pull/14365#discussion_r1844484816


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -525,6 +526,9 @@ public boolean index(GenericRow row, @Nullable RowMetadata 
rowMetadata)
       }
     }
 
+    // NOTE: we msut do this before we index a single column to avoid 
partially indexing the row

Review Comment:
   It's an edge case that wasn't handled in the original Pinot code. CLP 
triggered this edge case in very extreme case. Specifically, if a MV column's 
content is larger than a chunk, Pinot will error with or without CLP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to