jackluo923 commented on code in PR #14288:
URL: https://github.com/apache/pinot/pull/14288#discussion_r1844497055


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/stats/MutableNoDictionaryColStatistics.java:
##########
@@ -125,4 +125,13 @@ public CLPStats getCLPStats() {
     throw new IllegalStateException(
         "CLP stats not available for column: " + 
_dataSourceMetadata.getFieldSpec().getName());
   }
+

Review Comment:
   ClpMutableForwardIndexV2 index -> ClpForwardIndexCreator (V1): use 
`getCLPStats()`
   ClpMutableForwardIndexV2 index -> ClpForwardIndexCreatorV2: use 
`getCLPV2Stats()`
   
   `getCLPStats()` method is basically for compatibility with the initial 
version of immutable forward index.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to