Re: [PR] [WIP] Support preceding and following in WINDOW [pinot]

Jackie-Jiang commented on code in PR #14233: URL: https://github.com/apache/pinot/pull/14233#discussion_r1802470255 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -209,23 +244,37 @@ private void validateWindo

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

Jackie-Jiang commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1802466898 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map

Re: [PR] Hadoop Ingestion job configured with hdfs is failing with IllegalArgu… [pinot]

codecov-commenter commented on PR #14244: URL: https://github.com/apache/pinot/pull/14244#issuecomment-2415770968 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14244?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [WIP] Support preceding and following in WINDOW [pinot]

yashmayya commented on code in PR #14233: URL: https://github.com/apache/pinot/pull/14233#discussion_r1802367928 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -209,23 +244,37 @@ private void validateWindows(

[PR] Hadoop Ingestion job configured with hdfs is failing with IllegalArgu… [pinot]

chrajeshbabu opened a new pull request, #14244: URL: https://github.com/apache/pinot/pull/14244 …mentException (#14236) Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui`

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802220214 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -120,39 +121,46 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802220214 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -120,39 +121,46 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802218559 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -120,39 +121,46 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802191661 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -120,39 +121,46 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802163421 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

codecov-commenter commented on PR #14241: URL: https://github.com/apache/pinot/pull/14241#issuecomment-2415262460 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enabling LogicalProject pushdown optimizations to eliminate exchange of unused columns [pinot]

shauryachats commented on PR #14198: URL: https://github.com/apache/pinot/pull/14198#issuecomment-2415247394 @Jackie-Jiang I tried various permutations of reorganizing these rules which could minimize the projection of unused columns and reduce the modification of the number of existing log

[I] Define Concrete Rule Order in Multistage Query Optimization [pinot]

shauryachats opened a new issue, #14243: URL: https://github.com/apache/pinot/issues/14243 The current order of query optimization rules in the logical plan stage does not cover all the corner cases for multistage queries (an example is https://github.com/apache/pinot/pull/14198). T

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1802060944 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

jackluo923 commented on code in PR #14241: URL: https://github.com/apache/pinot/pull/14241#discussion_r1802042000 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/CLPMutableForwardIndexV2.java: ## @@ -0,0 +1,468 @@ +/** + * Licensed to th

Re: [PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

jackluo923 commented on code in PR #14241: URL: https://github.com/apache/pinot/pull/14241#discussion_r1802041475 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/CLPMutableForwardIndexV2.java: ## @@ -0,0 +1,468 @@ +/** + * Licensed to th

Re: [PR] Secure Excecution of Groovy Code [pinot]

ege-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1802036434 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterConfig(

Re: [PR] Secure Excecution of Groovy Code [pinot]

ege-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1802034731 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterConfig(

Re: [PR] Secure Excecution of Groovy Code [pinot]

ege-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1802030415 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterConfig(

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801998066 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

deemoliu commented on code in PR #14241: URL: https://github.com/apache/pinot/pull/14241#discussion_r1801989306 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/CLPMutableForwardIndexV2.java: ## @@ -0,0 +1,468 @@ +/** + * Licensed to the

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801986081 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801986081 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Bump calcite.version from 1.37.0 to 1.38.0 [pinot]

dependabot[bot] commented on PR #14239: URL: https://github.com/apache/pinot/pull/14239#issuecomment-2415081516 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

(pinot) branch dependabot/maven/calcite.version-1.38.0 deleted (was 1bd0e815db)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/calcite.version-1.38.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1bd0e815db Bump calcite.version from 1.37.0 to 1.38.0 The revisions that were on

Re: [PR] Bump calcite.version from 1.37.0 to 1.38.0 [pinot]

Jackie-Jiang commented on PR #14239: URL: https://github.com/apache/pinot/pull/14239#issuecomment-2415081436 Will perform the upgrade manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump calcite.version from 1.37.0 to 1.38.0 [pinot]

Jackie-Jiang closed pull request #14239: Bump calcite.version from 1.37.0 to 1.38.0 URL: https://github.com/apache/pinot/pull/14239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

deemoliu commented on code in PR #14241: URL: https://github.com/apache/pinot/pull/14241#discussion_r1801971635 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/CLPMutableForwardIndexV2.java: ## @@ -0,0 +1,468 @@ +/** + * Licensed to the

Re: [PR] Upgraded clp-ffi.version from 0.4.5 to 0.4.7 [pinot]

Jackie-Jiang merged PR #14242: URL: https://github.com/apache/pinot/pull/14242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (47b322bde7 -> 4220d09e11)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 47b322bde7 [timeseries] Minor Time Series Engine Improvements (#14227) add 4220d09e11 Upgraded clp-ffi.version fro

Re: [PR] Upgraded clp-ffi.version from 0.4.5 to 0.4.7 [pinot]

codecov-commenter commented on PR #14242: URL: https://github.com/apache/pinot/pull/14242#issuecomment-2414889198 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14242?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

deepthi912 commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1801784303 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map e

Re: [PR] Improve parse error handling and error messages. [pinot]

Jackie-Jiang commented on PR #14238: URL: https://github.com/apache/pinot/pull/14238#issuecomment-2414801502 If babel is the root cause, we can consider using a different config to reduce the non-preserved keyword -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Improve parse error handling and error messages. [pinot]

Jackie-Jiang commented on PR #14238: URL: https://github.com/apache/pinot/pull/14238#issuecomment-2414798159 We should avoid touching the code copy-pasted from Calcite unless absolutely necessary. Modifying the copy pasted code means extra management overhead going forward, which IMO is not

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

deepthi912 commented on PR #14235: URL: https://github.com/apache/pinot/pull/14235#issuecomment-2414781538 Yeah, it is going through already lookedup env variables again which resulted in the env variables not applied at all. -- This is an automated message from the Apache Git Service. To

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

t0mpere commented on PR #14235: URL: https://github.com/apache/pinot/pull/14235#issuecomment-2414766524 If the config is applied twice then the function `applyDynamicEnvConfig(List configurations, Map environmentVariables)` the second time gets ran will try to lookup env vars based on the

Re: [PR] Add Tabled Is Disabled Error [pinot]

ashishjayamohan commented on PR #14199: URL: https://github.com/apache/pinot/pull/14199#issuecomment-2414765644 @Jackie-Jiang I changed the behavior here. In the case where the user is querying a hybrid table and one table (offline/realtime) is disabled, it will add a partial results err

Re: [PR] Introduce raw fwd index version V5 containing implicit num doc length, improving space efficiency [pinot]

Jackie-Jiang commented on code in PR #14105: URL: https://github.com/apache/pinot/pull/14105#discussion_r1801734384 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV5.java: ## @@ -0,0 +1,76 @@ +/** + * Licensed to

Re: [PR] colocated-without-hints [pinot]

Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801671644 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +447,44 @@ private static HepProgram getTraitProgram() { }

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801704162 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801691957 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

[PR] Add the initial implementation of CLPMutableForwardIndexV2 [pinot]

jackluo923 opened a new pull request, #14241: URL: https://github.com/apache/pinot/pull/14241 Placeholder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Secure Excecution of Groovy Code [pinot]

soumitra-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1801686832 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterCo

Re: [PR] Secure Excecution of Groovy Code [pinot]

soumitra-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1801685282 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterCo

Re: [PR] Secure Excecution of Groovy Code [pinot]

soumitra-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1801682674 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterCo

Re: [PR] Secure Excecution of Groovy Code [pinot]

soumitra-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1801681911 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterCo

(pinot) branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 deleted (was 3f98ee7d99)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 in repository https://gitbox.apache.org/repos/asf/pinot.git was 3f98ee7d99 Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 The revisions t

Re: [PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

dependabot[bot] commented on PR #14240: URL: https://github.com/apache/pinot/pull/14240#issuecomment-2414659470 OK, I won't notify you about com.yscope.clp:clp-ffi again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

dependabot[bot] closed pull request #14240: Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 URL: https://github.com/apache/pinot/pull/14240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

Jackie-Jiang commented on PR #14240: URL: https://github.com/apache/pinot/pull/14240#issuecomment-2414659333 @dependabot ignore this dependency This was reverted in #14230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801664644 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801655354 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801655563 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801652737 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801644609 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 commented on PR #14237: URL: https://github.com/apache/pinot/pull/14237#issuecomment-2414624815 > It would be good to add logging and even metrics)on batch commit, if we don't already have it: > > * How many IS updates in the batch? > * Time for update > * Retry count

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

t0mpere commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1801628032 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map envi

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

t0mpere commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1801628032 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map envi

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

deepthi912 commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1801624732 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map e

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

dinoocch closed pull request #14214: Fix race-conditions in IdealStateGroupCommit URL: https://github.com/apache/pinot/pull/14214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

dinoocch commented on PR #14214: URL: https://github.com/apache/pinot/pull/14214#issuecomment-2414561986 > I made some minor changes based on your diff: #14237 Sure, we can use that pr instead. I left a couple questions -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

dinoocch commented on code in PR #14237: URL: https://github.com/apache/pinot/pull/14237#discussion_r1801597267 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,35 +125,44 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

t0mpere commented on code in PR #14235: URL: https://github.com/apache/pinot/pull/14235#discussion_r1801579808 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -170,8 +173,15 @@ public static List applyDynamicEnvConfig(List conf Map envi

Re: [PR] Speed up dev build. [pinot]

bziobrowski commented on code in PR #14210: URL: https://github.com/apache/pinot/pull/14210#discussion_r1801373445 ## pinot-controller/pom.xml: ## @@ -121,13 +122,13 @@ -npm ci +npm ci Review Comment: You're right

Re: [PR] Introduce raw fwd index version V5 containing implicit num doc length, improving space efficiency [pinot]

jackluo923 commented on code in PR #14105: URL: https://github.com/apache/pinot/pull/14105#discussion_r1801296645 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java: ## @@ -106,6 +108,10 @@ public static Forwa

Re: [PR] colocated-without-hints [pinot]

gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801076744 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,64 @@ public class QueryEnvironment { private final FrameworkCon

Re: [PR] colocated-without-hints [pinot]

gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801073246 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801059669 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Fo

[PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

dependabot[bot] opened a new pull request, #14240: URL: https://github.com/apache/pinot/pull/14240 Bumps [com.yscope.clp:clp-ffi](https://github.com/y-scope/clp-ffi-java) from 0.4.5 to 0.4.6. Commits See full diff in https://github.com/y-scope/clp-ffi-java/commits/v0.4.6";>comp

(pinot) branch dependabot/maven/calcite.version-1.38.0 created (now 1bd0e815db)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/calcite.version-1.38.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1bd0e815db Bump calcite.version from 1.37.0 to 1.38.0 No new revisions were added

(pinot) branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 created (now 3f98ee7d99)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 in repository https://gitbox.apache.org/repos/asf/pinot.git at 3f98ee7d99 Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 No new revision

[PR] Bump calcite.version from 1.37.0 to 1.38.0 [pinot]

dependabot[bot] opened a new pull request, #14239: URL: https://github.com/apache/pinot/pull/14239 Bumps `calcite.version` from 1.37.0 to 1.38.0. Updates `org.apache.calcite:calcite-core` from 1.37.0 to 1.38.0 Commits https://github.com/apache/calcite/commit/e5e7faeff5985bc1b

Re: [PR] Improve parse error handling and error messages. [pinot]

codecov-commenter commented on PR #14238: URL: https://github.com/apache/pinot/pull/14238#issuecomment-2413586966 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14238?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Speed up dev build. [pinot]

vrajat commented on code in PR #14210: URL: https://github.com/apache/pinot/pull/14210#discussion_r1800927019 ## pinot-controller/src/main/resources/package.json: ## @@ -57,7 +57,8 @@ "url-loader": "4.1.1", "webpack": "4.29.6", "webpack-cli": "3.3.0", -"webpac

Re: [PR] #13941 Added validation for minionInstaceTag while creating a new TableTask [pinot]

tarun11Mavani commented on PR #14228: URL: https://github.com/apache/pinot/pull/14228#issuecomment-2413481936 cc @tibrewalpratik17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix race condition in IdealStateGroupCommit [pinot]

codecov-commenter commented on PR #14237: URL: https://github.com/apache/pinot/pull/14237#issuecomment-2413473989 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Improve parse error handling and error messages. [pinot]

bziobrowski opened a new pull request, #14238: URL: https://github.com/apache/pinot/pull/14238 Work in progress Currently if we use any reserved keyword as part of query or as a column name in Pinot, we get back a very cryptic(non-useful) Query Compilation error, e.g. ```sql

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

xiangfu0 commented on PR #14214: URL: https://github.com/apache/pinot/pull/14214#issuecomment-2413390632 I made some minor changes based on your diff: https://github.com/apache/pinot/pull/14237 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Fix race condition in IdealStateGroupCommit [pinot]

xiangfu0 opened a new pull request, #14237: URL: https://github.com/apache/pinot/pull/14237 This fix is inspired by https://github.com/apache/pinot/pull/14214 Will handle the failure scenario gracefully. Adding a test to update IS from many processors to ensure no loss of the e

Re: [PR] Do not get the environment variables twice for same property(Environment variables not identified through properties file) [pinot]

codecov-commenter commented on PR #14235: URL: https://github.com/apache/pinot/pull/14235#issuecomment-2413326418 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14235?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[I] Hadoop Ingestion job configured with hdfs is failing with IllegalArgumentException [pinot]

chrajeshbabu opened a new issue, #14236: URL: https://github.com/apache/pinot/issues/14236 Hadoop Batch ingestion job configured with hdfs file system failing with following exception. java.lang.RuntimeException: Caught exception during running - org.apache.pinot.plugin.ingestion.ba

[PR] Do not decode and add the environment variables twice [pinot]

deepthi912 opened a new pull request, #14235: URL: https://github.com/apache/pinot/pull/14235 Issue: The environment variable is not setting right with the dynamic.env.config property in controller.conf file. Reference PR: https://github.com/apache/pinot/pull/12307 Root cause: