ege-st commented on code in PR #14197: URL: https://github.com/apache/pinot/pull/14197#discussion_r1802036434
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java: ########## @@ -168,4 +170,74 @@ public SuccessResponse deleteClusterConfig( throw new ControllerApplicationException(LOGGER, errStr, Response.Status.INTERNAL_SERVER_ERROR, e); } } + + @GET + @Path("/cluster/groovy/analyzer/static/default") Review Comment: Current design is that if the feature is disabled if there is no config and enabled if there is a config (per a comment on an older version of this PR). Hence adding a method to easily get a default config that can then be used to turn on this feature. Alternatively, a query param could be added to the Set method which, when true, will set the configuration to the Default configuration and if false will use the config provided in the request body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org