bziobrowski opened a new pull request, #14238:
URL: https://github.com/apache/pinot/pull/14238
Work in progress
Currently if we use any reserved keyword as part of query or as a column
name in Pinot, we get back a very cryptic(non-useful) Query Compilation error,
e.g.
```sql
WITH grouping AS (SELECT 1) select * from grouping;
```
triggers:
`SQLParsingError:
java.lang.Exception: Unable to parse the SQL: 'WITH grouping AS (SELECT`
In most cases error's position, token and list of expected tokens are wrong.
This PR improves errors generated by parser so that the sql above triggers :
`
Encountered \" \"GROUPING\" \"grouping \"\" at line 1, column 6.\n"
+ "Was expecting one of:\n"
+ " <BRACKET_QUOTED_IDENTIFIER> ...
`
The biggest change in the PR is switch from global lookahead value 2 to 1.
Most of the changes in Parser.jj file are fixes for clashes caused by it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
