Re: [I] Lucene 10.0 upgrade [pinot]

2024-10-14 Thread via GitHub
hpvd commented on issue #14232: URL: https://github.com/apache/pinot/issues/14232#issuecomment-2412946563 full changelog: https://lucene.apache.org/core/10_0_0/changes/Changes.html#v10.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Lucene 10.0 upgrade [pinot]

2024-10-14 Thread via GitHub
hpvd commented on issue #14232: URL: https://github.com/apache/pinot/issues/14232#issuecomment-2412944422 Overview of what has been changed and what has to be done after upgrade e.g. reindex https://lucene.apache.org/core/corenews.html#apache-lucenetm-1000-available -- This is

Re: [PR] Auto reset of error segments on segment validation [pinot]

2024-10-14 Thread via GitHub
yashmayya commented on code in PR #14217: URL: https://github.com/apache/pinot/pull/14217#discussion_r1800435318 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -169,6 +171,10 @@ private void runSegmentLevelVa

Re: [PR] Auto reset of error segments on segment validation [pinot]

2024-10-14 Thread via GitHub
itschrispeck commented on code in PR #14217: URL: https://github.com/apache/pinot/pull/14217#discussion_r1800411604 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -169,6 +171,10 @@ private void runSegmentLeve

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
dinoocch commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1800337123 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
mayankshriv commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1800301360 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixMa

(pinot) branch master updated: [timeseries] Minor Time Series Engine Improvements (#14227)

2024-10-14 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 47b322bde7 [timeseries] Minor Time Series E

Re: [PR] [timeseries] Minor Time Series Engine Improvements [pinot]

2024-10-14 Thread via GitHub
ankitsultana merged PR #14227: URL: https://github.com/apache/pinot/pull/14227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [WIP] Support preceding and following in WINDOW [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14233: URL: https://github.com/apache/pinot/pull/14233#issuecomment-2412625957 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14233?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [WIP] Support preceding and following in WINDOW [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang opened a new pull request, #14233: URL: https://github.com/apache/pinot/pull/14233 Support the following functionalities in WINDOW function: - ROWS with bounded preceding/following - IGNORE NULLS in aggregates -- This is an automated message from the Apache Git Service.

Re: [PR] Secure Excecution of Groovy Code [pinot]

2024-10-14 Thread via GitHub
ege-st commented on PR #14197: URL: https://github.com/apache/pinot/pull/14197#issuecomment-2412571066 > > `/cluster/groovy/analyzer/static/config` API, > > Is this the right convention to use for such an API? Only until cluster/config/groovy are we doing a hierarchy, so perhaps somet

Re: [PR] Secure Excecution of Groovy Code [pinot]

2024-10-14 Thread via GitHub
ege-st commented on PR #14197: URL: https://github.com/apache/pinot/pull/14197#issuecomment-2412569140 Good catch. Will fix. On Sat, Oct 12, 2024 at 8:36 PM Neha Pawar ***@***.***> wrote: > pinot.server.query.groovy.analyzer.static > > this covers both ingestion time and q

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
xiangfu0 commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1800246038 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

Re: [I] [flaky test] CLP Message Decoder [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on issue #14231: URL: https://github.com/apache/pinot/issues/14231#issuecomment-2412540002 Might be related to #14230 @jackluo923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Adding kafka consumer group for reporting offset back to Kafka [pinot]

2024-10-14 Thread via GitHub
vivekkoya commented on issue #14109: URL: https://github.com/apache/pinot/issues/14109#issuecomment-2412535502 Hello, I would like to take this task. How can I get started? Can you please direct me to the relevant files and directories? Thanks for the help -- This is an automate

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-14 Thread via GitHub
abhioncbr commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2412525625 > @abhioncbr Lucene just released `10.0.0`. We can try directly moving to this version sure, let me raise the issue for this to track. Thanks -- This is an automated message fr

[I] [flaky test] CLP Message Decoder [pinot]

2024-10-14 Thread via GitHub
ankitsultana opened a new issue, #14231: URL: https://github.com/apache/pinot/issues/14231 Saw this in one of my PRs ``` Error:CLPEncodingRealtimeIntegrationTest.testValues:96 » PinotClient Query had processing exceptions: [{"errorCode":200,"message":"QueryExecutionError:\

Re: [PR] Auto reset of error segments on segment validation [pinot]

2024-10-14 Thread via GitHub
shauryachats commented on code in PR #14217: URL: https://github.com/apache/pinot/pull/14217#discussion_r1800218911 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -169,6 +171,10 @@ private void runSegmentLeve

Re: [PR] Auto reset of error segments on segment validation [pinot]

2024-10-14 Thread via GitHub
shauryachats commented on code in PR #14217: URL: https://github.com/apache/pinot/pull/14217#discussion_r1800218911 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -169,6 +171,10 @@ private void runSegmentLeve

(pinot) branch master updated (afb63bcfeb -> 68cb61666f)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from afb63bcfeb Enhance `optimizeDictionary` to optionally optimize var-width type cols (#13994) add 68cb61666f Revert

Re: [PR] Revert #14206 as the automatic library version bump breaks integration test [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14230: URL: https://github.com/apache/pinot/pull/14230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Revert #14206 as the automatic library version bump breaks integration test [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14230: URL: https://github.com/apache/pinot/pull/14230#issuecomment-2412448652 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14230?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
xiangfu0 commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1800177576 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

[PR] Revert #14206 as the automatic library version bump breaks integration test [pinot]

2024-10-14 Thread via GitHub
jackluo923 opened a new pull request, #14230: URL: https://github.com/apache/pinot/pull/14230 The automatic bumping of library version caused integration test to break for unknown reason under jdk21. Will investigate and fix the bug and release a new version before bumping the version in Pi

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
xiangfu0 commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1800168227 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
dinoocch commented on PR #14214: URL: https://github.com/apache/pinot/pull/14214#issuecomment-2412190761 > Thanks for debugging this! Since this piece of code is borrowed from Helix GroupCommit.java, can you help also check if Helix has the same issue? This might explain https://github.com/

Re: [PR] Add a flexible json config way [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14229: URL: https://github.com/apache/pinot/pull/14229#issuecomment-2412094546 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14229?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
dinoocch commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r183998 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1799977600 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -485,6 +485,16 @@ protected BrokerResponse han

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
mcvsubbu commented on code in PR #14214: URL: https://github.com/apache/pinot/pull/14214#discussion_r1799973196 ## pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java: ## @@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManag

Re: [PR] Add a flexible json config way [pinot]

2024-10-14 Thread via GitHub
lnbest0707-uber commented on PR #14200: URL: https://github.com/apache/pinot/pull/14200#issuecomment-2412019459 Use https://github.com/apache/pinot/pull/14229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add a flexible json config way [pinot]

2024-10-14 Thread via GitHub
lnbest0707-uber closed pull request #14200: Add a flexible json config way URL: https://github.com/apache/pinot/pull/14200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Add a flexible json config way [pinot]

2024-10-14 Thread via GitHub
lnbest0707-uber opened a new pull request, #14229: URL: https://github.com/apache/pinot/pull/14229 Json index is a frequently used feature but currently with very limited configuration ways. Users could only have a global max level or array index limit. The existing includePaths/excludePath

Re: [PR] Fix default column handling when forward index is disabled [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14215: URL: https://github.com/apache/pinot/pull/14215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2411931912 @abhioncbr Lucene just released `10.0.0`. We can try directly moving to this version -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix race-conditions in IdealStateGroupCommit [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on PR #14214: URL: https://github.com/apache/pinot/pull/14214#issuecomment-2411958404 Thanks for debugging this! Since this piece of code is borrowed from Helix `GroupCommit.java`, can you help also check if Helix has the same issue? This might explain https://github.

Re: [I] Loading the zookeeper browser page is failing with error [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on issue #14216: URL: https://github.com/apache/pinot/issues/14216#issuecomment-2411948823 cc @jayeshchoudhary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.1 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14223: URL: https://github.com/apache/pinot/pull/14223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.1 deleted (was 846a9684fa)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 846a9684fa Bump org.apache.datasketches:datasketches-java fr

(pinot) branch master updated (5c06547ba3 -> afb63bcfeb)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 5c06547ba3 Bump com.github.jnr:jnr-ffi from 2.2.16 to 2.2.17 (#14224) add afb63bcfeb Enhance `optimizeDictionary`

(pinot) branch dependabot/maven/curator.version-5.7.1 deleted (was d12371c986)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/curator.version-5.7.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was d12371c986 Bump curator.version from 5.7.0 to 5.7.1 The revisions that were on this br

(pinot) branch dependabot/maven/org.jetbrains-annotations-26.0.1 deleted (was ed0b7ec033)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.jetbrains-annotations-26.0.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was ed0b7ec033 Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 The revisi

Re: [PR] Enhance `optimizeDictionary` to optionally optimize var-width type cols [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang commented on PR #13994: URL: https://github.com/apache/pinot/pull/13994#issuecomment-2411946011 Basically we specify: - Size based only for fixed length type - Cardinality based only for var-length type Let's document this behavior so that user doesn't expect wrong t

Re: [PR] Enhance `optimizeDictionary` to optionally optimize var-width type cols [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #13994: URL: https://github.com/apache/pinot/pull/13994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.github.jnr-jnr-ffi-2.2.17 deleted (was 40b1360079)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.github.jnr-jnr-ffi-2.2.17 in repository https://gitbox.apache.org/repos/asf/pinot.git was 40b1360079 Bump com.github.jnr:jnr-ffi from 2.2.16 to 2.2.17 The revisions tha

(pinot) branch master updated (7d14feaad1 -> 5c06547ba3)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7d14feaad1 Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.1 (#14223) add 5c06547ba3 Bump com.gi

Re: [PR] Bump com.github.jnr:jnr-ffi from 2.2.16 to 2.2.17 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14224: URL: https://github.com/apache/pinot/pull/14224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (3d97e07f4e -> 3001856adb)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3d97e07f4e Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 (#14220) add 3001856adb Bump com.github.jnr:jnr-p

(pinot) branch master updated (3001856adb -> bba3c7a11a)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3001856adb Bump com.github.jnr:jnr-posix from 3.1.19 to 3.1.20 (#14221) add bba3c7a11a Bump curator.version from 5

(pinot) branch master updated: Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.1 (#14223)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7d14feaad1 Bump org.apache.datasketches:datasketc

Re: [PR] Bump curator.version from 5.7.0 to 5.7.1 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14222: URL: https://github.com/apache/pinot/pull/14222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.github.jnr:jnr-posix from 3.1.19 to 3.1.20 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14221: URL: https://github.com/apache/pinot/pull/14221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.github.jnr-jnr-posix-3.1.20 deleted (was d07ed0f4f1)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.github.jnr-jnr-posix-3.1.20 in repository https://gitbox.apache.org/repos/asf/pinot.git was d07ed0f4f1 Bump com.github.jnr:jnr-posix from 3.1.19 to 3.1.20 The revision

Re: [PR] Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14220: URL: https://github.com/apache/pinot/pull/14220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 (#14220)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3d97e07f4e Bump org.jetbrains:annotations from 26

(pinot) branch dependabot/maven/org.checkerframework-checker-qual-3.48.1 deleted (was a20d84d7bc)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.checkerframework-checker-qual-3.48.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was a20d84d7bc Bump org.checkerframework:checker-qual from 3.48.0 to 3.

(pinot) branch master updated: Bump org.checkerframework:checker-qual from 3.48.0 to 3.48.1 (#14218)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2668baf240 Bump org.checkerframework:checker-qual

Re: [PR] Bump org.checkerframework:checker-qual from 3.48.0 to 3.48.1 [pinot]

2024-10-14 Thread via GitHub
Jackie-Jiang merged PR #14218: URL: https://github.com/apache/pinot/pull/14218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (b067ae1924 -> 095c16676e)

2024-10-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b067ae1924 Extract common MV ser/de logic into ArraySerDeUtils (#14209) add 095c16676e Fix default column handling

Re: [PR] #13941 Added validation for minionInstaceTag while creating a new TableTask [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14228: URL: https://github.com/apache/pinot/pull/14228#issuecomment-2411804442 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14228?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-14 Thread via GitHub
ashishjayamohan commented on PR #14199: URL: https://github.com/apache/pinot/pull/14199#issuecomment-2411799415 I'm unsure of what that file is to be entirely honest. I didn't add it in, but I imagine it must've been added as part of some test? Removing it now since it seems to be unnecessa

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-14 Thread via GitHub
vrajat commented on PR #14199: URL: https://github.com/apache/pinot/pull/14199#issuecomment-2411795249 Is the `tar.gz` file added by mistake ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] #13941 Added validation for minionInstaceTag while creating a new TableTask [pinot]

2024-10-14 Thread via GitHub
tarun11Mavani opened a new pull request, #14228: URL: https://github.com/apache/pinot/pull/14228 When creating a new Task with in TableTaskConfig, validate that a minion tenant with the same tag exists. If a minion with same minionInstaceTag doesn't exist, we will fail the table creation

Re: [PR] Add Tabled Is Disabled Error [pinot]

2024-10-14 Thread via GitHub
ashishjayamohan commented on code in PR #14199: URL: https://github.com/apache/pinot/pull/14199#discussion_r1799774790 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java: ## @@ -184,6 +185,9 @@ private void processSegmentAssignmentChange() {

Re: [PR] [timeseries] Minor Time Series Engine Improvements [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14227: URL: https://github.com/apache/pinot/pull/14227#issuecomment-2411640826 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14227?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #14226: URL: https://github.com/apache/pinot/pull/14226#issuecomment-2411500432 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14226?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-14 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1799593198 ## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java: ## @@ -292,15 +292,28 @@ protected TableConfig crea

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-14 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1799591241 ## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ## @@ -531,25 +674,41 @@ private static ExternalV

[PR] Add support for application -level query quota. [pinot]

2024-10-14 Thread via GitHub
bziobrowski opened a new pull request, #14226: URL: https://github.com/apache/pinot/pull/14226 This PR adds a way to throttle queries (executed with both v1 or v2 engine) based on `applicationName` query option. Queries such as : ```sql set applicationName='test'; select * from

[I] Pinot server memory usage [pinot]

2024-10-14 Thread via GitHub
vineethvp opened a new issue, #14225: URL: https://github.com/apache/pinot/issues/14225 We are running a Pinot cluster in production with 4 servers (16 GB ,4 Cores). There are multiple realtime tables consuming from Kafka topics. We are observing the 60 to 70 % of the total memory is being

(pinot) branch dependabot/maven/com.github.jnr-jnr-ffi-2.2.17 created (now 40b1360079)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.github.jnr-jnr-ffi-2.2.17 in repository https://gitbox.apache.org/repos/asf/pinot.git at 40b1360079 Bump com.github.jnr:jnr-ffi from 2.2.16 to 2.2.17 No new revis

[PR] Bump com.github.jnr:jnr-ffi from 2.2.16 to 2.2.17 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14224: URL: https://github.com/apache/pinot/pull/14224 Bumps [com.github.jnr:jnr-ffi](https://github.com/jnr/jnr-ffi) from 2.2.16 to 2.2.17. Commits https://github.com/jnr/jnr-ffi/commit/32cd8f636d1b0c91d6d011cc293530816bf60f42";>32cd

(pinot) branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.0 deleted (was e7f68bd537)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was e7f68bd537 Bump org.apache.datasketches:datasketches-jav

(pinot) branch dependabot/maven/curator.version-5.7.1 created (now d12371c986)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/curator.version-5.7.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at d12371c986 Bump curator.version from 5.7.0 to 5.7.1 No new revisions were added by

(pinot) branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.1 created (now 846a9684fa)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.datasketches-datasketches-java-6.1.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 846a9684fa Bump org.apache.datasketches:datasketches-jav

Re: [PR] Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.0 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] closed pull request #14005: Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.0 URL: https://github.com/apache/pinot/pull/14005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.0 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] commented on PR #14005: URL: https://github.com/apache/pinot/pull/14005#issuecomment-2411006576 Superseded by #14223. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.1 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14223: URL: https://github.com/apache/pinot/pull/14223 Bumps org.apache.datasketches:datasketches-java from 6.0.0 to 6.1.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-

[PR] Bump curator.version from 5.7.0 to 5.7.1 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14222: URL: https://github.com/apache/pinot/pull/14222 Bumps `curator.version` from 5.7.0 to 5.7.1. Updates `org.apache.curator:curator-client` from 5.7.0 to 5.7.1 Commits https://github.com/apache/curator/commit/a8b4dc3f08384978646

[PR] Bump com.github.jnr:jnr-posix from 3.1.19 to 3.1.20 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14221: URL: https://github.com/apache/pinot/pull/14221 Bumps [com.github.jnr:jnr-posix](https://github.com/jnr/jnr-posix) from 3.1.19 to 3.1.20. Commits https://github.com/jnr/jnr-posix/commit/3ebda1da859f0f2f6b750f27deab7e73ec450a63"

(pinot) branch dependabot/maven/com.github.jnr-jnr-posix-3.1.20 created (now d07ed0f4f1)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.github.jnr-jnr-posix-3.1.20 in repository https://gitbox.apache.org/repos/asf/pinot.git at d07ed0f4f1 Bump com.github.jnr:jnr-posix from 3.1.19 to 3.1.20 No new r

(pinot) branch dependabot/maven/org.jetbrains-annotations-26.0.1 created (now ed0b7ec033)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.jetbrains-annotations-26.0.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at ed0b7ec033 Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 No new

(pinot) branch dependabot/maven/lucene.version-9.12.0 deleted (was fa9fb3ae71)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/lucene.version-9.12.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was fa9fb3ae71 Bump lucene.version from 9.11.1 to 9.12.0 The revisions that were on th

[PR] Bump org.jetbrains:annotations from 26.0.0 to 26.0.1 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14220: URL: https://github.com/apache/pinot/pull/14220 Bumps [org.jetbrains:annotations](https://github.com/JetBrains/java-annotations) from 26.0.0 to 26.0.1. Release notes Sourced from https://github.com/JetBrains/java-annotations/relea

Re: [PR] Bump lucene.version from 9.11.1 to 9.12.0 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] closed pull request #14114: Bump lucene.version from 9.11.1 to 9.12.0 URL: https://github.com/apache/pinot/pull/14114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump lucene.version from 9.11.1 to 9.12.0 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] commented on PR #14114: URL: https://github.com/apache/pinot/pull/14114#issuecomment-2410997920 Superseded by #14219. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pinot) branch dependabot/maven/org.checkerframework-checker-qual-3.48.1 created (now a20d84d7bc)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.checkerframework-checker-qual-3.48.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at a20d84d7bc Bump org.checkerframework:checker-qual from 3.48.0 t

[PR] Bump org.checkerframework:checker-qual from 3.48.0 to 3.48.1 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14218: URL: https://github.com/apache/pinot/pull/14218 Bumps [org.checkerframework:checker-qual](https://github.com/typetools/checker-framework) from 3.48.0 to 3.48.1. Release notes Sourced from https://github.com/typetools/checker-frame

(pinot) branch dependabot/maven/lucene.version-10.0.0 created (now beed9830b2)

2024-10-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/lucene.version-10.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at beed9830b2 Bump lucene.version from 9.11.1 to 10.0.0 No new revisions were added b

[PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-14 Thread via GitHub
dependabot[bot] opened a new pull request, #14219: URL: https://github.com/apache/pinot/pull/14219 Bumps `lucene.version` from 9.11.1 to 10.0.0. Updates `org.apache.lucene:lucene-backward-codecs` from 9.11.1 to 10.0.0 Updates `org.apache.lucene:lucene-core` from 9.11.1 to 10.0.0