dinoocch commented on PR #14214: URL: https://github.com/apache/pinot/pull/14214#issuecomment-2412190761
> Thanks for debugging this! Since this piece of code is borrowed from Helix GroupCommit.java, can you help also check if Helix has the same issue? This might explain https://github.com/apache/helix/issues/2309 I think the helix code linked in the original pr perhaps has a different, related issue -- https://github.com/apache/helix/blob/5b1a036bc11a893980ece40872feead3472f98d9/helix-core/src/main/java/org/apache/helix/GroupCommit.java#L158 ```java success = accessor.set(mergedKey, merged, options); ``` I guess this is most likely using `ZkBaseDataAccessor`, which set is: ```java @Override public boolean set(String path, T record, int options) { return set(path, record, -1, options); } ``` `-1` implies to ignore the version, so I do think this _could_ cause the behavior of lost updates. *** There's also this class [HelixGroupCommit](https://github.com/apache/helix/blob/5b1a036bc11a893980ece40872feead3472f98d9/helix-core/src/main/java/org/apache/helix/manager/zk/HelixGroupCommit.java#L35) This [seems ](https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/manager/zk/HelixGroupCommit.java#L130) to do everything correctly so far as I can tell. Since this class is much more recently modified, I'm assuming it is the one that is used in Helix? But don't know really without investigating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
