Re: [PR] [Spark Connector] Write support for creating Pinot segments [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13748: URL: https://github.com/apache/pinot/pull/13748#discussion_r1735513723 ## pinot-connectors/pinot-spark-3-connector/src/main/scala/org/apache/pinot/connector/spark/v3/datasource/PinotBufferedRecordReader.scala: ## @@ -0,0 +1,68 @@ +/**

Re: [PR] [Spark Connector] Write support for creating Pinot segments [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13748: URL: https://github.com/apache/pinot/pull/13748#discussion_r1735509788 ## pinot-connectors/pinot-spark-3-connector/src/main/scala/org/apache/pinot/connector/spark/v3/datasource/PinotDataWriter.scala: ## @@ -0,0 +1,246 @@ +/** + * Lice

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735456588 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -475,6 +477,7 @@ private void writeMet

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735411187 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/Series.java: ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735411439 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/PinotTimeSeriesConfigs.java: ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache S

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735408227 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/SeriesBlock.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735403159 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/SeriesBlock.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735400036 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -475,6 +477,7 @@ private void writ

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
ankitsultana commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735398596 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxSeriesBuilder.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to th

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735398176 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -475,6 +477,7 @@ private void writ

(pinot) branch master updated: UI Load time Improvement API Fixes #13278 (#13296)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c662e43b5b UI Load time Improvement API Fixes #13

Re: [I] Pinot UI load time improvements [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang closed issue #13278: Pinot UI load time improvements URL: https://github.com/apache/pinot/issues/13278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13296: URL: https://github.com/apache/pinot/pull/13296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735395071 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -66,6 +67,7 @@ public static class Cluster { public static final String GET_TABLE_C

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735369202 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxSeriesBuilder.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Ap

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735365778 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/SeriesBlock.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735364202 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/SeriesBlock.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735362768 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/Series.java: ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foun

Re: [I] No error logged when broker becomes unresponsive due to Netty transport issue [pinot]

2024-08-28 Thread via GitHub
tsafacjo commented on issue #6597: URL: https://github.com/apache/pinot/issues/6597#issuecomment-2316333707 I will pick it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735323449 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/RangeTimeSeriesRequest.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735321096 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/PinotTimeSeriesConfigs.java: ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-08-28 Thread via GitHub
chenboat commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1735320747 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/PinotTimeSeriesConfigs.java: ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Softw

(pinot) branch master updated: Enable `noRawDataForTextIndex` for the mutable segment when re-use mutable index is enabled (#13776)

2024-08-28 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 957a1cc058 Enable `noRawDataForTextIndex` for t

Re: [PR] Enable `noRawDataForTextIndex` for the mutable segment when re-use mutable index is enabled [pinot]

2024-08-28 Thread via GitHub
chenboat merged PR #13776: URL: https://github.com/apache/pinot/pull/13776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735232819 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -116,6 +118,8 @@ public static class Table { public static final String GET_CONTROLLE

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735210140 ## pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java: ## @@ -38,8 +38,8 @@ public class CrcUtilsTest { private static final File INDEX_DIR = ne

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735203149 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java: ## @@ -87,6 +98,58 @@ public FieldType getFieldType() { @Override public String toS

Re: [I] Pinot not ingesting realtime data from Apache Pulsar [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on issue #13880: URL: https://github.com/apache/pinot/issues/13880#issuecomment-2316100964 Do you have access to the server log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735188842 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -606,15 +598,10 @@ public static void

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735183987 ## pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java: ## @@ -38,8 +38,8 @@ public class CrcUtilsTest { private static final File INDEX_DIR

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735180689 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -66,6 +67,7 @@ public static class Cluster { public static final String GET_TABLE_C

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735178794 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -116,6 +118,8 @@ public static class Table { public static final String GET_CONTROL

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735178319 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -58,6 +58,7 @@ public static class Cluster { public static final String GET_RUNNING

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735177330 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java: ## @@ -87,6 +98,58 @@ public FieldType getFieldType() { @Override public String toS

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735176926 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java: ## @@ -60,18 +65,24 @@ public ComplexFieldSpec() { _childFieldSpecs = new HashMap<>();

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1735175260 ## pinot-spi/src/test/java/org/apache/pinot/spi/data/SchemaInfoTest.java: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735174694 ## pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java: ## @@ -38,8 +38,8 @@ public class CrcUtilsTest { private static final File INDEX_DIR = ne

(pinot) branch master updated: #12117 Support for Server & Controller API to check for Segments reload of a table in servers (#13789)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ae97265d86 #12117 Support for Server & Controller

Re: [PR] #12117 Support for Server & Controller API to check for Segments reload of a table in servers [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13789: URL: https://github.com/apache/pinot/pull/13789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13905: URL: https://github.com/apache/pinot/pull/13905#discussion_r1735157736 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java: ## @@ -60,18 +65,24 @@ public ComplexFieldSpec() { _childFieldSpecs = new HashMap<

(pinot) branch master updated: Use argument type to lookup function for literal only query (#13673)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f8de958174 Use argument type to lookup function f

Re: [PR] Use argument type to lookup function for literal only query [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13673: URL: https://github.com/apache/pinot/pull/13673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
codecov-commenter commented on PR #13905: URL: https://github.com/apache/pinot/pull/13905#issuecomment-2315936004 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13905?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Use argument type to lookup function for literal only query [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on PR #13673: URL: https://github.com/apache/pinot/pull/13673#issuecomment-2315905635 > Question: This PR modifies the way functions are resolved, but do not change semantics because right now we don't have overload functions right? ie we have a single `sum` function

Re: [PR] Use argument type to lookup function for literal only query [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang commented on code in PR #13673: URL: https://github.com/apache/pinot/pull/13673#discussion_r1735050689 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -1510,87 +1511,30 @@ private BrokerResponseNat

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 deleted (was d7dc792773)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 in repository https://gitbox.apache.org/repos/asf/pinot.git was d7dc792773 Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14 The r

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13899: URL: https://github.com/apache/pinot/pull/13899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14 (#13899)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ca7fafd8db Bump software.amazon.awssdk:bom from 2

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 updated (282a97d434 -> d7dc792773)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 282a97d434 Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14

(pinot) branch dependabot/maven/com.azure-azure-sdk-bom-1.2.27 deleted (was e94bd9ec20)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.27 in repository https://gitbox.apache.org/repos/asf/pinot.git was e94bd9ec20 Bump com.azure:azure-sdk-bom from 1.2.26 to 1.2.27 The revisions t

(pinot) branch master updated: Bump com.azure:azure-sdk-bom from 1.2.26 to 1.2.27 (#13900)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d3e2598f16 Bump com.azure:azure-sdk-bom from 1.2.

Re: [PR] Bump com.azure:azure-sdk-bom from 1.2.26 to 1.2.27 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13900: URL: https://github.com/apache/pinot/pull/13900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.4 deleted (was b65c5001c7)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.4 in repository https://gitbox.apache.org/repos/asf/pinot.git was b65c5001c7 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.4 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] commented on PR #13904: URL: https://github.com/apache/pinot/pull/13904#issuecomment-2315881730 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.4 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang closed pull request #13904: Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.4 URL: https://github.com/apache/pinot/pull/13904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(pinot) branch dependabot/maven/kafka2.version-3.8.0 deleted (was 898e870fb9)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kafka2.version-3.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 898e870fb9 Bump kafka2.version from 2.8.2 to 3.8.0 The revisions that were on this

Re: [PR] Bump kafka2.version from 2.8.2 to 3.8.0 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] commented on PR #13901: URL: https://github.com/apache/pinot/pull/13901#issuecomment-2315878110 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump kafka2.version from 2.8.2 to 3.8.0 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang closed pull request #13901: Bump kafka2.version from 2.8.2 to 3.8.0 URL: https://github.com/apache/pinot/pull/13901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.45.0 deleted (was 86d6bca1e3)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.45.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 86d6bca1e3 Bump com.google.cloud:libraries-bom from 26.44.0 to 26

Re: [PR] Bump com.google.cloud:libraries-bom from 26.44.0 to 26.45.0 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] commented on PR #13902: URL: https://github.com/apache/pinot/pull/13902#issuecomment-2315877512 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.google.cloud:libraries-bom from 26.44.0 to 26.45.0 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang closed pull request #13902: Bump com.google.cloud:libraries-bom from 26.44.0 to 26.45.0 URL: https://github.com/apache/pinot/pull/13902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(pinot) branch master updated: Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 (#13903)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fb7e081271 Bump org.mockito:mockito-core from 5.1

(pinot) branch dependabot/maven/org.mockito-mockito-core-5.13.0 deleted (was 1cfc06fc18)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.mockito-mockito-core-5.13.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1cfc06fc18 Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 The revision

Re: [PR] Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13903: URL: https://github.com/apache/pinot/pull/13903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Minor improvements to polymorphic scalar comparison functions for better backward compatibility [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13870: URL: https://github.com/apache/pinot/pull/13870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (198b6d80de -> 1f838efb21)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 198b6d80de Add missing dependencies to pinot-perf for JMH benchmarks (#13895) add 1f838efb21 Minor improvements t

(pinot) branch master updated: Add missing dependencies to pinot-perf for JMH benchmarks (#13895)

2024-08-28 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 198b6d80de Add missing dependencies to pinot-perf

Re: [PR] Add missing dependencies to pinot-perf for JMH benchmarks [pinot]

2024-08-28 Thread via GitHub
Jackie-Jiang merged PR #13895: URL: https://github.com/apache/pinot/pull/13895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-08-28 Thread via GitHub
gortiz commented on PR #13303: URL: https://github.com/apache/pinot/pull/13303#issuecomment-2315375714 I think I've applied most if not all suggestions. Please take a look to this PR again, as it would be great to be able to merge it soon. -- This is an automated message from the Apache G

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1734717024 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -104,4 +117,44 @@ public static Type fromOrdinal(int ordinal) { } }

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1734690882 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -36,13 +39,19 @@ public interface DataBlock { int getNumberOfRows(); + int

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1734685951 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java: ## @@ -426,168 +401,202 @@ public Map getExceptions() { return _errCodeToExcepti

[PR] Support ComplexFieldSpec in Schema and column metadata [pinot]

2024-08-28 Thread via GitHub
xiangfu0 opened a new pull request, #13905: URL: https://github.com/apache/pinot/pull/13905 - Fix all the ComplexFieldSpec serde in Schema class - Fix ComplexFieldSpec usage in ColumnMetadata -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1734590564 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java: ## @@ -426,168 +390,202 @@ public Map getExceptions() { return _errCodeToExcepti

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.4 created (now b65c5001c7)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at b65c5001c7 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

[PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.4 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13904: URL: https://github.com/apache/pinot/pull/13904 Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.3 to 4.27.4. Commits See full diff in https://github.com/protocolbuffers/protobuf/

(pinot) branch dependabot/maven/org.mockito-mockito-core-5.13.0 created (now 1cfc06fc18)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.mockito-mockito-core-5.13.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1cfc06fc18 Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 No new r

[PR] Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13903: URL: https://github.com/apache/pinot/pull/13903 Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.12.0 to 5.13.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockit

[PR] Bump kafka2.version from 2.8.2 to 3.8.0 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13901: URL: https://github.com/apache/pinot/pull/13901 Bumps `kafka2.version` from 2.8.2 to 3.8.0. Updates `org.apache.kafka:kafka-clients` from 2.8.2 to 3.8.0 Updates `org.apache.kafka:kafka_2.12` from 2.8.2 to 3.8.0 Dependabot

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.45.0 created (now 86d6bca1e3)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.45.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 86d6bca1e3 Bump com.google.cloud:libraries-bom from 26.44.0 to 26

[PR] Bump com.google.cloud:libraries-bom from 26.44.0 to 26.45.0 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13902: URL: https://github.com/apache/pinot/pull/13902 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.44.0 to 26.45.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bom/

(pinot) branch dependabot/maven/kafka2.version-3.8.0 created (now 898e870fb9)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kafka2.version-3.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 898e870fb9 Bump kafka2.version from 2.8.2 to 3.8.0 No new revisions were added by t

[PR] Bump com.azure:azure-sdk-bom from 1.2.26 to 1.2.27 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13900: URL: https://github.com/apache/pinot/pull/13900 Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java) from 1.2.26 to 1.2.27. Release notes Sourced from https://github.com/azure/azure-sdk-for-java/releases";>c

(pinot) branch dependabot/maven/com.azure-azure-sdk-bom-1.2.27 created (now e94bd9ec20)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.27 in repository https://gitbox.apache.org/repos/asf/pinot.git at e94bd9ec20 Bump com.azure:azure-sdk-bom from 1.2.26 to 1.2.27 No new rev

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 created (now 282a97d434)

2024-08-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.14 in repository https://gitbox.apache.org/repos/asf/pinot.git at 282a97d434 Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14 N

[PR] Bump software.amazon.awssdk:bom from 2.27.13 to 2.27.14 [pinot]

2024-08-28 Thread via GitHub
dependabot[bot] opened a new pull request, #13899: URL: https://github.com/apache/pinot/pull/13899 Bumps software.amazon.awssdk:bom from 2.27.13 to 2.27.14. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

Re: [I] SIGSEGV error when creating inverted index in MV column from large parquet files [pinot]

2024-08-28 Thread via GitHub
gortiz commented on issue #12286: URL: https://github.com/apache/pinot/issues/12286#issuecomment-2314997416 Larray can be used to create buffers larger than >2GBs, but Larray is not maintained and not safe (see more in https://github.com/apache/pinot/issues/12810). With not safe I mean that

Re: [PR] RealtimeSegmentConverter was using incorrect schema [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13877: URL: https://github.com/apache/pinot/pull/13877#discussion_r1734446538 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java: ## @@ -526,6 +544,14 @@ public SchemaBuilder() { _schema = new Schema(); } +public st

Re: [PR] RealtimeSegmentConverter was using incorrect schema [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13877: URL: https://github.com/apache/pinot/pull/13877#discussion_r173992 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java: ## @@ -352,6 +352,24 @@ public TreeSet getPhysicalColumnNames() { return physicalColumnNames; }

Re: [PR] Log nullable columns on creation [pinot]

2024-08-28 Thread via GitHub
gortiz merged PR #13868: URL: https://github.com/apache/pinot/pull/13868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

(pinot) branch master updated: Log nullable columns on creation (#13868)

2024-08-28 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1702ea2d06 Log nullable columns on creation (#138

Re: [PR] Improve column null handling [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13839: URL: https://github.com/apache/pinot/pull/13839#discussion_r1734337662 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -1002,7 +1002,8 @@ static void validatePartialUpsertStrategies(Tab

Re: [PR] Improve column null handling [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13839: URL: https://github.com/apache/pinot/pull/13839#discussion_r1734331360 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java: ## @@ -95,7 +95,8 @@ public SegmentMapper(List recordReaderFileConfigs,

Re: [PR] Improve column null handling [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13839: URL: https://github.com/apache/pinot/pull/13839#discussion_r1734327782 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -309,7 +309,11 @@ public void deleteSegmentFile() { pri

Re: [PR] Improve null handling performance for nullable single input aggregation functions [pinot]

2024-08-28 Thread via GitHub
yashmayya commented on PR #13791: URL: https://github.com/apache/pinot/pull/13791#issuecomment-2314766321 Attaching some CPU profiles from local runs of the new sum query benchmark here: [old-sum-nullhandling-false-nullperiod-128-summary-cpu.txt](https://github.com/user-attachments/f

Re: [PR] Improve column null handling [pinot]

2024-08-28 Thread via GitHub
gortiz commented on PR #13839: URL: https://github.com/apache/pinot/pull/13839#issuecomment-2314763284 > I think we should consider changing the table level null handling to be enabled by default I agree, but we should do that in another PR and also change the documentation. -- Th

Re: [PR] Improve null handling performance for nullable single input aggregation functions [pinot]

2024-08-28 Thread via GitHub
yashmayya commented on PR #13791: URL: https://github.com/apache/pinot/pull/13791#issuecomment-2314745025 @gortiz thanks for the feedback, I've added a query level benchmark for `SUM` largely borrowed from your unmerged PR - https://github.com/apache/pinot/pull/12354. I was getting much wor

Re: [I] Pinot not ingesting realtime data from Apache Pulsar [pinot]

2024-08-28 Thread via GitHub
pramsri commented on issue #13880: URL: https://github.com/apache/pinot/issues/13880#issuecomment-2314722022 I see, thanks. If I use Pinot 1.2 and Pulsar 3.3, but the segment is not created even though the table is saved (I got the 500 error code when I checked for segment info), what other

Re: [PR] Use argument type to lookup function for literal only query [pinot]

2024-08-28 Thread via GitHub
gortiz commented on PR #13673: URL: https://github.com/apache/pinot/pull/13673#issuecomment-2314702072 Question: This PR modifies the way functions are resolved, but do not change semantics because right now we don't have overload functions right? ie we have a single `sum` function for doub

Re: [PR] Use argument type to lookup function for literal only query [pinot]

2024-08-28 Thread via GitHub
gortiz commented on code in PR #13673: URL: https://github.com/apache/pinot/pull/13673#discussion_r1734235460 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -1510,87 +1511,30 @@ private BrokerResponseNative p

  1   2   >