gortiz commented on code in PR #13839:
URL: https://github.com/apache/pinot/pull/13839#discussion_r1734331360
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java:
##########
@@ -95,7 +95,8 @@ public SegmentMapper(List<RecordReaderFileConfig>
recordReaderFileConfigs,
tableConfig.getIndexingConfig().getSortedColumn());
_fieldSpecs = pair.getLeft();
_numSortFields = pair.getRight();
- _includeNullFields =
tableConfig.getIndexingConfig().isNullHandlingEnabled();
+ _includeNullFields =
+ schema.isEnableColumnBasedNullHandling() ||
tableConfig.getIndexingConfig().isNullHandlingEnabled();
Review Comment:
What will happen is that we are going to create a null vector for these not
nullable columns. That null vector will be ignored at query time. That is not
problematic because it is happening right now. Imagine we have a table that is
nullable and then we change it to be not nullable, then already committed
segments will have that null vector column but the query engine does just
ignore that vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
