Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-22 Thread via GitHub
ankitsultana commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1728177518 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java: ## @@ -37,17 +54,33 @@ * send by the sender of the sender/rec

Re: [PR] add metric for time retention failing due to end time [pinot]

2024-08-22 Thread via GitHub
codecov-commenter commented on PR #13879: URL: https://github.com/apache/pinot/pull/13879#issuecomment-2306071718 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13879?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.10 deleted (was 01ae8aad39)

2024-08-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.10 in repository https://gitbox.apache.org/repos/asf/pinot.git was 01ae8aad39 Bump software.amazon.awssdk:bom from 2.27.9 to 2.27.10 The re

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.9 to 2.27.10 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang merged PR #13876: URL: https://github.com/apache/pinot/pull/13876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.27.1 deleted (was 82e08cdbe5)

2024-08-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 82e08cdbe5 Bump org.apache.commons:commons-compress from 1.27.0 t

Re: [PR] Bump org.apache.commons:commons-compress from 1.27.0 to 1.27.1 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang merged PR #13875: URL: https://github.com/apache/pinot/pull/13875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (966101d14d -> 8552d3d72f)

2024-08-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 966101d14d Bump org.apache.commons:commons-compress from 1.27.0 to 1.27.1 (#13875) add 8552d3d72f Bump software.a

(pinot) branch master updated (6d64650e7c -> 966101d14d)

2024-08-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6d64650e7c [Dependency] Cleanup unnecessary dependencies and exclusions (#13832) add 966101d14d Bump org.apache.c

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-project-info-reports-plugin-3.7.0 deleted (was 5a1b1f6695)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-project-info-reports-plugin-3.7.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5a1b1f6695 Bump org.apache.maven.plugi

Re: [PR] Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.6.2 to 3.7.0 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] commented on PR #13874: URL: https://github.com/apache/pinot/pull/13874#issuecomment-2305999195 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.0 deleted (was a7ce99eaee)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was a7ce99eaee Bump org.apache.maven.plugins:maven-de

Re: [PR] Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.6.2 to 3.7.0 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang closed pull request #13874: Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.6.2 to 3.7.0 URL: https://github.com/apache/pinot/pull/13874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] commented on PR #13872: URL: https://github.com/apache/pinot/pull/13872#issuecomment-2305999026 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang closed pull request #13872: Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 URL: https://github.com/apache/pinot/pull/13872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

(pinot) branch dependabot/maven/kotlin.stdlib.version-2.0.20 deleted (was 079908fd72)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kotlin.stdlib.version-2.0.20 in repository https://gitbox.apache.org/repos/asf/pinot.git was 079908fd72 Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 The revisions

Re: [PR] Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] commented on PR #13873: URL: https://github.com/apache/pinot/pull/13873#issuecomment-2305998738 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang closed pull request #13873: Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 URL: https://github.com/apache/pinot/pull/13873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Dependency] Cleanup maven plugin versions [pinot]

2024-08-22 Thread via GitHub
codecov-commenter commented on PR #13878: URL: https://github.com/apache/pinot/pull/13878#issuecomment-2305893311 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13878?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] Support Kafka 3 [pinot]

2024-08-22 Thread via GitHub
abhioncbr commented on issue #13806: URL: https://github.com/apache/pinot/issues/13806#issuecomment-2305845799 Let me give it a try. Assigning to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-22 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1727910795 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/TableViewsTest.java: ## @@ -161,6 +167,55 @@ public void testHybridTableState(String state) as

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-22 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1727818501 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/SchemaInfo.java: ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-08-22 Thread via GitHub
Jackie-Jiang commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1727768297 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/SchemaInfo.java: ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [I] SIGSEGV error when creating inverted index in MV column from large parquet files [pinot]

2024-08-22 Thread via GitHub
dd-willgan commented on issue #12286: URL: https://github.com/apache/pinot/issues/12286#issuecomment-2305568237 Hey @gortiz , why would using > 2GB LArray buffers be an issue? Looking at their repo https://github.com/xerial/larray it seems like the first thing they advertise is that > 2GB b

Re: [I] Has pinot supported subquery? [pinot]

2024-08-22 Thread via GitHub
donPain commented on issue #10872: URL: https://github.com/apache/pinot/issues/10872#issuecomment-2305510479 👀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] Reduce Size of Pinot Release Binary [pinot]

2024-08-22 Thread via GitHub
hpvd commented on issue #13726: URL: https://github.com/apache/pinot/issues/13726#issuecomment-2304623834 same direction I like this work of removing stuff: https://github.com/apache/pinot/commit/6d64650e7c210456a890ee6f9a6eaf05a7ab557b -- This is an automated message from the Apache G

Re: [PR] RealtimeSegmentConverter was using incorrect schema [pinot]

2024-08-22 Thread via GitHub
codecov-commenter commented on PR #13877: URL: https://github.com/apache/pinot/pull/13877#issuecomment-2304548080 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13877?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add Segment Relocator Rebalance Configs to Controller Conf [pinot]

2024-08-22 Thread via GitHub
suddendust commented on code in PR #13863: URL: https://github.com/apache/pinot/pull/13863#discussion_r1726923462 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java: ## @@ -169,6 +179,10 @@ private void rebalanceTable(String

Re: [PR] Log nullable columns on creation [pinot]

2024-08-22 Thread via GitHub
gortiz commented on PR #13868: URL: https://github.com/apache/pinot/pull/13868#issuecomment-2304489880 > Not sure if this can potentially flood log for wide tables. Should we consider logging all nullable columns as one line? I don't think so, as explained in the description we alread

[PR] RealtimeSegmentConverter was using incorrect schema [pinot]

2024-08-22 Thread via GitHub
gortiz opened a new pull request, #13877: URL: https://github.com/apache/pinot/pull/13877 `RealtimeSegmentConverter` cannot use the realtime segment because it contains some virtual columns. For example the `$segmentName` and `$docId` will be different in the sealed segment. Therefore `Real

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.10 created (now 01ae8aad39)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.10 in repository https://gitbox.apache.org/repos/asf/pinot.git at 01ae8aad39 Bump software.amazon.awssdk:bom from 2.27.9 to 2.27.10 No

[PR] Bump software.amazon.awssdk:bom from 2.27.9 to 2.27.10 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] opened a new pull request, #13876: URL: https://github.com/apache/pinot/pull/13876 Bumps software.amazon.awssdk:bom from 2.27.9 to 2.27.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwar

[PR] Bump org.apache.commons:commons-compress from 1.27.0 to 1.27.1 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] opened a new pull request, #13875: URL: https://github.com/apache/pinot/pull/13875 Bumps org.apache.commons:commons-compress from 1.27.0 to 1.27.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

[PR] Bump org.apache.maven.plugins:maven-project-info-reports-plugin from 3.6.2 to 3.7.0 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] opened a new pull request, #13874: URL: https://github.com/apache/pinot/pull/13874 Bumps [org.apache.maven.plugins:maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.6.2 to 3.7.0. Commits https://github.com/ap

[PR] Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] opened a new pull request, #13873: URL: https://github.com/apache/pinot/pull/13873 Bumps `kotlin.stdlib.version` from 2.0.10 to 2.0.20. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 2.0.10 to 2.0.20 Release notes Sourced from https://github.com/JetBrains/

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.27.1 created (now 82e08cdbe5)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 82e08cdbe5 Bump org.apache.commons:commons-compress from 1.27

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-project-info-reports-plugin-3.7.0 created (now 5a1b1f6695)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-project-info-reports-plugin-3.7.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 5a1b1f6695 Bump org.apache.maven.plugi

(pinot) branch dependabot/maven/kotlin.stdlib.version-2.0.20 created (now 079908fd72)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kotlin.stdlib.version-2.0.20 in repository https://gitbox.apache.org/repos/asf/pinot.git at 079908fd72 Bump kotlin.stdlib.version from 2.0.10 to 2.0.20 No new revisio

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.0 created (now a7ce99eaee)

2024-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at a7ce99eaee Bump org.apache.maven.plugins:maven-de

[PR] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 [pinot]

2024-08-22 Thread via GitHub
dependabot[bot] opened a new pull request, #13872: URL: https://github.com/apache/pinot/pull/13872 Bumps [org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.7.1 to 3.8.0. Commits https://github.com/apache/maven-dependenc

Re: [PR] Added support to upload segments in batch mode with METADATA upload type [pinot]

2024-08-22 Thread via GitHub
swaminathanmanish commented on code in PR #13646: URL: https://github.com/apache/pinot/pull/13646#discussion_r1726827037 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java: ## @@ -359,6 +368,150 @@ public static void sendSegmentUriAn

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-08-22 Thread via GitHub
tibrewalpratik17 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1726752536 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -60,6 +63,11 @@ public class PinotS

Re: [I] Aggregation filter is being pushed down in a way it breaks SQL semantics [pinot]

2024-08-22 Thread via GitHub
bziobrowski commented on issue #12647: URL: https://github.com/apache/pinot/issues/12647#issuecomment-2304144849 Thanks @gortiz . From what I see the issue is not fixed in latest master . You can see it if you run and compare ```sql select AirTime, count(*) filter ( where AirTime

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-08-22 Thread via GitHub
tibrewalpratik17 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1726595303 ## pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfigProperties.java: ## @@ -43,7 +43,9 @@ private BatchConfigProperties() { public st

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-08-22 Thread via GitHub
tibrewalpratik17 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1726576070 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -60,13 +63,19 @@ public class Pinot

[PR] [#13862] add --host option to pinot-admin.sh StartKafka [pinot]

2024-08-22 Thread via GitHub
yjqg opened a new pull request, #13871: URL: https://github.com/apache/pinot/pull/13871 Fixes #13862. Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` (*) Other labels to consider: - `too

Re: [PR] Binary Workload Scheduler for constrained execution of a set of queries [pinot]

2024-08-22 Thread via GitHub
siddharthteotia commented on code in PR #13847: URL: https://github.com/apache/pinot/pull/13847#discussion_r1726464726 ## pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/SecondaryWorkloadQueue.java: ## @@ -0,0 +1,167 @@ +/** + * Licensed to the Apache Software Fou