siddharthteotia commented on code in PR #13847: URL: https://github.com/apache/pinot/pull/13847#discussion_r1726464726
########## pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/SecondaryWorkloadQueue.java: ########## @@ -0,0 +1,167 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.scheduler; + + +import com.google.common.base.Preconditions; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.locks.Condition; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; +import javax.annotation.Nullable; +import org.apache.pinot.core.query.request.ServerQueryRequest; +import org.apache.pinot.core.query.scheduler.fcfs.FCFSSchedulerGroup; +import org.apache.pinot.core.query.scheduler.resources.ResourceManager; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Queue to maintain secondary workload queries. Used by the BinaryWorkloadScheduler. + */ +public class SecondaryWorkloadQueue { + private static final Logger LOGGER = LoggerFactory.getLogger(SecondaryWorkloadQueue.class); + private static final String SECONDARY_WORKLOAD_GROUP_NAME = "Secondary"; + + public static final String SECONDARY_QUEUE_QUERY_TIMEOUT = "binarywlm.secondaryQueueQueryTimeout"; + private static final int DEFAULT_SECONDARY_QUEUE_QUERY_TIMEOUT_SEC = 40; + + public static final String MAX_PENDING_SECONDARY_QUERIES = "binarywlm.maxPendingSecondaryQueries"; + private static final int DEFAULT_MAX_PENDING_SECONDARY_QUERIES = 20; + + public static final String QUEUE_WAKEUP_MS = "binarywlm.queueWakeupMs"; + private static final int DEFAULT_WAKEUP_MS = 1; + + private static int _wakeUpTimeMs; + private final int _maxPendingPerGroup; + + private final SchedulerGroup _schedulerGroup; + + private final Lock _queueLock = new ReentrantLock(); + private final Condition _queryReaderCondition = _queueLock.newCondition(); + private final ResourceManager _resourceManager; + private final int _queryDeadlineMs; + + public SecondaryWorkloadQueue(PinotConfiguration config, ResourceManager resourceManager) { + Preconditions.checkNotNull(config); + Preconditions.checkNotNull(resourceManager); + + _queryDeadlineMs = + config.getProperty(SECONDARY_QUEUE_QUERY_TIMEOUT, DEFAULT_SECONDARY_QUEUE_QUERY_TIMEOUT_SEC) * 1000; + _wakeUpTimeMs = config.getProperty(QUEUE_WAKEUP_MS, DEFAULT_WAKEUP_MS); + _maxPendingPerGroup = config.getProperty(MAX_PENDING_SECONDARY_QUERIES, DEFAULT_MAX_PENDING_SECONDARY_QUERIES); + LOGGER.info("queryDeadlineMs={}, wakeupTimeMs={},maxPendingPerGroup={}", _queryDeadlineMs, _wakeUpTimeMs, + _maxPendingPerGroup); + _schedulerGroup = new FCFSSchedulerGroup(SECONDARY_WORKLOAD_GROUP_NAME); + _resourceManager = resourceManager; + } + + /** + * Adds a query to the secondary workload queue. + * @param query + * @throws OutOfCapacityException + */ + public void put(SchedulerQueryContext query) + throws OutOfCapacityException { + Preconditions.checkNotNull(query); + _queueLock.lock(); + try { + checkSchedulerGroupCapacity(query); + query.setSchedulerGroupContext(_schedulerGroup); + _schedulerGroup.addLast(query); + _queryReaderCondition.signal(); + } finally { + _queueLock.unlock(); + } + } + + /** + * Blocking call to read the next query + * @return + */ + @Nullable + public SchedulerQueryContext take() { + _queueLock.lock(); + try { + while (true) { + SchedulerQueryContext schedulerQueryContext; + while ((schedulerQueryContext = takeNextInternal()) == null) { + try { + _queryReaderCondition.await(_wakeUpTimeMs, TimeUnit.MILLISECONDS); + } catch (InterruptedException e) { + return null; + } + } + return schedulerQueryContext; + } + } finally { + _queueLock.unlock(); + } + } + + public List<SchedulerQueryContext> drain() { + List<SchedulerQueryContext> pending = new ArrayList<>(); + _queueLock.lock(); + try { + while (!_schedulerGroup.isEmpty()) { + pending.add(_schedulerGroup.removeFirst()); + } + } finally { + _queueLock.unlock(); + } + return pending; + } + + private SchedulerQueryContext takeNextInternal() { + long startTimeMs = System.currentTimeMillis(); + long deadlineEpochMillis = startTimeMs - _queryDeadlineMs; + + _schedulerGroup.trimExpired(deadlineEpochMillis); + if (_schedulerGroup.isEmpty() || !_resourceManager.canSchedule(_schedulerGroup)) { + return null; + } + + if (LOGGER.isDebugEnabled()) { Review Comment: Is this block really needed ? I don't think there is a need to check for if condition. Based on the level, it should automatically know when to log or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
