Re: [PR] Merge RecordEnricher into RecordTransformer [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang commented on code in PR #13704: URL: https://github.com/apache/pinot/pull/13704#discussion_r1712443355 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/RecordEnricher.java: ## @@ -16,25 +16,21 @@ * specific language governing p

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 deleted (was 86f4ab5931)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 86f4ab5931 Exclude commons-logging The revisions that were on this b

(pinot) branch master updated: Bump com.google.cloud:libraries-bom from 26.43.0 to 26.44.0 (#13788)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 53fbf88027 Bump com.google.cloud:libraries-bom fr

Re: [PR] Bump com.google.cloud:libraries-bom from 26.43.0 to 26.44.0 [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13788: URL: https://github.com/apache/pinot/pull/13788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

svn commit: r70776 - /dev/pinot/apache-pinot-1.2.0-rc1/

2024-08-09 Thread ankitsultana
Author: ankitsultana Date: Sat Aug 10 00:51:37 2024 New Revision: 70776 Log: Delete release-1.2.0-rc1 Removed: dev/pinot/apache-pinot-1.2.0-rc1/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1712425074 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes.java: ## @@ -0,0 +1,391

(pinot) branch release-1.2.0-rc updated (34ab49d1aa -> 6943c0c692)

2024-08-09 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a change to branch release-1.2.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard 34ab49d1aa [maven-release-plugin] prepare for next development iteration omit 60899d7b8e [maven-re

(pinot) 01/01: Fix filtered aggregate with ordering (#13784)

2024-08-09 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch release-1.2.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit 6943c0c692a5bc2512f96da5657d6d830ed050c8 Author: Xiaotian (Jackie) Jiang <1751+jackie-ji...@users.nore

Re: [PR] Add multi stream ingestion support [pinot]

2024-08-09 Thread via GitHub
codecov-commenter commented on PR #13790: URL: https://github.com/apache/pinot/pull/13790#issuecomment-2278905762 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13790?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade Helix dependency to 1.4.0 [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang commented on PR #13486: URL: https://github.com/apache/pinot/pull/13486#issuecomment-2278900360 @siddharthteotia @jackjlli Any update on the internally testing? Is there new introduced behavior change in Helix? A lot of tests are failing -- This is an automated message from t

[PR] Add multi stream ingestion support [pinot]

2024-08-09 Thread via GitHub
lnbest0707-uber opened a new pull request, #13790: URL: https://github.com/apache/pinot/pull/13790 `feature` Reference: https://github.com/apache/pinot/issues/13780 [Design Doc](https://docs.google.com/document/d/1Er2Tmtl5Pgwdapn5iOJ5qlCDU_2P67YMdpdsmL36MCk/edit?usp=sharing) Pleas

Re: [PR] add metadata ttl field to DedupConfig [pinot]

2024-08-09 Thread via GitHub
zhtaoxiang commented on code in PR #13636: URL: https://github.com/apache/pinot/pull/13636#discussion_r1712305564 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java: ## @@ -19,105 +19,80 @@ package org.apach

Re: [PR] #12117 Support for Server API to check for Segments reload for a particular table in a server [pinot]

2024-08-09 Thread via GitHub
codecov-commenter commented on PR #13789: URL: https://github.com/apache/pinot/pull/13789#issuecomment-2278834545 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13789?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] add metadata ttl field to DedupConfig [pinot]

2024-08-09 Thread via GitHub
zhtaoxiang commented on code in PR #13636: URL: https://github.com/apache/pinot/pull/13636#discussion_r1712242432 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java: ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apach

Re: [I] Increase code coverage [pinot]

2024-08-09 Thread via GitHub
jackjlli commented on issue #5150: URL: https://github.com/apache/pinot/issues/5150#issuecomment-2278776166 Thanks @visrahane for the notice. The link is just updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] #12117 Support for Server API to check for Segments reloaded for a particular table [pinot]

2024-08-09 Thread via GitHub
deepthi912 opened a new pull request, #13789: URL: https://github.com/apache/pinot/pull/13789 Corresponding Issue: https://github.com/apache/pinot/issues/12117 This PR just adds a new API on the server which returns server id and boolean result(to check if any segments need to be reloa

Re: [PR] Add more unit test for `AbstractMetricsTest` [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on PR #13697: URL: https://github.com/apache/pinot/pull/13697#issuecomment-2278755466 hey @dttung2905 thanks for this change! Do you know what is the coverage improvement on `AbstractMetrics` class post these UTs? -- This is an automated message from the Apache

Re: [PR] Add more unit test for `AbstractMetricsTest` [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on code in PR #13697: URL: https://github.com/apache/pinot/pull/13697#discussion_r1712200400 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/AbstractMetricsTest.java: ## @@ -48,4 +49,63 @@ public void testAddOrUpdateGauge() { control

Re: [PR] Add more unit test for `AbstractMetricsTest` [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on code in PR #13697: URL: https://github.com/apache/pinot/pull/13697#discussion_r1712201044 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/AbstractMetricsTest.java: ## @@ -48,4 +49,63 @@ public void testAddOrUpdateGauge() { control

Re: [I] Increase code coverage [pinot]

2024-08-09 Thread via GitHub
visrahane commented on issue #5150: URL: https://github.com/apache/pinot/issues/5150#issuecomment-2278736930 The code coverage link in the above comment is broken. Can someone please add the updated link with current code coverage? -- This is an automated message from the Apache Git Servi

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 updated (685408d0ab -> 86f4ab5931)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 685408d0ab Bump com.google.cloud:libraries-bom from 26.43.0 to 26.44.

(pinot) branch master updated (9c74059dfb -> 39c98fe665)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9c74059dfb Bump org.apache.commons:commons-compress from 1.26.2 to 1.27.0 (#13786) add 39c98fe665 Bump software.a

(pinot) branch dependabot/maven/slf4j.version-2.0.15 deleted (was 4e19da0cbd)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/slf4j.version-2.0.15 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4e19da0cbd Bump slf4j.version from 2.0.14 to 2.0.15 The revisions that were on this bra

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.27.0 deleted (was 667af52024)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.27.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 667af52024 Bump org.apache.commons:commons-compress from 1.26.2 t

Re: [PR] Bump slf4j.version from 2.0.14 to 2.0.15 [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13785: URL: https://github.com/apache/pinot/pull/13785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (b2e4987a70 -> b4ece8cc5d)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b2e4987a70 Fix filtered aggregate with ordering (#13784) add b4ece8cc5d Bump slf4j.version from 2.0.14 to 2.0.15 (

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.1 deleted (was 32ec58ac6f)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 32ec58ac6f Bump software.amazon.awssdk:bom from 2.27.0 to 2.27.1 The revi

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.0 to 2.27.1 [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13787: URL: https://github.com/apache/pinot/pull/13787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (b4ece8cc5d -> 9c74059dfb)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b4ece8cc5d Bump slf4j.version from 2.0.14 to 2.0.15 (#13785) add 9c74059dfb Bump org.apache.commons:commons-compre

Re: [PR] Bump org.apache.commons:commons-compress from 1.26.2 to 1.27.0 [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13786: URL: https://github.com/apache/pinot/pull/13786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (f141cd21d8 -> b2e4987a70)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from f141cd21d8 supporting additional headers (#13417) add b2e4987a70 Fix filtered aggregate with ordering (#13784) No

Re: [I] Inconsistent query results with count(*) and 1 or more "FILTER" expressions [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang closed issue #13749: Inconsistent query results with count(*) and 1 or more "FILTER" expressions URL: https://github.com/apache/pinot/issues/13749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Fix filtered aggregate with ordering [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13784: URL: https://github.com/apache/pinot/pull/13784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] supporting additional headers [pinot]

2024-08-09 Thread via GitHub
Jackie-Jiang merged PR #13417: URL: https://github.com/apache/pinot/pull/13417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: supporting additional headers (#13417)

2024-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f141cd21d8 supporting additional headers (#13417)

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1711825115 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java: ## @@ -83,8 +82,14 @@ public static TableUps

Re: [I] Using SIMD for dealing with json at speed [pinot]

2024-08-09 Thread via GitHub
hpvd commented on issue #13773: URL: https://github.com/apache/pinot/issues/13773#issuecomment-2278383552 I think this would be a multistep approach. We can look what is possible on https://simdjson.org/ and just pick one place in Pinot and give it a try. In the end we can utilize it in man

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1711817991 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java: ## @@ -66,6 +69,8 @@ private UpsertContext(TableConfig tableConf

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-08-09 Thread via GitHub
klsince commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1711771750 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java: ## @@ -66,6 +69,8 @@ private UpsertContext(TableConfig tableConfig, Schem

Re: [I] Support group-by without aggregation [pinot]

2024-08-09 Thread via GitHub
tarun11Mavani commented on issue #11923: URL: https://github.com/apache/pinot/issues/11923#issuecomment-2278056181 @tibrewalpratik17 please assign this to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Support group-by without aggregation [pinot]

2024-08-09 Thread via GitHub
tibrewalpratik17 commented on issue #11923: URL: https://github.com/apache/pinot/issues/11923#issuecomment-2278053902 Assigning this to @tarun11Mavani as he is helping us on this! This has been a tech-debt for us from quite some time as discussed in this issue - https://github.com/apache

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 created (now 685408d0ab)

2024-08-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.44.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 685408d0ab Bump com.google.cloud:libraries-bom from 26.43.0 to 26

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.27.1 created (now 32ec58ac6f)

2024-08-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 32ec58ac6f Bump software.amazon.awssdk:bom from 2.27.0 to 2.27.1 No n

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.27.0 created (now 667af52024)

2024-08-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.27.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 667af52024 Bump org.apache.commons:commons-compress from 1.26

[PR] Bump com.google.cloud:libraries-bom from 26.43.0 to 26.44.0 [pinot]

2024-08-09 Thread via GitHub
dependabot[bot] opened a new pull request, #13788: URL: https://github.com/apache/pinot/pull/13788 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.43.0 to 26.44.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bom/

[PR] Bump software.amazon.awssdk:bom from 2.27.0 to 2.27.1 [pinot]

2024-08-09 Thread via GitHub
dependabot[bot] opened a new pull request, #13787: URL: https://github.com/apache/pinot/pull/13787 Bumps software.amazon.awssdk:bom from 2.27.0 to 2.27.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software

[PR] Bump org.apache.commons:commons-compress from 1.26.2 to 1.27.0 [pinot]

2024-08-09 Thread via GitHub
dependabot[bot] opened a new pull request, #13786: URL: https://github.com/apache/pinot/pull/13786 Bumps org.apache.commons:commons-compress from 1.26.2 to 1.27.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

(pinot) branch dependabot/maven/slf4j.version-2.0.15 created (now 4e19da0cbd)

2024-08-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/slf4j.version-2.0.15 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4e19da0cbd Bump slf4j.version from 2.0.14 to 2.0.15 No new revisions were added by

[PR] Bump slf4j.version from 2.0.14 to 2.0.15 [pinot]

2024-08-09 Thread via GitHub
dependabot[bot] opened a new pull request, #13785: URL: https://github.com/apache/pinot/pull/13785 Bumps `slf4j.version` from 2.0.14 to 2.0.15. Updates `org.slf4j:jcl-over-slf4j` from 2.0.14 to 2.0.15 Updates `org.slf4j:slf4j-api` from 2.0.14 to 2.0.15 Dependabot will res

Re: [PR] Support madvise for MmapMemory [pinot]

2024-08-09 Thread via GitHub
gortiz commented on PR #13721: URL: https://github.com/apache/pinot/pull/13721#issuecomment-2277731329 I'm not an expert on this area, but it seems interesting to be able to tune the read ahead for specific use cases -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix filtered aggregate with ordering [pinot]

2024-08-09 Thread via GitHub
gortiz commented on code in PR #13784: URL: https://github.com/apache/pinot/pull/13784#discussion_r1711206027 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -3462,6 +3454,16 @@ public void testGroupByAggregat

Re: [PR] Fix filtered aggregate with ordering [pinot]

2024-08-09 Thread via GitHub
codecov-commenter commented on PR #13784: URL: https://github.com/apache/pinot/pull/13784#issuecomment-2277285859 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13784?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u