tibrewalpratik17 commented on code in PR #13347:
URL: https://github.com/apache/pinot/pull/13347#discussion_r1711825115
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java:
##########
@@ -83,8 +82,14 @@ public static TableUpsertMetadataManager create(TableConfig
tableConfig,
metadataManagerClass, tableNameWithType), e);
}
} else {
- LOGGER.info("Creating ConcurrentMapTableUpsertMetadataManager for table:
{}", tableNameWithType);
- metadataManager = new ConcurrentMapTableUpsertMetadataManager();
+ if (upsertConfig.isEnableConsistentDeletes()) {
Review Comment:
> hmm.. if metadataManagerClass is set, the else-branch is skipped, so the
check of the new feature flag is skipped too.
in that case, the metadata-manager-class implementation should take care of
using this feature flag and ensuring consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
