tibrewalpratik17 commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1711817991
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java: ########## @@ -66,6 +69,8 @@ private UpsertContext(TableConfig tableConfig, Schema schema, List<String> prima _consistencyMode = consistencyMode; _upsertViewRefreshIntervalMs = upsertViewRefreshIntervalMs; _tableIndexDir = tableIndexDir; + _dropOutOfOrderRecord = dropOutOfOrderRecord; Review Comment: this was added on purpose. we are using this in `#addRecord` method to see if we are adding an out-of-order event in the segment or not and accordingly update the distinct-segment-count value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org