gortiz commented on PR #13040:
URL: https://github.com/apache/pinot/pull/13040#issuecomment-2088064750
LGTM, but there are multiple tests failing, so I guess we would need to fix
something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gortiz commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1585949962
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,24 +84,22 @@ public BrokerResponse handleRequest(JsonNo
codecov-commenter commented on PR #13041:
URL: https://github.com/apache/pinot/pull/13041#issuecomment-2087938822
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13041?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
jadami10 opened a new pull request, #13041:
URL: https://github.com/apache/pinot/pull/13041
This is a `bugfix` for broker query dropped logs. The
`_droppedLogRateLimiter` rate is hardcoded to 1 so that you only log dropped
logs once per second. I imagine we wanted to log the `_logRateLimite
codecov-commenter commented on PR #13040:
URL: https://github.com/apache/pinot/pull/13040#issuecomment-2087894076
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13040?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
chenboat commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1585809421
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -48,21 +51,156 @@ public static
chenboat commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1585808811
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/com/google/protobuf/ProtobufInternalUtils.java:
##
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache So
chenboat commented on PR #12980:
URL: https://github.com/apache/pinot/pull/12980#issuecomment-2087882401
Can you link the overall design doc for this in the summary section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bf28a83958 Use more efficient variants of URLEnco
Jackie-Jiang merged PR #13030:
URL: https://github.com/apache/pinot/pull/13030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1585793958
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##
@@ -85,24 +84,22 @@ public BrokerResponse handleRequest(
Jackie-Jiang opened a new pull request, #13040:
URL: https://github.com/apache/pinot/pull/13040
- Cleanup the deprecated debug options, and old PQL related query options
- Fix the double query parsing in multi-stage engine
- Fix the inconsistent behavior when query parsing fails: do not
rseetham commented on issue #12679:
URL: https://github.com/apache/pinot/issues/12679#issuecomment-2087826413
@ankitsultana @deemoliu Could you take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
yashmayya commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1585766357
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##
@@ -574,7 +569,7 @@ public String forUpdateTagsValidation() {
Jackie-Jiang commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1585551149
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##
@@ -574,7 +569,7 @@ public String forUpdateTagsValidation() {
Bill-hbrhbr commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1585546015
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -108,10 +113,140 @@ private static List parseEntryAsStr
Jackie-Jiang merged PR #13017:
URL: https://github.com/apache/pinot/pull/13017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13018:
URL: https://github.com/apache/pinot/pull/13018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ea0c71b3c8 Bump org.scala-lang:scala-library from 2.11.11 to 2.11.12
and from 2.12.18 to 2.12.19 (#13034)
add f15
abhioncbr commented on issue #13038:
URL: https://github.com/apache/pinot/issues/13038#issuecomment-2087324785
seems like this [issue](https://github.com/apache/pinot/issues/12793) is
also the same.
Please assign it to me; I will give it a try to fix it. Thanks
--
This is an autom
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1585519508
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -168,13 +209,18 @@ public AbstractBuilder(TextIndexConfig other) {
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1585517738
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/CsvParser.java:
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Bill-hbrhbr commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1585512209
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -168,13 +209,18 @@ public AbstractBuilder(TextIndexConfig other) {
tibrewalpratik17 commented on PR #13036:
URL: https://github.com/apache/pinot/pull/13036#issuecomment-2087149505
> What kind of failures are these ? Are all these transient failures that
are likely to go away on retries?
Yes till now we have mostly seen transient failures. We use inte
swaminathanmanish commented on PR #13036:
URL: https://github.com/apache/pinot/pull/13036#issuecomment-2087081060
> We have intermittently seen issues in our clusters while creating
streamMessageDecoder. Stack trace:
>
> ```
> java.lang.RuntimeException: Caught exception while crea
rohityadav1993 commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585445055
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,12 @@ private void setMergedValue(GenericRo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 7413e993ee Upgrade s3mock to 2.17.0 (#13028)
add ea0c71b3c8 Bump org.scala-lang:scala-library from 2.11.11 to 2.11
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.scala-lang-scala-library-2.13.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 38e2c9081c Apply suggestions from code review
The revisions that were
Jackie-Jiang merged PR #13034:
URL: https://github.com/apache/pinot/pull/13034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 475708f14f Use try-with-resources to close file walk stream in
LocalPinotFS (#13029)
add 7413e993ee Upgrade s3moc
Jackie-Jiang merged PR #13028:
URL: https://github.com/apache/pinot/pull/13028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #12734:
URL: https://github.com/apache/pinot/issues/12734#issuecomment-2086769680
`TIMESTAMP` data type has implicit format of `-MM-dd HH:mm:ss.SSS` or
millis since epoch.
I think the confusion is coming from the fact that both `format` and
`granul
rohityadav1993 commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585398997
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,13 @@ private void setMergedValue(GenericRo
Jackie-Jiang commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1585352922
##
pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java:
##
@@ -92,7 +93,7 @@ public static String constructDownloadUrl(String baseUrl,
String r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 475708f14f Use try-with-resources to close file w
Jackie-Jiang merged PR #13029:
URL: https://github.com/apache/pinot/pull/13029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
deemoliu commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585344830
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,13 @@ private void setMergedValue(GenericRow row,
deemoliu commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585344830
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,13 @@ private void setMergedValue(GenericRow row,
deemoliu commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585344830
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,13 @@ private void setMergedValue(GenericRow row,
Jackie-Jiang commented on code in PR #13018:
URL: https://github.com/apache/pinot/pull/13018#discussion_r1585333669
##
pinot-plugins/pinot-file-system/pinot-adls/pom.xml:
##
@@ -45,6 +45,12 @@
com.azure
azure-identity
1.12.0
+
Review Comment:
Do we
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.scala-lang-scala-library-2.13.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0dcea4b921 Bump org.scala-lang:scala-library from 2.11.11 to 2.13.14
Jackie-Jiang commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1585327538
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,12 @@ private void setMergedValue(GenericRow
Jackie-Jiang commented on code in PR #13034:
URL: https://github.com/apache/pinot/pull/13034#discussion_r1585317822
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/pom.xml:
##
@@ -38,7 +38,7 @@
package
2.11
2.4.6
-2.11.11
+2.13.14
R
Jackie-Jiang commented on code in PR #13034:
URL: https://github.com/apache/pinot/pull/13034#discussion_r1585317048
##
pom.xml:
##
@@ -237,7 +237,7 @@
1.61.1
-2.12.18
+2.13.14
Review Comment:
```suggestion
2.12.19
```
--
This is an automate
wahab-io commented on issue #11446:
URL: https://github.com/apache/pinot/issues/11446#issuecomment-2086392145
@swaminathanmanish the above link is not working, can you please share the
workaround here?
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-commenter commented on PR #13037:
URL: https://github.com/apache/pinot/pull/13037#issuecomment-2086305874
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13037?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya opened a new pull request, #13037:
URL: https://github.com/apache/pinot/pull/13037
- Support for generating derived columns during segment reload was added in
https://github.com/apache/pinot/pull/6494.
- However, support for generating raw derived columns during segment reload
codecov-commenter commented on PR #13036:
URL: https://github.com/apache/pinot/pull/13036#issuecomment-2085434059
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13036?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on issue #12949:
URL: https://github.com/apache/pinot/issues/12949#issuecomment-2085391731
We plan to have this PR merged soon (maybe next week) which would mean you
will have a docker image ready to use.
But in order to accelerate the discoveries, you can fetch my co
tibrewalpratik17 opened a new pull request, #13036:
URL: https://github.com/apache/pinot/pull/13036
We have intermittently seen issues in our clusters while creating
streamMessageDecoder. Stack trace:
```
java.lang.RuntimeException: Caught exception while creating
StreamMessageDec
codecov-commenter commented on PR #13032:
URL: https://github.com/apache/pinot/pull/13032#issuecomment-2085099213
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13032?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz opened a new pull request, #13035:
URL: https://github.com/apache/pinot/pull/13035
This PR adds some multi-stage metrics. The whole PR is built on top of
https://github.com/apache/pinot/pull/12704 so it should only be merged once
(and if) that other PR is merged.
All new metri
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.scala-lang-scala-library-2.13.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 0dcea4b921 Bump org.scala-lang:scala-library from 2.11.11 to 2.13.1
dependabot[bot] opened a new pull request, #13034:
URL: https://github.com/apache/pinot/pull/13034
Bumps [org.scala-lang:scala-library](https://github.com/scala/scala) from
2.11.11 to 2.13.14.
Release notes
Sourced from https://github.com/scala/scala/releases";>org.scala-lang:scala
KKcorps commented on code in PR #12806:
URL: https://github.com/apache/pinot/pull/12806#discussion_r1584605569
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##
@@ -69,134 +61,77 @@ public KinesisC
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.41
in repository https://gitbox.apache.org/repos/asf/pinot.git
at dc3024ec0c Bump aws.sdk.version from 2.25.40 to 2.25.41
No new revisions were ad
dependabot[bot] opened a new pull request, #13033:
URL: https://github.com/apache/pinot/pull/13033
Bumps `aws.sdk.version` from 2.25.40 to 2.25.41.
Updates `software.amazon.awssdk:bom` from 2.25.40 to 2.25.41
Updates `software.amazon.awssdk:apache-client` from 2.25.40 to 2.25.41
gortiz opened a new pull request, #13032:
URL: https://github.com/apache/pinot/pull/13032
This PR adds 4 new metrics:
1. queriesWithJoins (global): How many queries with joins have been
executed. For each query with at least one join, this meter is increased
exactly once.
2. joinC
codecov-commenter commented on PR #13031:
URL: https://github.com/apache/pinot/pull/13031#issuecomment-2084960008
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13031?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
abhioncbr commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1584515790
##
pinot-common/src/test/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtilsTest.java:
##
@@ -86,7 +86,8 @@ public void testInvalidRelativeURIs()
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583030085
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java:
##
@@ -36,108 +39,129 @@
*/
public class MetadataBlock extends BaseDataBlock {
-
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582728941
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -798,7 +798,6 @@ protected BrokerResponse handleRequest(long re
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582728941
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -798,7 +798,6 @@ protected BrokerResponse handleRequest(long re
abhioncbr commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1584515790
##
pinot-common/src/test/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtilsTest.java:
##
@@ -86,7 +86,8 @@ public void testInvalidRelativeURIs()
gortiz commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2084818483
The PR looks fine to me, but it is a bit strange to approve a performance
wise PR without an actual benchmark we can reproduce. Could you include a JMH
benchmark as part of the PR?
--
T
gortiz commented on code in PR #13020:
URL: https://github.com/apache/pinot/pull/13020#discussion_r1584440068
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/aggregator/DistinctCountCPCSketchValueAggregatorTest.java:
##
@@ -34,19 +34,18 @@ public class Distin
rohityadav1993 commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1584431592
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,12 @@ private void setMergedValue(GenericRo
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1584415369
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -135,14 +160,128 @@ protected TransferableBlo
cyrilou242 closed issue #13000: [single stage] HAVING fails if aggregation is
not in SELECT part
URL: https://github.com/apache/pinot/issues/13000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cyrilou242 commented on issue #13000:
URL: https://github.com/apache/pinot/issues/13000#issuecomment-2084774398
Hey @Jackie-Jiang this is not a blocker for me.
Given it's not a regression I'm fine if it's not fixed and moving to query
engine v2 is the path forward.
--
This is an autom
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1584406372
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -419,4 +550,122 @@ public void send(BaseResul
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1584390473
##
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##
@@ -123,6 +127,17 @@ String toJsonString()
*/
long getMinConsumingFreshness
tibrewalpratik17 commented on code in PR #13031:
URL: https://github.com/apache/pinot/pull/13031#discussion_r1584373832
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##
@@ -84,7 +84,12 @@ private void setMergedValue(Generic
rohityadav1993 opened a new pull request, #13031:
URL: https://github.com/apache/pinot/pull/13031
`bugfix`
When persisting merged result of previous and new row in
PartialUpsertHandler, if a null multivalue field is populated using
_defaultNullValue value it is persisted as a primiti
RalfJL commented on issue #12949:
URL: https://github.com/apache/pinot/issues/12949#issuecomment-2084687069
Sure I will do that.
But currently I am not sure what to do.
Can you please outline the steps? What do I have to pull or merge? What do I
have to do to compile the code and is th
75 matches
Mail list logo
