Jackie-Jiang commented on code in PR #13030:
URL: https://github.com/apache/pinot/pull/13030#discussion_r1585352922
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java:
##########
@@ -92,7 +93,7 @@ public static String constructDownloadUrl(String baseUrl,
String rawTableName, S
public static String encode(String string) {
try {
- return URLEncoder.encode(string, "UTF-8");
+ return URLEncoder.encode(string, StandardCharsets.UTF_8);
} catch (Exception e) {
Review Comment:
I guess we can also remove the try catch because there is no checked
exception anymore. Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
