jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1585519508
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##########
@@ -168,13 +209,18 @@ public AbstractBuilder(TextIndexConfig other) {
_luceneUseCompoundFile = other._luceneUseCompoundFile;
_luceneMaxBufferSizeMB = other._luceneMaxBufferSizeMB;
_luceneAnalyzerClass = other._luceneAnalyzerClass;
+ _luceneAnalyzerClassArgs = other._luceneAnalyzerClassArgs;
+ _luceneAnalyzerClassArgTypes = other._luceneAnalyzerClassArgTypes;
+ _luceneQueryParserClass = other._luceneQueryParserClass;
_enablePrefixSuffixMatchingInPhraseQueries =
other._enablePrefixSuffixMatchingInPhraseQueries;
}
public TextIndexConfig build() {
return new TextIndexConfig(false, _fstType, _rawValueForTextIndex,
_enableQueryCache, _useANDForMultiTermQueries,
_stopWordsInclude, _stopWordsExclude, _luceneUseCompoundFile,
_luceneMaxBufferSizeMB, _luceneAnalyzerClass,
- _enablePrefixSuffixMatchingInPhraseQueries);
+ CsvParser.serialize(_luceneAnalyzerClassArgs, false, false),
+ CsvParser.serialize(_luceneAnalyzerClassArgTypes, false, false),
Review Comment:
Changed only _luceneAnalyzerClassArgs to escape comma as the args type
should not contain escaped comma at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
