Re: [I] Deep store upload retry does not scale for large clusters [pinot]

2023-12-20 Thread via GitHub
itschrispeck closed issue #11874: Deep store upload retry does not scale for large clusters URL: https://github.com/apache/pinot/issues/11874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[I] Http Response Headers for Error Codes [pinot]

2023-12-20 Thread via GitHub
ankitsultana opened a new issue, #12190: URL: https://github.com/apache/pinot/issues/12190 At present, in case of query failures, Pinot broker returns a 200 HTTP Status Code and the message of the body contains a JSON with the exception and the error-code. I was wondering if we can a

Re: [I] Fix Memory Leak in Long-Running JDBC Clients Post-Certificate Rotation [pinot]

2023-12-20 Thread via GitHub
walterddr commented on issue #12100: URL: https://github.com/apache/pinot/issues/12100#issuecomment-1865430878 thank you for the detail analysis. I definitely agree with the findings. b/c this TlsUtils doesn't really use the static `SSL_CONTEXT_REF` ``` builder.setSslContext(TlsUtils.b

Re: [PR] Remove TableDataManagerConfig and simplify TableDataManager construction [pinot]

2023-12-20 Thread via GitHub
codecov-commenter commented on PR #12189: URL: https://github.com/apache/pinot/pull/12189#issuecomment-1865415471 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Proper computation of realtime "segment.flush.threshold.size" in case of force-commit [pinot]

2023-12-20 Thread via GitHub
codecov-commenter commented on PR #12188: URL: https://github.com/apache/pinot/pull/12188#issuecomment-1865398906 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Remove TableDataManagerConfig and simplify TableDataManager construction [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang opened a new pull request, #12189: URL: https://github.com/apache/pinot/pull/12189 `TableDataManagerConfig` is simply a wrapper over `InstanceDataManagerConfig` and `TableConfig` but can introduce a lot of confusion into the `TableDataManager` -- This is an automated message

Re: [PR] Proper computation of realtime "segment.flush.threshold.size" in case of force-commit [pinot]

2023-12-20 Thread via GitHub
mcvsubbu commented on code in PR #12188: URL: https://github.com/apache/pinot/pull/12188#discussion_r1433378961 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/segment/SegmentFlushThresholdComputerTest.java: ## @@ -105,6 +106,28 @@ public void

Re: [PR] Add partition level Force Commit [pinot]

2023-12-20 Thread via GitHub
sajjad-moradi commented on code in PR #12088: URL: https://github.com/apache/pinot/pull/12088#discussion_r1433369984 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -136,15 +136,22 @@ public Response resumeConsum

[PR] Proper computation of realtime "segment.flush.threshold.size" in case of force-commit [pinot]

2023-12-20 Thread via GitHub
sajjad-moradi opened a new pull request, #12188: URL: https://github.com/apache/pinot/pull/12188 The `SegmentFlushThresholdComputer` does not appropriately manage situations where segments are committing as a result of force-commit requests. In this PR, the size threshold of the committing

Re: [PR] Add partition level Force Commit [pinot]

2023-12-20 Thread via GitHub
mcvsubbu commented on code in PR #12088: URL: https://github.com/apache/pinot/pull/12088#discussion_r1433307104 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -136,15 +136,22 @@ public Response resumeConsumption

Re: [PR] test [pinot]

2023-12-20 Thread via GitHub
codecov-commenter commented on PR #12173: URL: https://github.com/apache/pinot/pull/12173#issuecomment-1865276299 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Add partition level Force Commit [pinot]

2023-12-20 Thread via GitHub
sajjad-moradi commented on code in PR #12088: URL: https://github.com/apache/pinot/pull/12088#discussion_r1433259329 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java: ## @@ -136,15 +136,22 @@ public Response resumeConsum

Re: [I] ISO-8601 T character issue when using Multi-Stage Engine [pinot]

2023-12-20 Thread via GitHub
sschulzdialpad closed issue #12187: ISO-8601 T character issue when using Multi-Stage Engine URL: https://github.com/apache/pinot/issues/12187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] ISO-8601 T character issue when using Multi-Stage Engine [pinot]

2023-12-20 Thread via GitHub
sschulzdialpad commented on issue #12187: URL: https://github.com/apache/pinot/issues/12187#issuecomment-1865231726 It appears like using ''T'' instead of T fixes the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[I] ISO-8601 T character issue when using Multi-Stage Engine [pinot]

2023-12-20 Thread via GitHub
sschulzdialpad opened a new issue, #12187: URL: https://github.com/apache/pinot/issues/12187 Hi folks, it appears like the Multi-Stage Engine on Apache Pinot 1.0.0 is enforcing a different ruleset for valid patterns for the FROMDATETIME function when applied as a filter. ``` WH

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433186432 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationSpec.java: ## @@ -50,4 +52,10 @@ public boolean equals(Object o) { pub

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433184478 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/DistinctCountHLLPlusValueAggregator.java: ## @@ -31,6 +31,7 @@ public class Disti

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
davecromberge commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433140653 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationSpec.java: ## @@ -50,4 +52,10 @@ public boolean equals(Object o) { pu

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
davecromberge commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433138447 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/DistinctCountHLLPlusValueAggregator.java: ## @@ -31,6 +31,7 @@ public class Dist

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433107168 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/BaseSingleTreeBuilder.java: ## @@ -133,7 +133,9 @@ static class Record {

(pinot) branch dependabot/maven/com.google.auto.service-auto-service-1.1.1 deleted (was a4c8d0d44a)

2023-12-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.auto.service-auto-service-1.1.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was a4c8d0d44a Bump com.google.auto.service:auto-service from 1.0.1 t

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.0 deleted (was b16bd1deb0)

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was b16bd1deb0 Bump org.apache.maven.plugins:maven-com

Re: [PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.8.0 to 3.12.0 [pinot]

2023-12-20 Thread via GitHub
dependabot[bot] commented on PR #12185: URL: https://github.com/apache/pinot/pull/12185#issuecomment-1865007673 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.8.0 to 3.12.0 [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang closed pull request #12185: Bump org.apache.maven.plugins:maven-compiler-plugin from 3.8.0 to 3.12.0 URL: https://github.com/apache/pinot/pull/12185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

(pinot) branch master updated: Bump com.google.auto.service:auto-service from 1.0.1 to 1.1.1 (#12183)

2023-12-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 24f8433d5f Bump com.google.auto.service:auto-serv

Re: [PR] Bump com.google.auto.service:auto-service from 1.0.1 to 1.1.1 [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang merged PR #12183: URL: https://github.com/apache/pinot/pull/12183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/jersey.version-3.1.5 deleted (was 87ec9968b5)

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jersey.version-3.1.5 in repository https://gitbox.apache.org/repos/asf/pinot.git was 87ec9968b5 Bump jersey.version from 2.39 to 3.1.5 The revisions that were on this b

Re: [PR] Bump jersey.version from 2.39 to 3.1.5 [pinot]

2023-12-20 Thread via GitHub
dependabot[bot] commented on PR #12184: URL: https://github.com/apache/pinot/pull/12184#issuecomment-1865006651 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump jersey.version from 2.39 to 3.1.5 [pinot]

2023-12-20 Thread via GitHub
Jackie-Jiang closed pull request #12184: Bump jersey.version from 2.39 to 3.1.5 URL: https://github.com/apache/pinot/pull/12184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [test][bug] query generator doesn't escape string in REGEXP_LIKE [pinot]

2023-12-20 Thread via GitHub
walterddr closed issue #11918: [test][bug] query generator doesn't escape string in REGEXP_LIKE URL: https://github.com/apache/pinot/issues/11918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(pinot) branch master updated: fix regex gen with escape issue on single quote (#12181)

2023-12-20 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 85d3850227 fix regex gen with escape issue on sing

Re: [PR] [test] fix regex gen with escape issue on single quote [pinot]

2023-12-20 Thread via GitHub
walterddr merged PR #12181: URL: https://github.com/apache/pinot/pull/12181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[I] Allow to add derived columns that depends on new columns [pinot]

2023-12-20 Thread via GitHub
gortiz opened a new issue, #12186: URL: https://github.com/apache/pinot/issues/12186 Right now Pinot fails when a table is modified in such a way that two columns are added and one of them depend on the other. More specifically, assuming table T has columns A1, A2 and A3, it should be

Re: [PR] Data generator reorganisation [pinot]

2023-12-20 Thread via GitHub
shounakmk219 commented on PR #12122: URL: https://github.com/apache/pinot/pull/12122#issuecomment-1864410328 Thanks for the review @xiangfu0 ! I have addressed your comments along with a bugfix for removing hardcoded file extension and also added a new `cleanup()` method to `Writer` inter

Re: [PR] Shared aggregations in StarTree [pinot]

2023-12-20 Thread via GitHub
davecromberge commented on PR #12164: URL: https://github.com/apache/pinot/pull/12164#issuecomment-1864402815 I've removed all the changes to the metadata and configuration mapping. The original intent behind those were to mitigate against breaking changes to existing segment behavio

Re: [I] Fix Memory Leak in Long-Running JDBC Clients Post-Certificate Rotation [pinot]

2023-12-20 Thread via GitHub
kay-owolabi commented on issue #12100: URL: https://github.com/apache/pinot/issues/12100#issuecomment-1864397242 Hi @walterddr, After investigating the SSL/TLS configuration issues, particularly related to `JsonAsyncHttpPinotClientTransport` and `PinotControllerTransport`, I've uncov

Re: [PR] Data generator reorganisation [pinot]

2023-12-20 Thread via GitHub
shounakmk219 commented on code in PR #12122: URL: https://github.com/apache/pinot/pull/12122#discussion_r1432657109 ## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/writer/AvroRecordAppender.java: ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

Re: [PR] Data generator reorganisation [pinot]

2023-12-20 Thread via GitHub
shounakmk219 commented on code in PR #12122: URL: https://github.com/apache/pinot/pull/12122#discussion_r1432650824 ## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/writer/FileWriter.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software

Re: [PR] Bump com.google.auto.service:auto-service from 1.0.1 to 1.1.1 [pinot]

2023-12-20 Thread via GitHub
codecov-commenter commented on PR #12183: URL: https://github.com/apache/pinot/pull/12183#issuecomment-1864365698 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.8.0 to 3.12.0 [pinot]

2023-12-20 Thread via GitHub
codecov-commenter commented on PR #12185: URL: https://github.com/apache/pinot/pull/12185#issuecomment-1864360554 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.0 created (now b16bd1deb0)

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at b16bd1deb0 Bump org.apache.maven.plugins:maven-com

[PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.8.0 to 3.12.0 [pinot]

2023-12-20 Thread via GitHub
dependabot[bot] opened a new pull request, #12185: URL: https://github.com/apache/pinot/pull/12185 Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.0 to 3.12.0. Release notes Sourced from https://github.com/apache/mav

(pinot) branch dependabot/maven/jersey.version-3.1.5 created (now 87ec9968b5)

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jersey.version-3.1.5 in repository https://gitbox.apache.org/repos/asf/pinot.git at 87ec9968b5 Bump jersey.version from 2.39 to 3.1.5 No new revisions were added by th

[PR] Bump jersey.version from 2.39 to 3.1.5 [pinot]

2023-12-20 Thread via GitHub
dependabot[bot] opened a new pull request, #12184: URL: https://github.com/apache/pinot/pull/12184 Bumps `jersey.version` from 2.39 to 3.1.5. Updates `org.glassfish.jersey.containers:jersey-container-grizzly2-http` from 2.39 to 3.1.5 Updates `org.glassfish.jersey.core:jersey-server

(pinot) branch dependabot/maven/com.google.auto.service-auto-service-1.1.1 created (now a4c8d0d44a)

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.auto.service-auto-service-1.1.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at a4c8d0d44a Bump com.google.auto.service:auto-service from 1.0

[PR] Bump com.google.auto.service:auto-service from 1.0.1 to 1.1.1 [pinot]

2023-12-20 Thread via GitHub
dependabot[bot] opened a new pull request, #12183: URL: https://github.com/apache/pinot/pull/12183 Bumps [com.google.auto.service:auto-service](https://github.com/google/auto) from 1.0.1 to 1.1.1. Release notes Sourced from https://github.com/google/auto/releases";>com.google.auto.

Re: [PR] Data generator reorganisation [pinot]

2023-12-20 Thread via GitHub
xiangfu0 commented on code in PR #12122: URL: https://github.com/apache/pinot/pull/12122#discussion_r1432407851 ## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/writer/FileWriter.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Data generator reorganisation [pinot]

2023-12-20 Thread via GitHub
xiangfu0 commented on code in PR #12122: URL: https://github.com/apache/pinot/pull/12122#discussion_r1432405769 ## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/data/writer/AvroRecordAppender.java: ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Soft