Jackie-Jiang commented on code in PR #12164: URL: https://github.com/apache/pinot/pull/12164#discussion_r1433186432
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationSpec.java: ########## @@ -50,4 +52,10 @@ public boolean equals(Object o) { public int hashCode() { return _compressionType.hashCode(); } + + @Override + public String toString() { + return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE).append("compressionType", _compressionType) + .toString(); Review Comment: I see. Just realize we are already using the `ToStringBuilder` in `StarTreeV2BuilderConfig`, so we should be good here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org