davecromberge commented on PR #12164: URL: https://github.com/apache/pinot/pull/12164#issuecomment-1864402815
I've removed all the changes to the metadata and configuration mapping. The original intent behind those were to mitigate against breaking changes to existing segment behaviour should the internal mapping between query aggregation and stored value aggregation evolve. Removing this additional complexity does simplify the implementation. The current `DistinctCountHLLPlusValueAggregator` returns `DISTINCTCOUNTHLL` as its `AggregationFunctionType` (see failing unit test). I'm unsure if this is intentional - if it is, problems may arise from the changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
