[I] Streaming query client [pinot]

2023-10-27 Thread via GitHub
xiangfu0 opened a new issue, #11901: URL: https://github.com/apache/pinot/issues/11901 This pops up as a requirement when quickstart join query might generates many rows. It may blow up broker memory as it tries to keep all the rows in memory then return it back. The goal of this PR

[I] Show the exception details as a default setting [pinot]

2023-10-27 Thread via GitHub
ksnijjer opened a new issue, #11900: URL: https://github.com/apache/pinot/issues/11900 Currently in Pinot Query Console if there is any error you need to manually click on button to view the details. This seems counter intuitive as in such a scenario you do want to see the full details

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11868: URL: https://github.com/apache/pinot/pull/11868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (22f41716fd -> 8e8bd328a6)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 22f41716fd Bump net.minidev:json-smart from 2.4.10 to 2.5.0 (#11875) add 8e8bd328a6 11085: Pre PinotConfig common

(pinot) branch master updated (9022eaec2b -> 22f41716fd)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9022eaec2b Bump org.yaml:snakeyaml from 2.0 to 2.2 (#11876) add 22f41716fd Bump net.minidev:json-smart from 2.4.1

Re: [PR] Bump net.minidev:json-smart from 2.4.10 to 2.5.0 [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11875: URL: https://github.com/apache/pinot/pull/11875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch dependabot/maven/net.minidev-json-smart-2.5.0 deleted (was 1922f65993)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/net.minidev-json-smart-2.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1922f65993 Bump net.minidev:json-smart from 2.4.10 to 2.5.0 The revisions that

(pinot) branch dependabot/maven/org.yaml-snakeyaml-2.2 deleted (was b14514eb8f)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/org.yaml-snakeyaml-2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was b14514eb8f Bump org.yaml:snakeyaml from 2.0 to 2.2 The revisions that were on this b

(pinot) branch master updated: Bump org.yaml:snakeyaml from 2.0 to 2.2 (#11876)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9022eaec2b Bump org.yaml:snakeyaml from 2.0 to 2

Re: [PR] Bump org.yaml:snakeyaml from 2.0 to 2.2 [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11876: URL: https://github.com/apache/pinot/pull/11876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Adds support for leveraging StarTree index in conjunction with filtered aggregations [pinot]

2023-10-27 Thread via GitHub
xiangfu0 commented on PR #11886: URL: https://github.com/apache/pinot/pull/11886#issuecomment-1783690777 > @xiangfu0 yep! The goal of this PR would be to support exactly what’s described in #11899. Happy to collaborate, just let me know! Great! -- This is an automated message from

Re: [PR] Adds support for leveraging StarTree index in conjunction with filtered aggregations [pinot]

2023-10-27 Thread via GitHub
egalpin commented on PR #11886: URL: https://github.com/apache/pinot/pull/11886#issuecomment-1783684115 @xiangfu0 yep! The goal of this PR would be to support exactly what’s described in https://github.com/apache/pinot/issues/11899. Happy to collaborate, just let me know! -- This is an

Re: [PR] Adds support for leveraging StarTree index in conjunction with filtered aggregations [pinot]

2023-10-27 Thread via GitHub
xiangfu0 commented on PR #11886: URL: https://github.com/apache/pinot/pull/11886#issuecomment-1783676206 not sure if this is related: https://github.com/apache/pinot/issues/11899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[I] StarTree Index not used for query with aggregation filter + aggregation Group BY [pinot]

2023-10-27 Thread via GitHub
xiangfu0 opened a new issue, #11899: URL: https://github.com/apache/pinot/issues/11899 E.g. ``` SELECT sum(m1) FILTER d1=1 , count(*) WHERE d2=2 GROUP BY d3 ``` For the above query, though ``` SELECT count(*) WHERE d2=2 GROUP BY d3

Re: [PR] Adding support for listing dimension tables in /tables API [pinot]

2023-10-27 Thread via GitHub
soumitra-st commented on code in PR #11859: URL: https://github.com/apache/pinot/pull/11859#discussion_r1375134415 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -268,20 +268,28 @@ public String recommendConfig(S

Re: [PR] pre-configuration based assignment [pinot]

2023-10-27 Thread via GitHub
somandal commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1375132678 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -60,19 +60,31 @@ public InstanceParti

Re: [PR] Adding support for listing dimension tables in /tables API [pinot]

2023-10-27 Thread via GitHub
soumitra-st commented on code in PR #11859: URL: https://github.com/apache/pinot/pull/11859#discussion_r1375134415 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -268,20 +268,28 @@ public String recommendConfig(S

Re: [PR] (WIP) Allowing custom transformers to be passed to SegmentProcessingFramework [pinot]

2023-10-27 Thread via GitHub
swaminathanmanish commented on code in PR #11887: URL: https://github.com/apache/pinot/pull/11887#discussion_r1375134170 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java: ## @@ -69,12 +70,22 @@ public class Composite

Re: [PR] Adding support for listing dimension tables in /tables API [pinot]

2023-10-27 Thread via GitHub
soumitra-st commented on code in PR #11859: URL: https://github.com/apache/pinot/pull/11859#discussion_r1375133871 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -268,20 +268,28 @@ public String recommendConfig(S

Re: [PR] Support Upsert deletion for TTL: construct queryableDocIds when adding segments out of TTL [pinot]

2023-10-27 Thread via GitHub
deemoliu commented on code in PR #11791: URL: https://github.com/apache/pinot/pull/11791#discussion_r1375104912 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -121,6 +121,32 @@ public List getPrimaryKeyCo

Re: [PR] Add 'jsonKey' option for GcsPinotFS [pinot]

2023-10-27 Thread via GitHub
snleee commented on PR #11890: URL: https://github.com/apache/pinot/pull/11890#issuecomment-1783587730 @xiangfu0 added the release document. I will update the documentation as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

(pinot) branch master updated (8c870b7655 -> 60edf49db6)

2023-10-27 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8c870b7655 Bump browserify-sign in /pinot-controller/src/main/resources (#11896) add 60edf49db6 Add 'jsonKey' opti

Re: [PR] Add 'jsonKey' option for GcsPinotFS [pinot]

2023-10-27 Thread via GitHub
snleee merged PR #11890: URL: https://github.com/apache/pinot/pull/11890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Support auth for QueryRunner [pinot]

2023-10-27 Thread via GitHub
codecov-commenter commented on PR #11897: URL: https://github.com/apache/pinot/pull/11897#issuecomment-1783585363 We're currently processing your upload. This comment will be updated when the results are available. -- This is an automated message from the Apache Git Service. To respond t

(pinot) branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/browserify-sign-4.2.2 deleted (was 9a9c914804)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/browserify-sign-4.2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 9a9c914804 Bump browserify-sign in /pinot-

(pinot) branch master updated (ce25936323 -> 8c870b7655)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ce25936323 Radomize server port to avoid port already bind issue (#11861) add 8c870b7655 Bump browserify-sign in

Re: [PR] Bump browserify-sign from 4.2.1 to 4.2.2 in /pinot-controller/src/main/resources [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11896: URL: https://github.com/apache/pinot/pull/11896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] pre-configuration based assignment [pinot]

2023-10-27 Thread via GitHub
jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1375083118 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1735,20 +1735,29 @@ private void assignInstances(Ta

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
xiangfu0 commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1375082035 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ## @@ -101,10 +101,16 @@ private static Iterable getIterable(Iterator keys) {

Re: [PR] Add 'jsonKey' option for GcsPinotFS [pinot]

2023-10-27 Thread via GitHub
xiangfu0 commented on PR #11890: URL: https://github.com/apache/pinot/pull/11890#issuecomment-1783542258 Better to document and add a release notes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Support auth for QueryRunner [pinot]

2023-10-27 Thread via GitHub
xiangfu0 opened a new pull request, #11897: URL: https://github.com/apache/pinot/pull/11897 - Support auth for QueryRunner - Some refactor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump browserify-sign from 4.2.1 to 4.2.2 in /pinot-controller/src/main/resources [pinot]

2023-10-27 Thread via GitHub
codecov-commenter commented on PR #11896: URL: https://github.com/apache/pinot/pull/11896#issuecomment-1783516530 We're currently processing your upload. This comment will be updated when the results are available. -- This is an automated message from the Apache Git Service. To respond t

(pinot) branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/browserify-sign-4.2.2 created (now 9a9c914804)

2023-10-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/browserify-sign-4.2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 9a9c914804 Bump browserify-sign in /pin

[PR] Bump browserify-sign from 4.2.1 to 4.2.2 in /pinot-controller/src/main/resources [pinot]

2023-10-27 Thread via GitHub
dependabot[bot] opened a new pull request, #11896: URL: https://github.com/apache/pinot/pull/11896 Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. Changelog Sourced from https://github.com/browserify/browserify-sign/blob/main/CHAN

Re: [PR] Fix leaf query generation bug when there are multiple LogicalFilters [pinot]

2023-10-27 Thread via GitHub
xiangfu0 closed pull request #11888: Fix leaf query generation bug when there are multiple LogicalFilters URL: https://github.com/apache/pinot/pull/11888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] pre-configuration based assignment [pinot]

2023-10-27 Thread via GitHub
somandal commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1374921766 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1735,20 +1735,29 @@ private void assignInstances(TableC

Re: [PR] Broker Query Timeout Metric [pinot]

2023-10-27 Thread via GitHub
suddendust commented on code in PR #11892: URL: https://github.com/apache/pinot/pull/11892#discussion_r1374909306 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -191,6 +192,11 @@ protected BrokerResponse handleRequ

Re: [PR] Randomize integration tests port assignments [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11861: URL: https://github.com/apache/pinot/pull/11861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (6853991193 -> ce25936323)

2023-10-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6853991193 Fix multiple consecutive Exchange returning empty response (#11885) add ce25936323 Radomize server po

Re: [I] [multistage] order-by on UNION STRING and INT columns somehow is allowed [pinot]

2023-10-27 Thread via GitHub
walterddr commented on issue #11879: URL: https://github.com/apache/pinot/issues/11879#issuecomment-1783270316 @kim-jaewoong not really, if you change the order by to val it still works. b/c pinot considers literal as unparsed type until execution --> so it is forgiving enough to auto-cast

Re: [PR] Adding support for listing dimension tables in /tables API [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11859: URL: https://github.com/apache/pinot/pull/11859#discussion_r1374859670 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -268,20 +268,28 @@ public String recommendConfig(Str

Re: [PR] Fix multiple consecutive Exchange returning empty response [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11885: URL: https://github.com/apache/pinot/pull/11885#discussion_r1374834351 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java: ## @@ -128,6 +128,8 @@ public PlanNode visitExchange(ExchangeNode nod

Re: [PR] Fix multiple consecutive Exchange returning empty response [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11885: URL: https://github.com/apache/pinot/pull/11885#discussion_r1374834351 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java: ## @@ -128,6 +128,8 @@ public PlanNode visitExchange(ExchangeNode nod

Re: [PR] Adding support for listing dimension tables in /tables API [pinot]

2023-10-27 Thread via GitHub
Jackie-Jiang commented on code in PR #11859: URL: https://github.com/apache/pinot/pull/11859#discussion_r1374828964 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -268,20 +268,28 @@ public String recommendConfig(

Re: [PR] Fix multiple consecutive Exchange returning empty response [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11885: URL: https://github.com/apache/pinot/pull/11885#discussion_r1374827733 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java: ## @@ -128,6 +128,8 @@ public PlanNode visitExchange(ExchangeNode nod

Re: [PR] Fix multiple consecutive Exchange returning empty response [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11885: URL: https://github.com/apache/pinot/pull/11885#discussion_r1374827733 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java: ## @@ -128,6 +128,8 @@ public PlanNode visitExchange(ExchangeNode nod

Re: [PR] Upgrade spark from 3.2 to 3.5 [pinot]

2023-10-27 Thread via GitHub
mcvsubbu commented on PR #11702: URL: https://github.com/apache/pinot/pull/11702#issuecomment-1783192482 @gortiz is bumping to log4j-slf4j2 absolutely necessary? Can we revert that? The reason is that this pulls in later version of log4j library (like you have changed), and they seem

Re: [PR] Broker Query Timeout Metric [pinot]

2023-10-27 Thread via GitHub
Jackie-Jiang commented on code in PR #11892: URL: https://github.com/apache/pinot/pull/11892#discussion_r1374783099 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java: ## @@ -116,6 +117,9 @@ protected BrokerResponseNati

Re: [PR] [multistage][bugfix] eliminate multiple exchanges [pinot]

2023-10-27 Thread via GitHub
walterddr commented on code in PR #11882: URL: https://github.com/apache/pinot/pull/11882#discussion_r1374786701 ## pinot-query-planner/src/test/resources/queries/JoinPlans.json: ## @@ -421,6 +421,28 @@ "\n LogicalTableScan(table=[[b]])", "\n"

(pinot) branch master updated: Fix multiple consecutive Exchange returning empty response (#11885)

2023-10-27 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6853991193 Fix multiple consecutive Exchange retu

Re: [I] [multistage] mailbox receiving stage not correctly created [pinot]

2023-10-27 Thread via GitHub
Jackie-Jiang closed issue #11880: [multistage] mailbox receiving stage not correctly created URL: https://github.com/apache/pinot/issues/11880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix multiple consecutive Exchange returning empty response [pinot]

2023-10-27 Thread via GitHub
Jackie-Jiang merged PR #11885: URL: https://github.com/apache/pinot/pull/11885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[I] Table rebalance should always perform deletions before downloads [pinot]

2023-10-27 Thread via GitHub
jadami10 opened a new issue, #11895: URL: https://github.com/apache/pinot/issues/11895 Table rebalance today, except for dry-run and downtime, happens as a series of steps that update the ideal state and wait for external view to converge. These ideal state updates will ask servers to both

[I] MinimizeDataMovement does not work correctly for upsert tables [pinot]

2023-10-27 Thread via GitHub
jadami10 opened a new issue, #11894: URL: https://github.com/apache/pinot/issues/11894 We tried scaling up an upsert table and rebalancing. With MinimizeDataMovement, we still saw effectively every single segment moving to a different server. Upsert tables are more complicated becau

[I] UnsupportedOperationException when querying a converted dictionary -> noDictionary column [pinot]

2023-10-27 Thread via GitHub
jadami10 opened a new issue, #11893: URL: https://github.com/apache/pinot/issues/11893 We got to this error by - initially creating a table and ingestion GB/TBs of data - months later, we added a Json column and reloaded all segments - months after that, we added the Json column to `

Re: [PR] Broker Query Timeout Metric [pinot]

2023-10-27 Thread via GitHub
codecov-commenter commented on PR #11892: URL: https://github.com/apache/pinot/pull/11892#issuecomment-1782892671 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11892?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Broker Query Timeout Metric [pinot]

2023-10-27 Thread via GitHub
suddendust closed pull request #11892: Broker Query Timeout Metric URL: https://github.com/apache/pinot/pull/11892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Broker Query Timeout Metric [pinot]

2023-10-27 Thread via GitHub
suddendust opened a new pull request, #11892: URL: https://github.com/apache/pinot/pull/11892 Exposing a new metric to tracing broker query timeouts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add upsert config - outOfOrderRecordColumn to track out-of-order events [pinot]

2023-10-27 Thread via GitHub
codecov-commenter commented on PR #11877: URL: https://github.com/apache/pinot/pull/11877#issuecomment-1782725284 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[I] JMX to Prometheus errors [pinot]

2023-10-27 Thread via GitHub
araghavendra16 opened a new issue, #11891: URL: https://github.com/apache/pinot/issues/11891 Hi, I'm on docker setup. I'm trying to implement JMX to Prometheus https://docs.pinot.apache.org/operators/operating-pinot/monitoring This is my docker-compose version: '3.7' s

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
abhioncbr commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1374284752 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java: ## @@ -211,7 +211,7 @@ protected PinotConfiguration getDefaultSe

Re: [PR] Add DATETIMECONVERTWINDOWHOP function [pinot]

2023-10-27 Thread via GitHub
alexch2000 commented on code in PR #11773: URL: https://github.com/apache/pinot/pull/11773#discussion_r1372712667 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetimehop/EpochToEpochWindowHopTransformer.java: ## @@ -0,0 +1,48 @@ +/** + * Lice

Re: [PR] Add 'jsonKey' option for GcsPinotFS [pinot]

2023-10-27 Thread via GitHub
codecov-commenter commented on PR #11890: URL: https://github.com/apache/pinot/pull/11890#issuecomment-1782499595 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Deprecate _segmentAssignmentStrategy in SegmentsValidationAndRetentionConfig [pinot]

2023-10-27 Thread via GitHub
snleee commented on code in PR #11869: URL: https://github.com/apache/pinot/pull/11869#discussion_r1374204729 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java: ## @@ -73,8 +72,9 @@ public class TableConfigBuilder { @Deprecated private S

[PR] Add 'jsonKey' option for GcsPinotFS [pinot]

2023-10-27 Thread via GitHub
snleee opened a new pull request, #11890: URL: https://github.com/apache/pinot/pull/11890 - Currently, we support 'gcpKey' option which requires to have the gcp credential file available locally. - We add 'jsonKey' option where the raw string or base64 encoded gcp credential can be passe