Jackie-Jiang commented on code in PR #11892:
URL: https://github.com/apache/pinot/pull/11892#discussion_r1374783099
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -116,6 +117,9 @@ protected BrokerResponseNative processBrokerRequest(long
requestId, BrokerReques
realtimeBrokerRequest, realtimeRoutingTable, timeoutMs);
_failureDetector.notifyQuerySubmitted(asyncQueryResponse);
Map<ServerRoutingInstance, ServerResponse> finalResponses =
asyncQueryResponse.getFinalResponses();
+ if (asyncQueryResponse.getStatus() == QueryResponse.Status.TIMED_OUT) {
+ _brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_TIMEOUTS, 1);
Review Comment:
Let's use actual table name (with type) instead of raw table name
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -191,6 +192,11 @@ protected BrokerResponse handleRequest(long requestId,
String query, @Nullable S
try {
queryResults = _queryDispatcher.submitAndReduce(requestContext,
dispatchableSubPlan, queryTimeoutMs, queryOptions,
stageIdStatsMap);
+ } catch (TimeoutException e) {
Review Comment:
Can you verify if it can throw `TimeoutException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
