xiangfu0 commented on code in PR #11868:
URL: https://github.com/apache/pinot/pull/11868#discussion_r1375082035
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##########
@@ -101,10 +101,16 @@ private static Iterable<String>
getIterable(Iterator<String> keys) {
* @param configuration to iterate on keys
* @return a stream of keys
*/
+ @Deprecated
public static Stream<String> getKeysStream(Configuration configuration) {
return
StreamSupport.stream(getIterable(configuration.getKeys()).spliterator(), false);
}
+ public static Stream<String>
getKeysStream(org.apache.commons.configuration2.Configuration configuration) {
Review Comment:
Put `org.apache.commons.configuration2.Configuration` to import section and
make the deprecated `org.apache.commons.configuration.Configuration` to full
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
