[GitHub] [pinot] mayankshriv commented on issue #10311: Security Concerns in the Pinot Docker Image and Java Depedencies

mayankshriv commented on issue #10311: URL: https://github.com/apache/pinot/issues/10311#issuecomment-1616221792 I did a quick scan and do see several of these had already been updated a while back @andscoop @npandeyaof -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] walterddr commented on a diff in pull request #10846: [multistage] Initial planner changes to support the v1 aggregation functions in multistage

walterddr commented on code in PR #10846: URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908947 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -188,60 +191,27 @@ public void shouldAggregateSingleIn

[GitHub] [pinot] walterddr commented on a diff in pull request #10846: [multistage] Initial planner changes to support the v1 aggregation functions in multistage

walterddr commented on code in PR #10846: URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908794 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -79,7 +77,8 @@ public void shouldHandleUpstreamErrorBlo

[GitHub] [pinot] walterddr commented on a diff in pull request #10846: [multistage] Initial planner changes to support the v1 aggregation functions in multistage

walterddr commented on code in PR #10846: URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908703 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java: ## @@ -100,17 +100,14 @@ public MultiStageOperator visitAggregate(A

[GitHub] [pinot] walterddr commented on a diff in pull request #10846: [multistage] Initial planner changes to support the v1 aggregation functions in multistage

walterddr commented on code in PR #10846: URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908609 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AggregateNode.java: ## @@ -35,30 +35,72 @@ public class AggregateNode extends AbstractPla

[GitHub] [pinot] walterddr commented on a diff in pull request #10991: [enhance]: When enable case-insensitive, don't allow to add newly col…

walterddr commented on code in PR #10991: URL: https://github.com/apache/pinot/pull/10991#discussion_r1248907153 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -359,7 +364,10 @@ private void validateSchemaIntern

[GitHub] [pinot] walterddr commented on a diff in pull request #10991: [enhance]: When enable case-insensitive, don't allow to add newly col…

walterddr commented on code in PR #10991: URL: https://github.com/apache/pinot/pull/10991#discussion_r1248907153 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -359,7 +364,10 @@ private void validateSchemaIntern

[GitHub] [pinot] INNOCENT-BOY commented on a diff in pull request #10991: [enhance]: When enable case-insensitive, don't allow to add newly col…

INNOCENT-BOY commented on code in PR #10991: URL: https://github.com/apache/pinot/pull/10991#discussion_r1248895668 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -359,7 +364,10 @@ private void validateSchemaInt

[GitHub] [pinot] walterddr commented on pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

walterddr commented on PR #10845: URL: https://github.com/apache/pinot/pull/10845#issuecomment-1615988294 merging this one first. and continue if any follow up is needed on #10846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[pinot] branch master updated: [Multistage] Runtime changes for leveraging V1 Aggregation Functions (#10845)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a6ee2773a2 [Multistage] Runtime changes for levera

[GitHub] [pinot] walterddr merged pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

walterddr merged PR #10845: URL: https://github.com/apache/pinot/pull/10845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] KKcorps commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

KKcorps commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248866166 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -75,6 +115,145 @@ public void init(TableConfig tab

[GitHub] [pinot] klsince commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

klsince commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248859798 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -190,7 +192,11 @@ public void addSegment(Immut

[GitHub] [pinot] klsince commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

klsince commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248859078 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -190,7 +192,11 @@ public void addSegment(Immut

[GitHub] [pinot] klsince commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

klsince commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248858373 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -42,10 +73,19 @@ public abstract class BaseTableUp

[GitHub] [pinot] klsince commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

klsince commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248858243 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -75,6 +115,145 @@ public void init(TableConfig tab

[GitHub] [pinot] andimiller commented on a diff in pull request #10982: Allow extra aggregation types in RealtimeToOfflineSegmentsTask

andimiller commented on code in PR #10982: URL: https://github.com/apache/pinot/pull/10982#discussion_r1248857733 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -42,6 +42,7 @@ import org.apache.pinot.common.request.context

[GitHub] [pinot] ankitsultana commented on a diff in pull request #11023: [multistage] Add numGroupsLimitReached metrics to broker v2 queries

ankitsultana commented on code in PR #11023: URL: https://github.com/apache/pinot/pull/11023#discussion_r1248823295 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -247,6 +247,12 @@ private BrokerResponse handleRequ

[GitHub] [pinot] codecov-commenter commented on pull request #11023: [multistage] Add numGroupsLimitReached metrics to broker v2 queries

codecov-commenter commented on PR #11023: URL: https://github.com/apache/pinot/pull/11023#issuecomment-1615730477 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11023?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #11023: [multistage] Add numGroupsLimitReached metrics to broker v2 queries

tibrewalpratik17 opened a new pull request, #11023: URL: https://github.com/apache/pinot/pull/11023 labels: - `multistage` numGroupsLimitReached metric was emitted in v1 but was not getting emitted for v2 queries. Adding that support. This is also called out as a task in #10781

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10891: Ensure min/max value generation in the segment metadata.

Jackie-Jiang commented on code in PR #10891: URL: https://github.com/apache/pinot/pull/10891#discussion_r1248658614 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java: ## @@ -119,65 +126,257

[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10993: Update getTenantInstances call for controller and separate POST operations on it

tibrewalpratik17 commented on code in PR #10993: URL: https://github.com/apache/pinot/pull/10993#discussion_r1248657503 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -276,27 +292,17 @@ private String toggleTena

[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10993: Update getTenantInstances call for controller and separate POST operations on it

tibrewalpratik17 commented on code in PR #10993: URL: https://github.com/apache/pinot/pull/10993#discussion_r1248657080 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -260,7 +276,7 @@ private String getTablesSer

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10891: Ensure min/max value generation in the segment metadata.

Jackie-Jiang commented on code in PR #10891: URL: https://github.com/apache/pinot/pull/10891#discussion_r1248654776 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java: ## @@ -119,65 +123,153

[pinot] branch master updated: Fix a flaky test OfflineGRPCServerIntegrationTest.testQueryingGrpcServer. (#11022)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6f2bcde2e1 Fix a flaky test OfflineGRPCServerInt

[GitHub] [pinot] Jackie-Jiang merged pull request #11022: Fix a flaky test OfflineGRPCServerIntegrationTest.testQueryingGrpcServer.

Jackie-Jiang merged PR #11022: URL: https://github.com/apache/pinot/pull/11022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

Jackie-Jiang commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248613256 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -135,6 +136,11 @@ public synchronized void init(PinotConfi