klsince commented on code in PR #11020: URL: https://github.com/apache/pinot/pull/11020#discussion_r1248858373
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ########## @@ -42,10 +73,19 @@ public abstract class BaseTableUpsertMetadataManager implements TableUpsertMetad protected PartialUpsertHandler _partialUpsertHandler; protected boolean _enableSnapshot; protected ServerMetrics _serverMetrics; + private HelixManager _helixManager; + private ExecutorService _preloadExecutor; + private volatile boolean _isReady = false; + private final Lock _isReadyLock = new ReentrantLock(); + private final Condition _isReadyCon = _isReadyLock.newCondition(); + private final Set<String> _preloadingSegmentsSet = ConcurrentHashMap.newKeySet(); Review Comment: This set is not necessary as can check isReady flag, via isReady() method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
