walterddr commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1248908703
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java:
##########
@@ -100,17 +100,14 @@ public MultiStageOperator visitAggregate(AggregateNode
node, PhysicalPlanContext
DataSchema inputSchema = node.getInputs().get(0).getDataSchema();
DataSchema resultSchema = node.getDataSchema();
- // TODO(Sonam): Rename to AggregateOperator when the planner changes are
merged.
-// boolean extractFinalResult = AggregateNode.isFinalStage(node);
-// boolean isIntermediateStage = AggregateNode.isIntermediateStage(node);
-// boolean isLeafStage = AggregateNode.isLeafStage(node);
-// boolean treatIntermediateAsLeaf = node.isTreatIntermediateStageAsLeaf();
-//
-// return new NewAggregateOperator(context.getOpChainExecutionContext(),
nextOperator, resultSchema, inputSchema,
-// node.getAggCalls(), node.getGroupSet(), isLeafStage,
isIntermediateStage, extractFinalResult,
-// treatIntermediateAsLeaf);
- return new AggregateOperator(context.getOpChainExecutionContext(),
nextOperator, node.getDataSchema(),
- node.getAggCalls(), node.getGroupSet(),
node.getInputs().get(0).getDataSchema());
+ boolean extractFinalResult = AggregateNode.isFinalStage(node);
+ boolean isIntermediateStage = AggregateNode.isIntermediateStage(node);
+ boolean isLeafStage = AggregateNode.isLeafStage(node);
+ boolean treatIntermediateAsLeaf = node.isTreatIntermediateStageAsLeaf();
Review Comment:
directly set mode is much simplier see previous comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
