[GitHub] [pinot] Jackie-Jiang closed issue #10608: Clean up replicaGroupStrategyConfig / replicaGroupPartitionConfig

Jackie-Jiang closed issue #10608: Clean up replicaGroupStrategyConfig / replicaGroupPartitionConfig URL: https://github.com/apache/pinot/issues/10608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pinot] branch master updated: 10608: Changes for adding partitionColumn in replicaGroupPartitionConfig (#10656)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 51bf75efa6 10608: Changes for adding partitionCol

[GitHub] [pinot] Jackie-Jiang merged pull request #10656: 10608: Changes for adding partitionColumn in replicaGroupPartitionConfig

Jackie-Jiang merged PR #10656: URL: https://github.com/apache/pinot/pull/10656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10656: 10608: Changes for adding partitionColumn in replicaGroupPartitionConfig

Jackie-Jiang commented on code in PR #10656: URL: https://github.com/apache/pinot/pull/10656#discussion_r1207506425 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java: ## @@ -444,4 +446,29 @@ public static boolean hasPreConfiguredInstancePa

[pinot] branch master updated (5ee6e137c0 -> c8531ce4d4)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 5ee6e137c0 [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module (#10791) add

[GitHub] [pinot] Jackie-Jiang merged pull request #10650: [bugfix] fix floating point and integral type backward incompatible issue

Jackie-Jiang merged PR #10650: URL: https://github.com/apache/pinot/pull/10650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10656: 10608: Changes for adding partitionColumn in replicaGroupPartitionConfig

abhioncbr commented on code in PR #10656: URL: https://github.com/apache/pinot/pull/10656#discussion_r1207501501 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java: ## @@ -444,4 +446,36 @@ public static boolean hasPreConfiguredInstanceParti

[GitHub] [pinot] walterddr commented on a diff in pull request #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

walterddr commented on code in PR #10779: URL: https://github.com/apache/pinot/pull/10779#discussion_r1207495051 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerRequestPlanVisitor.java: ## @@ -0,0 +1,189 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] walterddr commented on a diff in pull request #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

walterddr commented on code in PR #10779: URL: https://github.com/apache/pinot/pull/10779#discussion_r1207493170 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -143,22 +148,51 @@ public void shutDown() } public void processQue

[GitHub] [pinot] walterddr commented on a diff in pull request #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

walterddr commented on code in PR #10779: URL: https://github.com/apache/pinot/pull/10779#discussion_r1207492947 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -143,22 +148,51 @@ public void shutDown() } public void processQue

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10656: 10608: Changes for adding partitionColumn in replicaGroupPartitionConfig

Jackie-Jiang commented on code in PR #10656: URL: https://github.com/apache/pinot/pull/10656#discussion_r1207487758 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java: ## @@ -444,4 +446,36 @@ public static boolean hasPreConfiguredInstancePa

[GitHub] [pinot] ankitsultana commented on issue #10811: Pinot Handling of Special Characters in Realtime Ingestion

ankitsultana commented on issue #10811: URL: https://github.com/apache/pinot/issues/10811#issuecomment-1564981405 Oh nvm. Looks like the ingestion is happening. This can be ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] ankitsultana closed issue #10811: Pinot Handling of Special Characters in Realtime Ingestion

ankitsultana closed issue #10811: Pinot Handling of Special Characters in Realtime Ingestion URL: https://github.com/apache/pinot/issues/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10790: [multistage]: Changes for supporting Json scalar functions.

abhioncbr commented on code in PR #10790: URL: https://github.com/apache/pinot/pull/10790#discussion_r1207383670 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -308,13 +309,16 @@ private static boolean

[GitHub] [pinot] egalpin commented on pull request #10704: Keeps nullness attributes of merged in comparison column values

egalpin commented on PR #10704: URL: https://github.com/apache/pinot/pull/10704#issuecomment-1564961499 @Jackie-Jiang added [ComparisonColumnsTest.java](https://github.com/apache/pinot/pull/10704/files#diff-0b0f49a24426f7fe0645ee015d2729a806414f824a4a0943266137d9dbcca35c) -- This is an au

[GitHub] [pinot] ankitsultana opened a new issue, #10811: Pinot Handling of Special Characters in Realtime Ingestion

ankitsultana opened a new issue, #10811: URL: https://github.com/apache/pinot/issues/10811 We are seeing an issue where if some rows have a special character in one of the string columns (carriage return), then the row doesn't get ingested and seems to be getting dropped silently. We

[GitHub] [pinot] mayankshriv commented on pull request #10771: Enable case insensitivity by default

mayankshriv commented on PR #10771: URL: https://github.com/apache/pinot/pull/10771#issuecomment-156485 > This is getting a bit trickier than I thought, mostly because of the deprecated property. @Jackie-Jiang @walterddr @xiangfu0 , if you can write a few lines about the expected behavi

[GitHub] [pinot] walterddr commented on a diff in pull request #10790: [multistage]: Changes for supporting Json scalar functions.

walterddr commented on code in PR #10790: URL: https://github.com/apache/pinot/pull/10790#discussion_r1207272732 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -308,13 +309,16 @@ private static boolean

[GitHub] [pinot] walterddr commented on a diff in pull request #10779: [multistage][mvp] pipeline breaker and dynamic broadcast runtime for semi-join

walterddr commented on code in PR #10779: URL: https://github.com/apache/pinot/pull/10779#discussion_r1207267751 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -143,22 +148,51 @@ public void shutDown() } public void processQue

[GitHub] [pinot] codecov-commenter commented on pull request #10810: [multistage][bugfix] fix array type empty issue

codecov-commenter commented on PR #10810: URL: https://github.com/apache/pinot/pull/10810#issuecomment-1564827955 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #10809: [multistage][bugfix] order by limit is capped at 10_000

codecov-commenter commented on PR #10809: URL: https://github.com/apache/pinot/pull/10809#issuecomment-1564786197 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr opened a new pull request, #10810: [multistage][bugfix] fix array type empty issue

walterddr opened a new pull request, #10810: URL: https://github.com/apache/pinot/pull/10810 this fixes #10762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [pinot] walterddr commented on issue #10762: RowDataBlock throws exceptions during ser/de of MV byte and empty MV types

walterddr commented on issue #10762: URL: https://github.com/apache/pinot/issues/10762#issuecomment-1564758343 int array fixed. BYTES array is never supported thus will not be fixed in this bugfix PR -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pinot] shenyu0127 commented on issue #10718: Support transform functions in query preprocessing if all the arguments are all literals

shenyu0127 commented on issue #10718: URL: https://github.com/apache/pinot/issues/10718#issuecomment-1564749324 I am not proposing to use the combination of`ScalarTransformFunctionWrapper` and scalar functions to replace transform functions. I am proposing to make the transform functions ca

[GitHub] [pinot] walterddr opened a new pull request, #10809: [hotifx][multistage] order by limit is capped at 10_000

walterddr opened a new pull request, #10809: URL: https://github.com/apache/pinot/pull/10809 SortOperator accidentally use the initial holder capacity as the limit parameter. this PR fixes this -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] Jackie-Jiang commented on issue #10762: RowDataBlock throws exceptions during ser/de of MV byte and empty MV types

Jackie-Jiang commented on issue #10762: URL: https://github.com/apache/pinot/issues/10762#issuecomment-1564719360 cc @walterddr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] wirybeaver commented on issue #10740: Delete segments whose min-max falls into the given time range

wirybeaver commented on issue #10740: URL: https://github.com/apache/pinot/issues/10740#issuecomment-1564682127 > @wirybeaver : what does the "min-max" in the GH description referring to? > > Side note: is it ok if we assign this issue to you? Yeah, I am good for the assignee. I

[pinot] branch master updated: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module (#10791)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5ee6e137c0 [multistage] Refactor StageMetadata fro

[GitHub] [pinot] walterddr merged pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr merged PR #10791: URL: https://github.com/apache/pinot/pull/10791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] walterddr commented on a diff in pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr commented on code in PR #10791: URL: https://github.com/apache/pinot/pull/10791#discussion_r1206986016 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -139,22 +140,24 @@ int submit(long requestId, DispatchableSub

[GitHub] [pinot] codecov-commenter commented on pull request #10792: Add required JSON annotation in H3IndexResolution

codecov-commenter commented on PR #10792: URL: https://github.com/apache/pinot/pull/10792#issuecomment-1564652325 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10792?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

walterddr commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206988449 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -91,4 +94,11 @@ public boolean equals(Object o) { public

[GitHub] [pinot] walterddr commented on a diff in pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr commented on code in PR #10791: URL: https://github.com/apache/pinot/pull/10791#discussion_r1206984009 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java: ## @@ -83,32 +93,30 @@ public void shutdown() { @Override public void subm

[GitHub] [pinot] gortiz commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

gortiz commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206984595 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -91,4 +94,11 @@ public boolean equals(Object o) { public in

[GitHub] [pinot] yupeng9 commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

yupeng9 commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206953061 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -91,4 +94,11 @@ public boolean equals(Object o) { public i

[GitHub] [pinot] gortiz commented on a diff in pull request #10528: PinotBufferFactory and a buffer implementation that uses Unsafe

gortiz commented on code in PR #10528: URL: https://github.com/apache/pinot/pull/10528#discussion_r1206375279 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/MmapMemory.java: ## @@ -0,0 +1,348 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] [pinot] gortiz commented on a diff in pull request #10528: PinotBufferFactory and a buffer implementation that uses Unsafe

gortiz commented on code in PR #10528: URL: https://github.com/apache/pinot/pull/10528#discussion_r1206375279 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/MmapMemory.java: ## @@ -0,0 +1,348 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] [pinot] gortiz commented on a diff in pull request #10528: PinotBufferFactory and a buffer implementation that uses Unsafe

gortiz commented on code in PR #10528: URL: https://github.com/apache/pinot/pull/10528#discussion_r1206374166 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/MmapMemory.java: ## @@ -0,0 +1,348 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] [pinot] gortiz commented on issue #9162: Explore alternative to LBuffer for larger than 2GB buffers

gortiz commented on issue #9162: URL: https://github.com/apache/pinot/issues/9162#issuecomment-1563949602 I've open https://github.com/apache/pinot/issues/10783 as a PEP and https://github.com/apache/pinot/pull/10528 as a PR in order to be able to run with Java 17 (and 21!) -- This is an

[GitHub] [pinot] gortiz commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

gortiz commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206336003 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -91,4 +94,11 @@ public boolean equals(Object o) { public in

[GitHub] [pinot] gortiz commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

gortiz commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206334783 ## pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/creator/H3IndexConfigTest.java: ## @@ -84,4 +84,16 @@ public void withSomeData() Assert.assert