gortiz commented on code in PR #10792:
URL: https://github.com/apache/pinot/pull/10792#discussion_r1206984595
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java:
##########
@@ -91,4 +94,11 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(_resolutions);
}
+
+ public static class ToIntListConverted extends
StdConverter<H3IndexResolution, List<Integer>> {
Review Comment:
Before this PR, the actual value that was serialized was a string like
`"5,6,13"`, whose size codified as a JSON is 8 characters. The new codification
is the same (`[5,6,13]`). The larger value that can be represented like that is
`[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]`, which is 35 characters (and TBH I
don't know if it is a valid resolution).
On the other hand, the numeric codification is a short, whose larger utf8
value would be `-32768`, which is 6 characters.
Sometimes the array codification will be better. For example, `[14]`
requires 4 chars, while it would be represented as `16384` in the short
codification. But there the values where this happens is very small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
